2019-06-04 16:11:33 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2014-06-15 06:27:00 +08:00
|
|
|
/*
|
|
|
|
* iio/adc/max1027.c
|
|
|
|
* Copyright (C) 2014 Philippe Reynes
|
|
|
|
*
|
|
|
|
* based on linux/drivers/iio/ad7923.c
|
|
|
|
* Copyright 2011 Analog Devices Inc (from AD7923 Driver)
|
|
|
|
* Copyright 2012 CS Systemes d'Information
|
|
|
|
*
|
|
|
|
* max1027.c
|
|
|
|
*
|
|
|
|
* Partial support for max1027 and similar chips.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/spi/spi.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
|
|
|
|
#include <linux/iio/iio.h>
|
|
|
|
#include <linux/iio/buffer.h>
|
|
|
|
#include <linux/iio/trigger.h>
|
|
|
|
#include <linux/iio/trigger_consumer.h>
|
|
|
|
#include <linux/iio/triggered_buffer.h>
|
|
|
|
|
|
|
|
#define MAX1027_CONV_REG BIT(7)
|
|
|
|
#define MAX1027_SETUP_REG BIT(6)
|
|
|
|
#define MAX1027_AVG_REG BIT(5)
|
|
|
|
#define MAX1027_RST_REG BIT(4)
|
|
|
|
|
|
|
|
/* conversion register */
|
|
|
|
#define MAX1027_TEMP BIT(0)
|
|
|
|
#define MAX1027_SCAN_0_N (0x00 << 1)
|
|
|
|
#define MAX1027_SCAN_N_M (0x01 << 1)
|
|
|
|
#define MAX1027_SCAN_N (0x02 << 1)
|
|
|
|
#define MAX1027_NOSCAN (0x03 << 1)
|
|
|
|
#define MAX1027_CHAN(n) ((n) << 3)
|
|
|
|
|
|
|
|
/* setup register */
|
|
|
|
#define MAX1027_UNIPOLAR 0x02
|
|
|
|
#define MAX1027_BIPOLAR 0x03
|
|
|
|
#define MAX1027_REF_MODE0 (0x00 << 2)
|
|
|
|
#define MAX1027_REF_MODE1 (0x01 << 2)
|
|
|
|
#define MAX1027_REF_MODE2 (0x02 << 2)
|
|
|
|
#define MAX1027_REF_MODE3 (0x03 << 2)
|
|
|
|
#define MAX1027_CKS_MODE0 (0x00 << 4)
|
|
|
|
#define MAX1027_CKS_MODE1 (0x01 << 4)
|
|
|
|
#define MAX1027_CKS_MODE2 (0x02 << 4)
|
|
|
|
#define MAX1027_CKS_MODE3 (0x03 << 4)
|
|
|
|
|
|
|
|
/* averaging register */
|
|
|
|
#define MAX1027_NSCAN_4 0x00
|
|
|
|
#define MAX1027_NSCAN_8 0x01
|
|
|
|
#define MAX1027_NSCAN_12 0x02
|
|
|
|
#define MAX1027_NSCAN_16 0x03
|
|
|
|
#define MAX1027_NAVG_4 (0x00 << 2)
|
|
|
|
#define MAX1027_NAVG_8 (0x01 << 2)
|
|
|
|
#define MAX1027_NAVG_16 (0x02 << 2)
|
|
|
|
#define MAX1027_NAVG_32 (0x03 << 2)
|
|
|
|
#define MAX1027_AVG_EN BIT(4)
|
|
|
|
|
|
|
|
enum max1027_id {
|
|
|
|
max1027,
|
|
|
|
max1029,
|
|
|
|
max1031,
|
2019-10-11 22:43:44 +08:00
|
|
|
max1227,
|
|
|
|
max1229,
|
|
|
|
max1231,
|
2014-06-15 06:27:00 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct spi_device_id max1027_id[] = {
|
|
|
|
{"max1027", max1027},
|
|
|
|
{"max1029", max1029},
|
|
|
|
{"max1031", max1031},
|
2019-10-11 22:43:44 +08:00
|
|
|
{"max1227", max1227},
|
|
|
|
{"max1229", max1229},
|
|
|
|
{"max1231", max1231},
|
2014-06-15 06:27:00 +08:00
|
|
|
{}
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(spi, max1027_id);
|
|
|
|
|
|
|
|
#ifdef CONFIG_OF
|
|
|
|
static const struct of_device_id max1027_adc_dt_ids[] = {
|
|
|
|
{ .compatible = "maxim,max1027" },
|
|
|
|
{ .compatible = "maxim,max1029" },
|
|
|
|
{ .compatible = "maxim,max1031" },
|
2019-10-11 22:43:44 +08:00
|
|
|
{ .compatible = "maxim,max1227" },
|
|
|
|
{ .compatible = "maxim,max1229" },
|
|
|
|
{ .compatible = "maxim,max1231" },
|
2014-06-15 06:27:00 +08:00
|
|
|
{},
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, max1027_adc_dt_ids);
|
|
|
|
#endif
|
|
|
|
|
2019-10-11 22:43:43 +08:00
|
|
|
#define MAX1027_V_CHAN(index, depth) \
|
2014-06-15 06:27:00 +08:00
|
|
|
{ \
|
|
|
|
.type = IIO_VOLTAGE, \
|
|
|
|
.indexed = 1, \
|
|
|
|
.channel = index, \
|
|
|
|
.info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
|
|
|
|
.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \
|
|
|
|
.scan_index = index + 1, \
|
|
|
|
.scan_type = { \
|
|
|
|
.sign = 'u', \
|
2019-10-11 22:43:43 +08:00
|
|
|
.realbits = depth, \
|
2014-06-15 06:27:00 +08:00
|
|
|
.storagebits = 16, \
|
|
|
|
.shift = 2, \
|
|
|
|
.endianness = IIO_BE, \
|
|
|
|
}, \
|
|
|
|
}
|
|
|
|
|
|
|
|
#define MAX1027_T_CHAN \
|
|
|
|
{ \
|
|
|
|
.type = IIO_TEMP, \
|
|
|
|
.channel = 0, \
|
|
|
|
.info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
|
|
|
|
.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \
|
|
|
|
.scan_index = 0, \
|
|
|
|
.scan_type = { \
|
|
|
|
.sign = 'u', \
|
|
|
|
.realbits = 12, \
|
|
|
|
.storagebits = 16, \
|
|
|
|
.endianness = IIO_BE, \
|
|
|
|
}, \
|
|
|
|
}
|
|
|
|
|
2019-10-11 22:43:43 +08:00
|
|
|
#define MAX1X27_CHANNELS(depth) \
|
|
|
|
MAX1027_T_CHAN, \
|
|
|
|
MAX1027_V_CHAN(0, depth), \
|
|
|
|
MAX1027_V_CHAN(1, depth), \
|
|
|
|
MAX1027_V_CHAN(2, depth), \
|
|
|
|
MAX1027_V_CHAN(3, depth), \
|
|
|
|
MAX1027_V_CHAN(4, depth), \
|
|
|
|
MAX1027_V_CHAN(5, depth), \
|
|
|
|
MAX1027_V_CHAN(6, depth), \
|
|
|
|
MAX1027_V_CHAN(7, depth)
|
|
|
|
|
|
|
|
#define MAX1X29_CHANNELS(depth) \
|
|
|
|
MAX1X27_CHANNELS(depth), \
|
|
|
|
MAX1027_V_CHAN(8, depth), \
|
|
|
|
MAX1027_V_CHAN(9, depth), \
|
|
|
|
MAX1027_V_CHAN(10, depth), \
|
|
|
|
MAX1027_V_CHAN(11, depth)
|
|
|
|
|
|
|
|
#define MAX1X31_CHANNELS(depth) \
|
|
|
|
MAX1X27_CHANNELS(depth), \
|
|
|
|
MAX1X29_CHANNELS(depth), \
|
|
|
|
MAX1027_V_CHAN(12, depth), \
|
|
|
|
MAX1027_V_CHAN(13, depth), \
|
|
|
|
MAX1027_V_CHAN(14, depth), \
|
|
|
|
MAX1027_V_CHAN(15, depth)
|
|
|
|
|
2014-06-15 06:27:00 +08:00
|
|
|
static const struct iio_chan_spec max1027_channels[] = {
|
2019-10-11 22:43:43 +08:00
|
|
|
MAX1X27_CHANNELS(10),
|
2014-06-15 06:27:00 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct iio_chan_spec max1029_channels[] = {
|
2019-10-11 22:43:43 +08:00
|
|
|
MAX1X29_CHANNELS(10),
|
2014-06-15 06:27:00 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct iio_chan_spec max1031_channels[] = {
|
2019-10-11 22:43:43 +08:00
|
|
|
MAX1X31_CHANNELS(10),
|
2014-06-15 06:27:00 +08:00
|
|
|
};
|
|
|
|
|
2019-10-11 22:43:44 +08:00
|
|
|
static const struct iio_chan_spec max1227_channels[] = {
|
|
|
|
MAX1X27_CHANNELS(12),
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct iio_chan_spec max1229_channels[] = {
|
|
|
|
MAX1X29_CHANNELS(12),
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct iio_chan_spec max1231_channels[] = {
|
|
|
|
MAX1X31_CHANNELS(12),
|
|
|
|
};
|
|
|
|
|
2014-06-15 06:27:00 +08:00
|
|
|
static const unsigned long max1027_available_scan_masks[] = {
|
|
|
|
0x000001ff,
|
|
|
|
0x00000000,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const unsigned long max1029_available_scan_masks[] = {
|
|
|
|
0x00001fff,
|
|
|
|
0x00000000,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const unsigned long max1031_available_scan_masks[] = {
|
|
|
|
0x0001ffff,
|
|
|
|
0x00000000,
|
|
|
|
};
|
|
|
|
|
|
|
|
struct max1027_chip_info {
|
|
|
|
const struct iio_chan_spec *channels;
|
|
|
|
unsigned int num_channels;
|
|
|
|
const unsigned long *available_scan_masks;
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct max1027_chip_info max1027_chip_info_tbl[] = {
|
|
|
|
[max1027] = {
|
|
|
|
.channels = max1027_channels,
|
|
|
|
.num_channels = ARRAY_SIZE(max1027_channels),
|
|
|
|
.available_scan_masks = max1027_available_scan_masks,
|
|
|
|
},
|
|
|
|
[max1029] = {
|
|
|
|
.channels = max1029_channels,
|
|
|
|
.num_channels = ARRAY_SIZE(max1029_channels),
|
|
|
|
.available_scan_masks = max1029_available_scan_masks,
|
|
|
|
},
|
|
|
|
[max1031] = {
|
|
|
|
.channels = max1031_channels,
|
|
|
|
.num_channels = ARRAY_SIZE(max1031_channels),
|
|
|
|
.available_scan_masks = max1031_available_scan_masks,
|
|
|
|
},
|
2019-10-11 22:43:44 +08:00
|
|
|
[max1227] = {
|
|
|
|
.channels = max1227_channels,
|
|
|
|
.num_channels = ARRAY_SIZE(max1227_channels),
|
|
|
|
.available_scan_masks = max1027_available_scan_masks,
|
|
|
|
},
|
|
|
|
[max1229] = {
|
|
|
|
.channels = max1229_channels,
|
|
|
|
.num_channels = ARRAY_SIZE(max1229_channels),
|
|
|
|
.available_scan_masks = max1029_available_scan_masks,
|
|
|
|
},
|
|
|
|
[max1231] = {
|
|
|
|
.channels = max1231_channels,
|
|
|
|
.num_channels = ARRAY_SIZE(max1231_channels),
|
|
|
|
.available_scan_masks = max1031_available_scan_masks,
|
|
|
|
},
|
2014-06-15 06:27:00 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
struct max1027_state {
|
|
|
|
const struct max1027_chip_info *info;
|
|
|
|
struct spi_device *spi;
|
|
|
|
struct iio_trigger *trig;
|
|
|
|
__be16 *buffer;
|
|
|
|
struct mutex lock;
|
|
|
|
|
|
|
|
u8 reg ____cacheline_aligned;
|
|
|
|
};
|
|
|
|
|
|
|
|
static int max1027_read_single_value(struct iio_dev *indio_dev,
|
|
|
|
struct iio_chan_spec const *chan,
|
|
|
|
int *val)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
struct max1027_state *st = iio_priv(indio_dev);
|
|
|
|
|
|
|
|
if (iio_buffer_enabled(indio_dev)) {
|
|
|
|
dev_warn(&indio_dev->dev, "trigger mode already enabled");
|
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Start acquisition on conversion register write */
|
|
|
|
st->reg = MAX1027_SETUP_REG | MAX1027_REF_MODE2 | MAX1027_CKS_MODE2;
|
|
|
|
ret = spi_write(st->spi, &st->reg, 1);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(&indio_dev->dev,
|
|
|
|
"Failed to configure setup register\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Configure conversion register with the requested chan */
|
|
|
|
st->reg = MAX1027_CONV_REG | MAX1027_CHAN(chan->channel) |
|
2016-09-24 04:04:48 +08:00
|
|
|
MAX1027_NOSCAN;
|
|
|
|
if (chan->type == IIO_TEMP)
|
|
|
|
st->reg |= MAX1027_TEMP;
|
2014-06-15 06:27:00 +08:00
|
|
|
ret = spi_write(st->spi, &st->reg, 1);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(&indio_dev->dev,
|
|
|
|
"Failed to configure conversion register\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* For an unknown reason, when we use the mode "10" (write
|
|
|
|
* conversion register), the interrupt doesn't occur every time.
|
|
|
|
* So we just wait 1 ms.
|
|
|
|
*/
|
|
|
|
mdelay(1);
|
|
|
|
|
|
|
|
/* Read result */
|
|
|
|
ret = spi_read(st->spi, st->buffer, (chan->type == IIO_TEMP) ? 4 : 2);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
*val = be16_to_cpu(st->buffer[0]);
|
|
|
|
|
|
|
|
return IIO_VAL_INT;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int max1027_read_raw(struct iio_dev *indio_dev,
|
|
|
|
struct iio_chan_spec const *chan,
|
|
|
|
int *val, int *val2, long mask)
|
|
|
|
{
|
|
|
|
int ret = 0;
|
|
|
|
struct max1027_state *st = iio_priv(indio_dev);
|
|
|
|
|
|
|
|
mutex_lock(&st->lock);
|
|
|
|
|
|
|
|
switch (mask) {
|
|
|
|
case IIO_CHAN_INFO_RAW:
|
|
|
|
ret = max1027_read_single_value(indio_dev, chan, val);
|
|
|
|
break;
|
|
|
|
case IIO_CHAN_INFO_SCALE:
|
|
|
|
switch (chan->type) {
|
|
|
|
case IIO_TEMP:
|
|
|
|
*val = 1;
|
|
|
|
*val2 = 8;
|
|
|
|
ret = IIO_VAL_FRACTIONAL;
|
|
|
|
break;
|
|
|
|
case IIO_VOLTAGE:
|
|
|
|
*val = 2500;
|
2019-10-11 22:43:43 +08:00
|
|
|
*val2 = chan->scan_type.realbits;
|
2014-06-15 06:27:00 +08:00
|
|
|
ret = IIO_VAL_FRACTIONAL_LOG2;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
ret = -EINVAL;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
ret = -EINVAL;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
mutex_unlock(&st->lock);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int max1027_debugfs_reg_access(struct iio_dev *indio_dev,
|
|
|
|
unsigned reg, unsigned writeval,
|
|
|
|
unsigned *readval)
|
|
|
|
{
|
|
|
|
struct max1027_state *st = iio_priv(indio_dev);
|
|
|
|
u8 *val = (u8 *)st->buffer;
|
|
|
|
|
2019-10-11 22:43:40 +08:00
|
|
|
if (readval) {
|
|
|
|
int ret = spi_read(st->spi, val, 2);
|
|
|
|
*readval = be16_to_cpu(st->buffer[0]);
|
|
|
|
return ret;
|
|
|
|
}
|
2014-06-15 06:27:00 +08:00
|
|
|
|
|
|
|
*val = (u8)writeval;
|
|
|
|
return spi_write(st->spi, val, 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int max1027_validate_trigger(struct iio_dev *indio_dev,
|
|
|
|
struct iio_trigger *trig)
|
|
|
|
{
|
|
|
|
struct max1027_state *st = iio_priv(indio_dev);
|
|
|
|
|
|
|
|
if (st->trig != trig)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int max1027_set_trigger_state(struct iio_trigger *trig, bool state)
|
|
|
|
{
|
|
|
|
struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig);
|
|
|
|
struct max1027_state *st = iio_priv(indio_dev);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (state) {
|
|
|
|
/* Start acquisition on cnvst */
|
|
|
|
st->reg = MAX1027_SETUP_REG | MAX1027_CKS_MODE0 |
|
|
|
|
MAX1027_REF_MODE2;
|
|
|
|
ret = spi_write(st->spi, &st->reg, 1);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
/* Scan from 0 to max */
|
|
|
|
st->reg = MAX1027_CONV_REG | MAX1027_CHAN(0) |
|
|
|
|
MAX1027_SCAN_N_M | MAX1027_TEMP;
|
|
|
|
ret = spi_write(st->spi, &st->reg, 1);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
} else {
|
|
|
|
/* Start acquisition on conversion register write */
|
|
|
|
st->reg = MAX1027_SETUP_REG | MAX1027_CKS_MODE2 |
|
|
|
|
MAX1027_REF_MODE2;
|
|
|
|
ret = spi_write(st->spi, &st->reg, 1);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static irqreturn_t max1027_trigger_handler(int irq, void *private)
|
|
|
|
{
|
2017-04-01 22:06:14 +08:00
|
|
|
struct iio_poll_func *pf = private;
|
2014-06-15 06:27:00 +08:00
|
|
|
struct iio_dev *indio_dev = pf->indio_dev;
|
|
|
|
struct max1027_state *st = iio_priv(indio_dev);
|
|
|
|
|
|
|
|
pr_debug("%s(irq=%d, private=0x%p)\n", __func__, irq, private);
|
|
|
|
|
|
|
|
/* fill buffer with all channel */
|
|
|
|
spi_read(st->spi, st->buffer, indio_dev->masklength * 2);
|
|
|
|
|
|
|
|
iio_push_to_buffers(indio_dev, st->buffer);
|
|
|
|
|
|
|
|
iio_trigger_notify_done(indio_dev->trig);
|
|
|
|
|
|
|
|
return IRQ_HANDLED;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct iio_trigger_ops max1027_trigger_ops = {
|
2016-09-23 23:19:43 +08:00
|
|
|
.validate_device = &iio_trigger_validate_own_device,
|
2014-06-15 06:27:00 +08:00
|
|
|
.set_trigger_state = &max1027_set_trigger_state,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct iio_info max1027_info = {
|
|
|
|
.read_raw = &max1027_read_raw,
|
|
|
|
.validate_trigger = &max1027_validate_trigger,
|
|
|
|
.debugfs_reg_access = &max1027_debugfs_reg_access,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int max1027_probe(struct spi_device *spi)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
struct iio_dev *indio_dev;
|
|
|
|
struct max1027_state *st;
|
|
|
|
|
|
|
|
pr_debug("%s: probe(spi = 0x%p)\n", __func__, spi);
|
|
|
|
|
|
|
|
indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
|
|
|
|
if (indio_dev == NULL) {
|
|
|
|
pr_err("Can't allocate iio device\n");
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
spi_set_drvdata(spi, indio_dev);
|
|
|
|
|
|
|
|
st = iio_priv(indio_dev);
|
|
|
|
st->spi = spi;
|
|
|
|
st->info = &max1027_chip_info_tbl[spi_get_device_id(spi)->driver_data];
|
|
|
|
|
|
|
|
mutex_init(&st->lock);
|
|
|
|
|
|
|
|
indio_dev->name = spi_get_device_id(spi)->name;
|
|
|
|
indio_dev->dev.parent = &spi->dev;
|
2016-07-03 08:26:33 +08:00
|
|
|
indio_dev->dev.of_node = spi->dev.of_node;
|
2014-06-15 06:27:00 +08:00
|
|
|
indio_dev->info = &max1027_info;
|
|
|
|
indio_dev->modes = INDIO_DIRECT_MODE;
|
|
|
|
indio_dev->channels = st->info->channels;
|
|
|
|
indio_dev->num_channels = st->info->num_channels;
|
|
|
|
indio_dev->available_scan_masks = st->info->available_scan_masks;
|
|
|
|
|
treewide: devm_kmalloc() -> devm_kmalloc_array()
The devm_kmalloc() function has a 2-factor argument form,
devm_kmalloc_array(). This patch replaces cases of:
devm_kmalloc(handle, a * b, gfp)
with:
devm_kmalloc_array(handle, a * b, gfp)
as well as handling cases of:
devm_kmalloc(handle, a * b * c, gfp)
with:
devm_kmalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kmalloc_array(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kmalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kmalloc..." instead of "= devm_kmalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kmalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kmalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kmalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kmalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kmalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kmalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kmalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kmalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kmalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kmalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kmalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kmalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kmalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kmalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kmalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kmalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kmalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kmalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kmalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kmalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kmalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kmalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kmalloc(HANDLE, C1 * C2, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kmalloc
+ devm_kmalloc_array
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 05:04:57 +08:00
|
|
|
st->buffer = devm_kmalloc_array(&indio_dev->dev,
|
|
|
|
indio_dev->num_channels, 2,
|
2014-06-15 06:27:00 +08:00
|
|
|
GFP_KERNEL);
|
|
|
|
if (st->buffer == NULL) {
|
2015-02-27 22:52:31 +08:00
|
|
|
dev_err(&indio_dev->dev, "Can't allocate buffer\n");
|
2014-06-15 06:27:00 +08:00
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
2019-10-11 22:43:41 +08:00
|
|
|
if (spi->irq) {
|
|
|
|
ret = devm_iio_triggered_buffer_setup(&spi->dev, indio_dev,
|
|
|
|
&iio_pollfunc_store_time,
|
|
|
|
&max1027_trigger_handler,
|
|
|
|
NULL);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(&indio_dev->dev, "Failed to setup buffer\n");
|
|
|
|
return ret;
|
|
|
|
}
|
2014-06-15 06:27:00 +08:00
|
|
|
|
2019-10-11 22:43:41 +08:00
|
|
|
st->trig = devm_iio_trigger_alloc(&spi->dev, "%s-trigger",
|
|
|
|
indio_dev->name);
|
|
|
|
if (st->trig == NULL) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
dev_err(&indio_dev->dev,
|
|
|
|
"Failed to allocate iio trigger\n");
|
|
|
|
return ret;
|
|
|
|
}
|
2014-06-15 06:27:00 +08:00
|
|
|
|
2019-10-11 22:43:41 +08:00
|
|
|
st->trig->ops = &max1027_trigger_ops;
|
|
|
|
st->trig->dev.parent = &spi->dev;
|
|
|
|
iio_trigger_set_drvdata(st->trig, indio_dev);
|
|
|
|
iio_trigger_register(st->trig);
|
|
|
|
|
|
|
|
ret = devm_request_threaded_irq(&spi->dev, spi->irq,
|
|
|
|
iio_trigger_generic_data_rdy_poll,
|
|
|
|
NULL,
|
|
|
|
IRQF_TRIGGER_FALLING,
|
|
|
|
spi->dev.driver->name,
|
|
|
|
st->trig);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(&indio_dev->dev, "Failed to allocate IRQ.\n");
|
|
|
|
return ret;
|
|
|
|
}
|
2014-06-15 06:27:00 +08:00
|
|
|
}
|
|
|
|
|
2019-10-11 22:43:42 +08:00
|
|
|
/* Internal reset */
|
|
|
|
st->reg = MAX1027_RST_REG;
|
|
|
|
ret = spi_write(st->spi, &st->reg, 1);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(&indio_dev->dev, "Failed to reset the ADC\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-06-15 06:27:00 +08:00
|
|
|
/* Disable averaging */
|
|
|
|
st->reg = MAX1027_AVG_REG;
|
|
|
|
ret = spi_write(st->spi, &st->reg, 1);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(&indio_dev->dev, "Failed to configure averaging register\n");
|
2019-08-11 20:51:46 +08:00
|
|
|
return ret;
|
2014-06-15 06:27:00 +08:00
|
|
|
}
|
|
|
|
|
2019-08-11 20:51:46 +08:00
|
|
|
return devm_iio_device_register(&spi->dev, indio_dev);
|
2014-06-15 06:27:00 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct spi_driver max1027_driver = {
|
|
|
|
.driver = {
|
|
|
|
.name = "max1027",
|
2015-08-20 15:07:24 +08:00
|
|
|
.of_match_table = of_match_ptr(max1027_adc_dt_ids),
|
2014-06-15 06:27:00 +08:00
|
|
|
},
|
|
|
|
.probe = max1027_probe,
|
|
|
|
.id_table = max1027_id,
|
|
|
|
};
|
|
|
|
module_spi_driver(max1027_driver);
|
|
|
|
|
|
|
|
MODULE_AUTHOR("Philippe Reynes <tremyfr@yahoo.fr>");
|
2019-10-11 22:43:44 +08:00
|
|
|
MODULE_DESCRIPTION("MAX1X27/MAX1X29/MAX1X31 ADC");
|
2014-06-15 06:27:00 +08:00
|
|
|
MODULE_LICENSE("GPL v2");
|