2013-12-20 06:27:28 +08:00
|
|
|
/*
|
|
|
|
|
* rtc-isl12057 - Driver for Intersil ISL12057 I2C Real Time Clock
|
|
|
|
|
*
|
|
|
|
|
* Copyright (C) 2013, Arnaud EBALARD <arno@natisbad.org>
|
|
|
|
|
*
|
|
|
|
|
* This work is largely based on Intersil ISL1208 driver developed by
|
|
|
|
|
* Hebert Valerio Riedel <hvr@gnu.org>.
|
|
|
|
|
*
|
|
|
|
|
* Detailed datasheet on which this development is based is available here:
|
|
|
|
|
*
|
|
|
|
|
* http://natisbad.org/NAS2/refs/ISL12057.pdf
|
|
|
|
|
*
|
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
|
* (at your option) any later version.
|
|
|
|
|
*
|
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <linux/module.h>
|
|
|
|
|
#include <linux/mutex.h>
|
|
|
|
|
#include <linux/rtc.h>
|
|
|
|
|
#include <linux/i2c.h>
|
|
|
|
|
#include <linux/bcd.h>
|
|
|
|
|
#include <linux/of.h>
|
|
|
|
|
#include <linux/of_device.h>
|
|
|
|
|
#include <linux/regmap.h>
|
|
|
|
|
|
|
|
|
|
#define DRV_NAME "rtc-isl12057"
|
|
|
|
|
|
|
|
|
|
/* RTC section */
|
|
|
|
|
#define ISL12057_REG_RTC_SC 0x00 /* Seconds */
|
|
|
|
|
#define ISL12057_REG_RTC_MN 0x01 /* Minutes */
|
|
|
|
|
#define ISL12057_REG_RTC_HR 0x02 /* Hours */
|
|
|
|
|
#define ISL12057_REG_RTC_HR_PM BIT(5) /* AM/PM bit in 12h format */
|
|
|
|
|
#define ISL12057_REG_RTC_HR_MIL BIT(6) /* 24h/12h format */
|
|
|
|
|
#define ISL12057_REG_RTC_DW 0x03 /* Day of the Week */
|
|
|
|
|
#define ISL12057_REG_RTC_DT 0x04 /* Date */
|
|
|
|
|
#define ISL12057_REG_RTC_MO 0x05 /* Month */
|
2014-12-11 07:54:05 +08:00
|
|
|
#define ISL12057_REG_RTC_MO_CEN BIT(7) /* Century bit */
|
2013-12-20 06:27:28 +08:00
|
|
|
#define ISL12057_REG_RTC_YR 0x06 /* Year */
|
|
|
|
|
#define ISL12057_RTC_SEC_LEN 7
|
|
|
|
|
|
|
|
|
|
/* Alarm 1 section */
|
|
|
|
|
#define ISL12057_REG_A1_SC 0x07 /* Alarm 1 Seconds */
|
|
|
|
|
#define ISL12057_REG_A1_MN 0x08 /* Alarm 1 Minutes */
|
|
|
|
|
#define ISL12057_REG_A1_HR 0x09 /* Alarm 1 Hours */
|
|
|
|
|
#define ISL12057_REG_A1_HR_PM BIT(5) /* AM/PM bit in 12h format */
|
|
|
|
|
#define ISL12057_REG_A1_HR_MIL BIT(6) /* 24h/12h format */
|
|
|
|
|
#define ISL12057_REG_A1_DWDT 0x0A /* Alarm 1 Date / Day of the week */
|
|
|
|
|
#define ISL12057_REG_A1_DWDT_B BIT(6) /* DW / DT selection bit */
|
|
|
|
|
#define ISL12057_A1_SEC_LEN 4
|
|
|
|
|
|
|
|
|
|
/* Alarm 2 section */
|
|
|
|
|
#define ISL12057_REG_A2_MN 0x0B /* Alarm 2 Minutes */
|
|
|
|
|
#define ISL12057_REG_A2_HR 0x0C /* Alarm 2 Hours */
|
|
|
|
|
#define ISL12057_REG_A2_DWDT 0x0D /* Alarm 2 Date / Day of the week */
|
|
|
|
|
#define ISL12057_A2_SEC_LEN 3
|
|
|
|
|
|
|
|
|
|
/* Control/Status registers */
|
|
|
|
|
#define ISL12057_REG_INT 0x0E
|
|
|
|
|
#define ISL12057_REG_INT_A1IE BIT(0) /* Alarm 1 interrupt enable bit */
|
|
|
|
|
#define ISL12057_REG_INT_A2IE BIT(1) /* Alarm 2 interrupt enable bit */
|
|
|
|
|
#define ISL12057_REG_INT_INTCN BIT(2) /* Interrupt control enable bit */
|
|
|
|
|
#define ISL12057_REG_INT_RS1 BIT(3) /* Freq out control bit 1 */
|
|
|
|
|
#define ISL12057_REG_INT_RS2 BIT(4) /* Freq out control bit 2 */
|
|
|
|
|
#define ISL12057_REG_INT_EOSC BIT(7) /* Oscillator enable bit */
|
|
|
|
|
|
|
|
|
|
#define ISL12057_REG_SR 0x0F
|
|
|
|
|
#define ISL12057_REG_SR_A1F BIT(0) /* Alarm 1 interrupt bit */
|
|
|
|
|
#define ISL12057_REG_SR_A2F BIT(1) /* Alarm 2 interrupt bit */
|
|
|
|
|
#define ISL12057_REG_SR_OSF BIT(7) /* Oscillator failure bit */
|
|
|
|
|
|
|
|
|
|
/* Register memory map length */
|
|
|
|
|
#define ISL12057_MEM_MAP_LEN 0x10
|
|
|
|
|
|
|
|
|
|
struct isl12057_rtc_data {
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
struct rtc_device *rtc;
|
2013-12-20 06:27:28 +08:00
|
|
|
struct regmap *regmap;
|
|
|
|
|
struct mutex lock;
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
int irq;
|
2013-12-20 06:27:28 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static void isl12057_rtc_regs_to_tm(struct rtc_time *tm, u8 *regs)
|
|
|
|
|
{
|
|
|
|
|
tm->tm_sec = bcd2bin(regs[ISL12057_REG_RTC_SC]);
|
|
|
|
|
tm->tm_min = bcd2bin(regs[ISL12057_REG_RTC_MN]);
|
|
|
|
|
|
|
|
|
|
if (regs[ISL12057_REG_RTC_HR] & ISL12057_REG_RTC_HR_MIL) { /* AM/PM */
|
2014-12-11 07:54:02 +08:00
|
|
|
tm->tm_hour = bcd2bin(regs[ISL12057_REG_RTC_HR] & 0x1f);
|
2013-12-20 06:27:28 +08:00
|
|
|
if (regs[ISL12057_REG_RTC_HR] & ISL12057_REG_RTC_HR_PM)
|
|
|
|
|
tm->tm_hour += 12;
|
|
|
|
|
} else { /* 24 hour mode */
|
|
|
|
|
tm->tm_hour = bcd2bin(regs[ISL12057_REG_RTC_HR] & 0x3f);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
tm->tm_mday = bcd2bin(regs[ISL12057_REG_RTC_DT]);
|
|
|
|
|
tm->tm_wday = bcd2bin(regs[ISL12057_REG_RTC_DW]) - 1; /* starts at 1 */
|
2014-12-11 07:54:02 +08:00
|
|
|
tm->tm_mon = bcd2bin(regs[ISL12057_REG_RTC_MO] & 0x1f) - 1; /* ditto */
|
2013-12-20 06:27:28 +08:00
|
|
|
tm->tm_year = bcd2bin(regs[ISL12057_REG_RTC_YR]) + 100;
|
2014-12-11 07:54:05 +08:00
|
|
|
|
|
|
|
|
/* Check if years register has overflown from 99 to 00 */
|
|
|
|
|
if (regs[ISL12057_REG_RTC_MO] & ISL12057_REG_RTC_MO_CEN)
|
|
|
|
|
tm->tm_year += 100;
|
2013-12-20 06:27:28 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int isl12057_rtc_tm_to_regs(u8 *regs, struct rtc_time *tm)
|
|
|
|
|
{
|
2014-12-11 07:54:05 +08:00
|
|
|
u8 century_bit;
|
|
|
|
|
|
2013-12-20 06:27:28 +08:00
|
|
|
/*
|
|
|
|
|
* The clock has an 8 bit wide bcd-coded register for the year.
|
2014-12-11 07:54:05 +08:00
|
|
|
* It also has a century bit encoded in MO flag which provides
|
|
|
|
|
* information about overflow of year register from 99 to 00.
|
2013-12-20 06:27:28 +08:00
|
|
|
* tm_year is an offset from 1900 and we are interested in the
|
2014-12-11 07:54:05 +08:00
|
|
|
* 2000-2199 range, so any value less than 100 or larger than
|
|
|
|
|
* 299 is invalid.
|
2013-12-20 06:27:28 +08:00
|
|
|
*/
|
2014-12-11 07:54:05 +08:00
|
|
|
if (tm->tm_year < 100 || tm->tm_year > 299)
|
2013-12-20 06:27:28 +08:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
2014-12-11 07:54:05 +08:00
|
|
|
century_bit = (tm->tm_year > 199) ? ISL12057_REG_RTC_MO_CEN : 0;
|
|
|
|
|
|
2013-12-20 06:27:28 +08:00
|
|
|
regs[ISL12057_REG_RTC_SC] = bin2bcd(tm->tm_sec);
|
|
|
|
|
regs[ISL12057_REG_RTC_MN] = bin2bcd(tm->tm_min);
|
|
|
|
|
regs[ISL12057_REG_RTC_HR] = bin2bcd(tm->tm_hour); /* 24-hour format */
|
|
|
|
|
regs[ISL12057_REG_RTC_DT] = bin2bcd(tm->tm_mday);
|
2014-12-11 07:54:05 +08:00
|
|
|
regs[ISL12057_REG_RTC_MO] = bin2bcd(tm->tm_mon + 1) | century_bit;
|
|
|
|
|
regs[ISL12057_REG_RTC_YR] = bin2bcd(tm->tm_year % 100);
|
2013-12-20 06:27:28 +08:00
|
|
|
regs[ISL12057_REG_RTC_DW] = bin2bcd(tm->tm_wday + 1);
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Try and match register bits w/ fixed null values to see whether we
|
|
|
|
|
* are dealing with an ISL12057. Note: this function is called early
|
|
|
|
|
* during init and hence does need mutex protection.
|
|
|
|
|
*/
|
|
|
|
|
static int isl12057_i2c_validate_chip(struct regmap *regmap)
|
|
|
|
|
{
|
|
|
|
|
u8 regs[ISL12057_MEM_MAP_LEN];
|
|
|
|
|
static const u8 mask[ISL12057_MEM_MAP_LEN] = { 0x80, 0x80, 0x80, 0xf8,
|
|
|
|
|
0xc0, 0x60, 0x00, 0x00,
|
|
|
|
|
0x00, 0x00, 0x00, 0x00,
|
|
|
|
|
0x00, 0x00, 0x60, 0x7c };
|
|
|
|
|
int ret, i;
|
|
|
|
|
|
|
|
|
|
ret = regmap_bulk_read(regmap, 0, regs, ISL12057_MEM_MAP_LEN);
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < ISL12057_MEM_MAP_LEN; ++i) {
|
|
|
|
|
if (regs[i] & mask[i]) /* check if bits are cleared */
|
|
|
|
|
return -ENODEV;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
static int _isl12057_rtc_clear_alarm(struct device *dev)
|
|
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *data = dev_get_drvdata(dev);
|
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
|
|
ret = regmap_update_bits(data->regmap, ISL12057_REG_SR,
|
|
|
|
|
ISL12057_REG_SR_A1F, 0);
|
|
|
|
|
if (ret)
|
|
|
|
|
dev_err(dev, "%s: clearing alarm failed (%d)\n", __func__, ret);
|
|
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int _isl12057_rtc_update_alarm(struct device *dev, int enable)
|
|
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *data = dev_get_drvdata(dev);
|
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
|
|
ret = regmap_update_bits(data->regmap, ISL12057_REG_INT,
|
|
|
|
|
ISL12057_REG_INT_A1IE,
|
|
|
|
|
enable ? ISL12057_REG_INT_A1IE : 0);
|
|
|
|
|
if (ret)
|
|
|
|
|
dev_err(dev, "%s: changing alarm interrupt flag failed (%d)\n",
|
|
|
|
|
__func__, ret);
|
|
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Note: as we only read from device and do not perform any update, there is
|
|
|
|
|
* no need for an equivalent function which would try and get driver's main
|
|
|
|
|
* lock. Here, it is safe for everyone if we just use regmap internal lock
|
|
|
|
|
* on the device when reading.
|
|
|
|
|
*/
|
|
|
|
|
static int _isl12057_rtc_read_time(struct device *dev, struct rtc_time *tm)
|
2013-12-20 06:27:28 +08:00
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *data = dev_get_drvdata(dev);
|
|
|
|
|
u8 regs[ISL12057_RTC_SEC_LEN];
|
2014-12-11 07:54:08 +08:00
|
|
|
unsigned int sr;
|
2013-12-20 06:27:28 +08:00
|
|
|
int ret;
|
|
|
|
|
|
2014-12-11 07:54:08 +08:00
|
|
|
ret = regmap_read(data->regmap, ISL12057_REG_SR, &sr);
|
|
|
|
|
if (ret) {
|
2014-12-11 07:54:11 +08:00
|
|
|
dev_err(dev, "%s: unable to read oscillator status flag (%d)\n",
|
|
|
|
|
__func__, ret);
|
2014-12-11 07:54:08 +08:00
|
|
|
goto out;
|
|
|
|
|
} else {
|
|
|
|
|
if (sr & ISL12057_REG_SR_OSF) {
|
|
|
|
|
ret = -ENODATA;
|
|
|
|
|
goto out;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2013-12-20 06:27:28 +08:00
|
|
|
ret = regmap_bulk_read(data->regmap, ISL12057_REG_RTC_SC, regs,
|
|
|
|
|
ISL12057_RTC_SEC_LEN);
|
2014-12-11 07:54:08 +08:00
|
|
|
if (ret)
|
2014-12-11 07:54:11 +08:00
|
|
|
dev_err(dev, "%s: unable to read RTC time section (%d)\n",
|
|
|
|
|
__func__, ret);
|
2014-12-11 07:54:08 +08:00
|
|
|
|
|
|
|
|
out:
|
|
|
|
|
if (ret)
|
2013-12-20 06:27:28 +08:00
|
|
|
return ret;
|
|
|
|
|
|
|
|
|
|
isl12057_rtc_regs_to_tm(tm, regs);
|
|
|
|
|
|
|
|
|
|
return rtc_valid_tm(tm);
|
|
|
|
|
}
|
|
|
|
|
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
static int isl12057_rtc_update_alarm(struct device *dev, int enable)
|
|
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *data = dev_get_drvdata(dev);
|
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
|
|
mutex_lock(&data->lock);
|
|
|
|
|
ret = _isl12057_rtc_update_alarm(dev, enable);
|
|
|
|
|
mutex_unlock(&data->lock);
|
|
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int isl12057_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
|
|
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *data = dev_get_drvdata(dev);
|
|
|
|
|
struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
|
|
|
|
|
unsigned long rtc_secs, alarm_secs;
|
|
|
|
|
u8 regs[ISL12057_A1_SEC_LEN];
|
|
|
|
|
unsigned int ir;
|
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
|
|
mutex_lock(&data->lock);
|
|
|
|
|
ret = regmap_bulk_read(data->regmap, ISL12057_REG_A1_SC, regs,
|
|
|
|
|
ISL12057_A1_SEC_LEN);
|
|
|
|
|
if (ret) {
|
|
|
|
|
dev_err(dev, "%s: reading alarm section failed (%d)\n",
|
|
|
|
|
__func__, ret);
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
alarm_tm->tm_sec = bcd2bin(regs[0] & 0x7f);
|
|
|
|
|
alarm_tm->tm_min = bcd2bin(regs[1] & 0x7f);
|
|
|
|
|
alarm_tm->tm_hour = bcd2bin(regs[2] & 0x3f);
|
|
|
|
|
alarm_tm->tm_mday = bcd2bin(regs[3] & 0x3f);
|
|
|
|
|
alarm_tm->tm_wday = -1;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* The alarm section does not store year/month. We use the ones in rtc
|
|
|
|
|
* section as a basis and increment month and then year if needed to get
|
|
|
|
|
* alarm after current time.
|
|
|
|
|
*/
|
|
|
|
|
ret = _isl12057_rtc_read_time(dev, &rtc_tm);
|
|
|
|
|
if (ret)
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
|
|
|
|
|
alarm_tm->tm_year = rtc_tm.tm_year;
|
|
|
|
|
alarm_tm->tm_mon = rtc_tm.tm_mon;
|
|
|
|
|
|
|
|
|
|
ret = rtc_tm_to_time(&rtc_tm, &rtc_secs);
|
|
|
|
|
if (ret)
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
|
|
|
|
|
ret = rtc_tm_to_time(alarm_tm, &alarm_secs);
|
|
|
|
|
if (ret)
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
|
|
|
|
|
if (alarm_secs < rtc_secs) {
|
|
|
|
|
if (alarm_tm->tm_mon == 11) {
|
|
|
|
|
alarm_tm->tm_mon = 0;
|
|
|
|
|
alarm_tm->tm_year += 1;
|
|
|
|
|
} else {
|
|
|
|
|
alarm_tm->tm_mon += 1;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ret = regmap_read(data->regmap, ISL12057_REG_INT, &ir);
|
|
|
|
|
if (ret) {
|
|
|
|
|
dev_err(dev, "%s: reading alarm interrupt flag failed (%d)\n",
|
|
|
|
|
__func__, ret);
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
alarm->enabled = !!(ir & ISL12057_REG_INT_A1IE);
|
|
|
|
|
|
|
|
|
|
err_unlock:
|
|
|
|
|
mutex_unlock(&data->lock);
|
|
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int isl12057_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
|
|
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *data = dev_get_drvdata(dev);
|
|
|
|
|
struct rtc_time *alarm_tm = &alarm->time;
|
|
|
|
|
unsigned long rtc_secs, alarm_secs;
|
|
|
|
|
u8 regs[ISL12057_A1_SEC_LEN];
|
|
|
|
|
struct rtc_time rtc_tm;
|
|
|
|
|
int ret, enable = 1;
|
|
|
|
|
|
|
|
|
|
mutex_lock(&data->lock);
|
|
|
|
|
ret = _isl12057_rtc_read_time(dev, &rtc_tm);
|
|
|
|
|
if (ret)
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
|
|
|
|
|
ret = rtc_tm_to_time(&rtc_tm, &rtc_secs);
|
|
|
|
|
if (ret)
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
|
|
|
|
|
ret = rtc_tm_to_time(alarm_tm, &alarm_secs);
|
|
|
|
|
if (ret)
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
|
|
|
|
|
/* If alarm time is before current time, disable the alarm */
|
|
|
|
|
if (!alarm->enabled || alarm_secs <= rtc_secs) {
|
|
|
|
|
enable = 0;
|
|
|
|
|
} else {
|
|
|
|
|
/*
|
|
|
|
|
* Chip only support alarms up to one month in the future. Let's
|
|
|
|
|
* return an error if we get something after that limit.
|
|
|
|
|
* Comparison is done by incrementing rtc_tm month field by one
|
|
|
|
|
* and checking alarm value is still below.
|
|
|
|
|
*/
|
|
|
|
|
if (rtc_tm.tm_mon == 11) { /* handle year wrapping */
|
|
|
|
|
rtc_tm.tm_mon = 0;
|
|
|
|
|
rtc_tm.tm_year += 1;
|
|
|
|
|
} else {
|
|
|
|
|
rtc_tm.tm_mon += 1;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ret = rtc_tm_to_time(&rtc_tm, &rtc_secs);
|
|
|
|
|
if (ret)
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
|
|
|
|
|
if (alarm_secs > rtc_secs) {
|
|
|
|
|
dev_err(dev, "%s: max for alarm is one month (%d)\n",
|
|
|
|
|
__func__, ret);
|
|
|
|
|
ret = -EINVAL;
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Disable the alarm before modifying it */
|
|
|
|
|
ret = _isl12057_rtc_update_alarm(dev, 0);
|
|
|
|
|
if (ret < 0) {
|
|
|
|
|
dev_err(dev, "%s: unable to disable the alarm (%d)\n",
|
|
|
|
|
__func__, ret);
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Program alarm registers */
|
|
|
|
|
regs[0] = bin2bcd(alarm_tm->tm_sec) & 0x7f;
|
|
|
|
|
regs[1] = bin2bcd(alarm_tm->tm_min) & 0x7f;
|
|
|
|
|
regs[2] = bin2bcd(alarm_tm->tm_hour) & 0x3f;
|
|
|
|
|
regs[3] = bin2bcd(alarm_tm->tm_mday) & 0x3f;
|
|
|
|
|
|
|
|
|
|
ret = regmap_bulk_write(data->regmap, ISL12057_REG_A1_SC, regs,
|
|
|
|
|
ISL12057_A1_SEC_LEN);
|
|
|
|
|
if (ret < 0) {
|
|
|
|
|
dev_err(dev, "%s: writing alarm section failed (%d)\n",
|
|
|
|
|
__func__, ret);
|
|
|
|
|
goto err_unlock;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Enable or disable alarm */
|
|
|
|
|
ret = _isl12057_rtc_update_alarm(dev, enable);
|
|
|
|
|
|
|
|
|
|
err_unlock:
|
|
|
|
|
mutex_unlock(&data->lock);
|
|
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
2013-12-20 06:27:28 +08:00
|
|
|
static int isl12057_rtc_set_time(struct device *dev, struct rtc_time *tm)
|
|
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *data = dev_get_drvdata(dev);
|
|
|
|
|
u8 regs[ISL12057_RTC_SEC_LEN];
|
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
|
|
ret = isl12057_rtc_tm_to_regs(regs, tm);
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
|
|
mutex_lock(&data->lock);
|
|
|
|
|
ret = regmap_bulk_write(data->regmap, ISL12057_REG_RTC_SC, regs,
|
|
|
|
|
ISL12057_RTC_SEC_LEN);
|
2014-12-11 07:54:08 +08:00
|
|
|
if (ret) {
|
2014-12-11 07:54:11 +08:00
|
|
|
dev_err(dev, "%s: unable to write RTC time section (%d)\n",
|
|
|
|
|
__func__, ret);
|
2014-12-11 07:54:08 +08:00
|
|
|
goto out;
|
|
|
|
|
}
|
2013-12-20 06:27:28 +08:00
|
|
|
|
2014-12-11 07:54:08 +08:00
|
|
|
/*
|
|
|
|
|
* Now that RTC time has been updated, let's clear oscillator
|
|
|
|
|
* failure flag, if needed.
|
|
|
|
|
*/
|
|
|
|
|
ret = regmap_update_bits(data->regmap, ISL12057_REG_SR,
|
|
|
|
|
ISL12057_REG_SR_OSF, 0);
|
|
|
|
|
if (ret < 0)
|
2014-12-11 07:54:11 +08:00
|
|
|
dev_err(dev, "%s: unable to clear osc. failure bit (%d)\n",
|
|
|
|
|
__func__, ret);
|
2014-12-11 07:54:08 +08:00
|
|
|
|
|
|
|
|
out:
|
|
|
|
|
mutex_unlock(&data->lock);
|
2013-12-20 06:27:28 +08:00
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Check current RTC status and enable/disable what needs to be. Return 0 if
|
|
|
|
|
* everything went ok and a negative value upon error. Note: this function
|
|
|
|
|
* is called early during init and hence does need mutex protection.
|
|
|
|
|
*/
|
|
|
|
|
static int isl12057_check_rtc_status(struct device *dev, struct regmap *regmap)
|
|
|
|
|
{
|
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
|
|
/* Enable oscillator if not already running */
|
|
|
|
|
ret = regmap_update_bits(regmap, ISL12057_REG_INT,
|
|
|
|
|
ISL12057_REG_INT_EOSC, 0);
|
|
|
|
|
if (ret < 0) {
|
2014-12-11 07:54:11 +08:00
|
|
|
dev_err(dev, "%s: unable to enable oscillator (%d)\n",
|
|
|
|
|
__func__, ret);
|
2013-12-20 06:27:28 +08:00
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Clear alarm bit if needed */
|
|
|
|
|
ret = regmap_update_bits(regmap, ISL12057_REG_SR,
|
|
|
|
|
ISL12057_REG_SR_A1F, 0);
|
|
|
|
|
if (ret < 0) {
|
2014-12-11 07:54:11 +08:00
|
|
|
dev_err(dev, "%s: unable to clear alarm bit (%d)\n",
|
|
|
|
|
__func__, ret);
|
2013-12-20 06:27:28 +08:00
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
rtc: rtc-isl12057: add isil,irq2-can-wakeup-machine property for in-tree users
Current in-tree users of ISL12057 RTC chip (NETGEAR ReadyNAS 102, 104 and
2120) do not have the IRQ#2 pin of the chip (associated w/ the Alarm1
mechanism) connected to their SoC, but to a PMIC (TPS65251 FWIW). This
specific hardware configuration allows the NAS to wake up when the alarms
rings.
Recently introduced alarm support for ISL12057 relies on the provision of
an "interrupts" property in system .dts file, which previous three users
will never get. For that reason, alarm support on those devices is not
function. To support this use case, this patch adds a new DT property for
ISL12057 (isil,irq2-can-wakeup-machine) to indicate that the chip is
capable of waking up the device using its IRQ#2 pin (even though it does
not have its IRQ#2 pin connected directly to the SoC).
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang w/:
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
As a side note, the ISL12057 remains in the list of trivial devices,
because the property is not per se required by the device to work but can
help handle system w/ specific requirements. In exchange, the new feature
is described in details in a specific documentation file.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Darshana Padmadas <darshanapadmadas@gmail.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Landley <rob@landley.net>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Kumar Gala <galak@codeaurora.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:35 +08:00
|
|
|
#ifdef CONFIG_OF
|
|
|
|
|
/*
|
|
|
|
|
* One would expect the device to be marked as a wakeup source only
|
|
|
|
|
* when an IRQ pin of the RTC is routed to an interrupt line of the
|
|
|
|
|
* CPU. In practice, such an IRQ pin can be connected to a PMIC and
|
|
|
|
|
* this allows the device to be powered up when RTC alarm rings. This
|
|
|
|
|
* is for instance the case on ReadyNAS 102, 104 and 2120. On those
|
|
|
|
|
* devices with no IRQ driectly connected to the SoC, the RTC chip
|
|
|
|
|
* can be forced as a wakeup source by stating that explicitly in
|
|
|
|
|
* the device's .dts file using the "isil,irq2-can-wakeup-machine"
|
|
|
|
|
* boolean property. This will guarantee 'wakealarm' sysfs entry is
|
|
|
|
|
* available on the device.
|
|
|
|
|
*
|
|
|
|
|
* The function below returns 1, i.e. the capability of the chip to
|
|
|
|
|
* wakeup the device, based on IRQ availability or if the boolean
|
|
|
|
|
* property has been set in the .dts file. Otherwise, it returns 0.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
static bool isl12057_can_wakeup_machine(struct device *dev)
|
|
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *data = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
|
|
return (data->irq || of_property_read_bool(dev->of_node,
|
|
|
|
|
"isil,irq2-can-wakeup-machine"));
|
|
|
|
|
}
|
|
|
|
|
#else
|
|
|
|
|
static bool isl12057_can_wakeup_machine(struct device *dev)
|
|
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *data = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
|
|
return !!data->irq;
|
|
|
|
|
}
|
|
|
|
|
#endif
|
|
|
|
|
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
static int isl12057_rtc_alarm_irq_enable(struct device *dev,
|
|
|
|
|
unsigned int enable)
|
|
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *rtc_data = dev_get_drvdata(dev);
|
|
|
|
|
int ret = -ENOTTY;
|
|
|
|
|
|
|
|
|
|
if (rtc_data->irq)
|
|
|
|
|
ret = isl12057_rtc_update_alarm(dev, enable);
|
|
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static irqreturn_t isl12057_rtc_interrupt(int irq, void *data)
|
|
|
|
|
{
|
|
|
|
|
struct i2c_client *client = data;
|
|
|
|
|
struct isl12057_rtc_data *rtc_data = dev_get_drvdata(&client->dev);
|
|
|
|
|
struct rtc_device *rtc = rtc_data->rtc;
|
|
|
|
|
int ret, handled = IRQ_NONE;
|
|
|
|
|
unsigned int sr;
|
|
|
|
|
|
|
|
|
|
ret = regmap_read(rtc_data->regmap, ISL12057_REG_SR, &sr);
|
|
|
|
|
if (!ret && (sr & ISL12057_REG_SR_A1F)) {
|
|
|
|
|
dev_dbg(&client->dev, "RTC alarm!\n");
|
|
|
|
|
|
|
|
|
|
rtc_update_irq(rtc, 1, RTC_IRQF | RTC_AF);
|
|
|
|
|
|
|
|
|
|
/* Acknowledge and disable the alarm */
|
|
|
|
|
_isl12057_rtc_clear_alarm(&client->dev);
|
|
|
|
|
_isl12057_rtc_update_alarm(&client->dev, 0);
|
|
|
|
|
|
|
|
|
|
handled = IRQ_HANDLED;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return handled;
|
|
|
|
|
}
|
|
|
|
|
|
2013-12-20 06:27:28 +08:00
|
|
|
static const struct rtc_class_ops rtc_ops = {
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
.read_time = _isl12057_rtc_read_time,
|
2013-12-20 06:27:28 +08:00
|
|
|
.set_time = isl12057_rtc_set_time,
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
.read_alarm = isl12057_rtc_read_alarm,
|
|
|
|
|
.set_alarm = isl12057_rtc_set_alarm,
|
|
|
|
|
.alarm_irq_enable = isl12057_rtc_alarm_irq_enable,
|
2013-12-20 06:27:28 +08:00
|
|
|
};
|
|
|
|
|
|
2015-02-14 06:40:51 +08:00
|
|
|
static const struct regmap_config isl12057_rtc_regmap_config = {
|
2013-12-20 06:27:28 +08:00
|
|
|
.reg_bits = 8,
|
|
|
|
|
.val_bits = 8,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static int isl12057_probe(struct i2c_client *client,
|
|
|
|
|
const struct i2c_device_id *id)
|
|
|
|
|
{
|
|
|
|
|
struct device *dev = &client->dev;
|
|
|
|
|
struct isl12057_rtc_data *data;
|
|
|
|
|
struct regmap *regmap;
|
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
|
|
if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C |
|
|
|
|
|
I2C_FUNC_SMBUS_BYTE_DATA |
|
|
|
|
|
I2C_FUNC_SMBUS_I2C_BLOCK))
|
|
|
|
|
return -ENODEV;
|
|
|
|
|
|
|
|
|
|
regmap = devm_regmap_init_i2c(client, &isl12057_rtc_regmap_config);
|
|
|
|
|
if (IS_ERR(regmap)) {
|
|
|
|
|
ret = PTR_ERR(regmap);
|
2014-12-11 07:54:11 +08:00
|
|
|
dev_err(dev, "%s: regmap allocation failed (%d)\n",
|
|
|
|
|
__func__, ret);
|
2013-12-20 06:27:28 +08:00
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ret = isl12057_i2c_validate_chip(regmap);
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
|
|
ret = isl12057_check_rtc_status(dev, regmap);
|
|
|
|
|
if (ret)
|
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
|
|
data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
|
|
|
|
|
if (!data)
|
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
|
|
mutex_init(&data->lock);
|
|
|
|
|
data->regmap = regmap;
|
|
|
|
|
dev_set_drvdata(dev, data);
|
|
|
|
|
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
if (client->irq > 0) {
|
|
|
|
|
ret = devm_request_threaded_irq(dev, client->irq, NULL,
|
|
|
|
|
isl12057_rtc_interrupt,
|
|
|
|
|
IRQF_SHARED|IRQF_ONESHOT,
|
|
|
|
|
DRV_NAME, client);
|
|
|
|
|
if (!ret)
|
|
|
|
|
data->irq = client->irq;
|
|
|
|
|
else
|
|
|
|
|
dev_err(dev, "%s: irq %d unavailable (%d)\n", __func__,
|
|
|
|
|
client->irq, ret);
|
|
|
|
|
}
|
|
|
|
|
|
rtc: rtc-isl12057: add isil,irq2-can-wakeup-machine property for in-tree users
Current in-tree users of ISL12057 RTC chip (NETGEAR ReadyNAS 102, 104 and
2120) do not have the IRQ#2 pin of the chip (associated w/ the Alarm1
mechanism) connected to their SoC, but to a PMIC (TPS65251 FWIW). This
specific hardware configuration allows the NAS to wake up when the alarms
rings.
Recently introduced alarm support for ISL12057 relies on the provision of
an "interrupts" property in system .dts file, which previous three users
will never get. For that reason, alarm support on those devices is not
function. To support this use case, this patch adds a new DT property for
ISL12057 (isil,irq2-can-wakeup-machine) to indicate that the chip is
capable of waking up the device using its IRQ#2 pin (even though it does
not have its IRQ#2 pin connected directly to the SoC).
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang w/:
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
As a side note, the ISL12057 remains in the list of trivial devices,
because the property is not per se required by the device to work but can
help handle system w/ specific requirements. In exchange, the new feature
is described in details in a specific documentation file.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Darshana Padmadas <darshanapadmadas@gmail.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Landley <rob@landley.net>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Kumar Gala <galak@codeaurora.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:35 +08:00
|
|
|
if (isl12057_can_wakeup_machine(dev))
|
|
|
|
|
device_init_wakeup(dev, true);
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
|
|
|
|
|
data->rtc = devm_rtc_device_register(dev, DRV_NAME, &rtc_ops,
|
|
|
|
|
THIS_MODULE);
|
|
|
|
|
ret = PTR_ERR_OR_ZERO(data->rtc);
|
|
|
|
|
if (ret) {
|
|
|
|
|
dev_err(dev, "%s: unable to register RTC device (%d)\n",
|
|
|
|
|
__func__, ret);
|
|
|
|
|
goto err;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* We cannot support UIE mode if we do not have an IRQ line */
|
|
|
|
|
if (!data->irq)
|
|
|
|
|
data->rtc->uie_unsupported = 1;
|
|
|
|
|
|
|
|
|
|
err:
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int isl12057_remove(struct i2c_client *client)
|
|
|
|
|
{
|
rtc: rtc-isl12057: add isil,irq2-can-wakeup-machine property for in-tree users
Current in-tree users of ISL12057 RTC chip (NETGEAR ReadyNAS 102, 104 and
2120) do not have the IRQ#2 pin of the chip (associated w/ the Alarm1
mechanism) connected to their SoC, but to a PMIC (TPS65251 FWIW). This
specific hardware configuration allows the NAS to wake up when the alarms
rings.
Recently introduced alarm support for ISL12057 relies on the provision of
an "interrupts" property in system .dts file, which previous three users
will never get. For that reason, alarm support on those devices is not
function. To support this use case, this patch adds a new DT property for
ISL12057 (isil,irq2-can-wakeup-machine) to indicate that the chip is
capable of waking up the device using its IRQ#2 pin (even though it does
not have its IRQ#2 pin connected directly to the SoC).
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang w/:
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
As a side note, the ISL12057 remains in the list of trivial devices,
because the property is not per se required by the device to work but can
help handle system w/ specific requirements. In exchange, the new feature
is described in details in a specific documentation file.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Darshana Padmadas <darshanapadmadas@gmail.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Landley <rob@landley.net>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Kumar Gala <galak@codeaurora.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:35 +08:00
|
|
|
if (isl12057_can_wakeup_machine(&client->dev))
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
device_init_wakeup(&client->dev, false);
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#ifdef CONFIG_PM_SLEEP
|
|
|
|
|
static int isl12057_rtc_suspend(struct device *dev)
|
|
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *rtc_data = dev_get_drvdata(dev);
|
|
|
|
|
|
rtc: rtc-isl12057: add isil,irq2-can-wakeup-machine property for in-tree users
Current in-tree users of ISL12057 RTC chip (NETGEAR ReadyNAS 102, 104 and
2120) do not have the IRQ#2 pin of the chip (associated w/ the Alarm1
mechanism) connected to their SoC, but to a PMIC (TPS65251 FWIW). This
specific hardware configuration allows the NAS to wake up when the alarms
rings.
Recently introduced alarm support for ISL12057 relies on the provision of
an "interrupts" property in system .dts file, which previous three users
will never get. For that reason, alarm support on those devices is not
function. To support this use case, this patch adds a new DT property for
ISL12057 (isil,irq2-can-wakeup-machine) to indicate that the chip is
capable of waking up the device using its IRQ#2 pin (even though it does
not have its IRQ#2 pin connected directly to the SoC).
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang w/:
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
As a side note, the ISL12057 remains in the list of trivial devices,
because the property is not per se required by the device to work but can
help handle system w/ specific requirements. In exchange, the new feature
is described in details in a specific documentation file.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Darshana Padmadas <darshanapadmadas@gmail.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Landley <rob@landley.net>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Kumar Gala <galak@codeaurora.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:35 +08:00
|
|
|
if (rtc_data->irq && device_may_wakeup(dev))
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
return enable_irq_wake(rtc_data->irq);
|
|
|
|
|
|
|
|
|
|
return 0;
|
2013-12-20 06:27:28 +08:00
|
|
|
}
|
|
|
|
|
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
static int isl12057_rtc_resume(struct device *dev)
|
|
|
|
|
{
|
|
|
|
|
struct isl12057_rtc_data *rtc_data = dev_get_drvdata(dev);
|
|
|
|
|
|
rtc: rtc-isl12057: add isil,irq2-can-wakeup-machine property for in-tree users
Current in-tree users of ISL12057 RTC chip (NETGEAR ReadyNAS 102, 104 and
2120) do not have the IRQ#2 pin of the chip (associated w/ the Alarm1
mechanism) connected to their SoC, but to a PMIC (TPS65251 FWIW). This
specific hardware configuration allows the NAS to wake up when the alarms
rings.
Recently introduced alarm support for ISL12057 relies on the provision of
an "interrupts" property in system .dts file, which previous three users
will never get. For that reason, alarm support on those devices is not
function. To support this use case, this patch adds a new DT property for
ISL12057 (isil,irq2-can-wakeup-machine) to indicate that the chip is
capable of waking up the device using its IRQ#2 pin (even though it does
not have its IRQ#2 pin connected directly to the SoC).
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang w/:
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
As a side note, the ISL12057 remains in the list of trivial devices,
because the property is not per se required by the device to work but can
help handle system w/ specific requirements. In exchange, the new feature
is described in details in a specific documentation file.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Darshana Padmadas <darshanapadmadas@gmail.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Landley <rob@landley.net>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Kumar Gala <galak@codeaurora.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:35 +08:00
|
|
|
if (rtc_data->irq && device_may_wakeup(dev))
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
return disable_irq_wake(rtc_data->irq);
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
static SIMPLE_DEV_PM_OPS(isl12057_rtc_pm_ops, isl12057_rtc_suspend,
|
|
|
|
|
isl12057_rtc_resume);
|
|
|
|
|
|
2013-12-20 06:27:28 +08:00
|
|
|
#ifdef CONFIG_OF
|
2014-06-07 05:35:56 +08:00
|
|
|
static const struct of_device_id isl12057_dt_match[] = {
|
2015-02-17 07:58:35 +08:00
|
|
|
{ .compatible = "isl,isl12057" }, /* for backward compat., don't use */
|
|
|
|
|
{ .compatible = "isil,isl12057" },
|
2013-12-20 06:27:28 +08:00
|
|
|
{ },
|
|
|
|
|
};
|
2015-07-31 00:18:46 +08:00
|
|
|
MODULE_DEVICE_TABLE(of, isl12057_dt_match);
|
2013-12-20 06:27:28 +08:00
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
static const struct i2c_device_id isl12057_id[] = {
|
|
|
|
|
{ "isl12057", 0 },
|
|
|
|
|
{ }
|
|
|
|
|
};
|
|
|
|
|
MODULE_DEVICE_TABLE(i2c, isl12057_id);
|
|
|
|
|
|
|
|
|
|
static struct i2c_driver isl12057_driver = {
|
|
|
|
|
.driver = {
|
|
|
|
|
.name = DRV_NAME,
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
.pm = &isl12057_rtc_pm_ops,
|
2013-12-20 06:27:28 +08:00
|
|
|
.of_match_table = of_match_ptr(isl12057_dt_match),
|
|
|
|
|
},
|
|
|
|
|
.probe = isl12057_probe,
|
drivers/rtc/rtc-isl12057.c: add alarm support to Intersil ISL12057 RTC driver
This patch adds alarm support to Intersil ISL12057 driver. This allows to
configure the chip to generate an interrupt when the alarm matches current
time value. Alarm can be programmed up to one month in the future and is
accurate to the second.
The patch was developed to support two different configurations: systems
w/ and w/o RTC chip IRQ line connected to the main CPU.
The latter is the one found on current 3 kernel users of the chip for
which support was initially developed (Netgear ReadyNAS 102, 104 and 2120
NAS). On those devices, the IRQ#2 pin of the chip is not connected to the
SoC but to a PMIC. This allows setting an alarm, powering off the device
and have it wake up when the alarm rings. To support that configuration
the driver does the following:
1. it has alarm_irq_enable() function returns -ENOTTY when no IRQ
is passed to the driver.
2. it marks the device as a wakeup source in all cases (whether an
IRQ is passed to the driver or not) to have 'wakealarm' sysfs
entry created.
3. it marks the device has not supporting UIE mode when no IRQ is
passed to the driver (see the commmit message of c9f5c7e7a84f)
This specific configuration was tested on a ReadyNAS 102 by setting an
alarm, powering off the device and see it reboot as expected when the
alarm rang.
The former configuration was tested on a Netgear ReadyNAS 102 after some
soldering of the IRQ#2 pin of the RTC chip to a MPP line of the SoC (the
one used usually handles the reset button). The test was performed using
a modified .dts file reflecting this change (see below) and rtc-test.c
program available in Documentation/rtc.txt. This test program ran as
expected, which validates alarm supports, including interrupt support.
As a side note, the ISL12057 remains in the list of trivial devices, i.e.
no specific DT binding being added by this patch: i2c core automatically
handles extraction of IRQ line info from .dts file. For instance, if one
wants to reference the interrupt line for the alarm in its .dts file,
adding interrupt and interrupt-parent properties works as expected:
isl12057: isl12057@68 {
compatible =3D "isil,isl12057";
interrupt-parent =3D <&gpio0>;
interrupts =3D <6 IRQ_TYPE_EDGE_FALLING>;
reg =3D <0x68>;
};
FWIW, if someone is looking for a way to test alarm support on a system on
which the chip IRQ line has the ability to boot the system (e.g. ReadyNAS
102, 104, etc):
# echo 0 > /sys/class/rtc/rtc0/wakealarm
# echo `date '+%s' -d '+ 1 minutes'` > /sys/class/rtc/rtc0/wakealarm
# shutdown -h now
With the commands above, after a minute, the system comes back to life.
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Peter Huewe <peter.huewe@infineon.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-02-14 06:40:32 +08:00
|
|
|
.remove = isl12057_remove,
|
2013-12-20 06:27:28 +08:00
|
|
|
.id_table = isl12057_id,
|
|
|
|
|
};
|
|
|
|
|
module_i2c_driver(isl12057_driver);
|
|
|
|
|
|
|
|
|
|
MODULE_AUTHOR("Arnaud EBALARD <arno@natisbad.org>");
|
|
|
|
|
MODULE_DESCRIPTION("Intersil ISL12057 RTC driver");
|
|
|
|
|
MODULE_LICENSE("GPL");
|