2017-02-08 01:51:13 +08:00
|
|
|
.. _todo:
|
|
|
|
|
|
|
|
=========
|
|
|
|
TODO list
|
|
|
|
=========
|
|
|
|
|
|
|
|
This section contains a list of smaller janitorial tasks in the kernel DRM
|
|
|
|
graphics subsystem useful as newbie projects. Or for slow rainy days.
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Difficulty
|
|
|
|
----------
|
|
|
|
|
|
|
|
To make it easier task are categorized into different levels:
|
|
|
|
|
|
|
|
Starter: Good tasks to get started with the DRM subsystem.
|
|
|
|
|
|
|
|
Intermediate: Tasks which need some experience with working in the DRM
|
|
|
|
subsystem, or some specific GPU/display graphics knowledge. For debugging issue
|
|
|
|
it's good to have the relevant hardware (or a virtual driver set up) available
|
|
|
|
for testing.
|
|
|
|
|
|
|
|
Advanced: Tricky tasks that need fairly good understanding of the DRM subsystem
|
|
|
|
and graphics topics. Generally need the relevant hardware for development and
|
|
|
|
testing.
|
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
Subsystem-wide refactorings
|
|
|
|
===========================
|
|
|
|
|
2018-11-27 17:19:21 +08:00
|
|
|
Remove custom dumb_map_offset implementations
|
|
|
|
---------------------------------------------
|
|
|
|
|
|
|
|
All GEM based drivers should be using drm_gem_create_mmap_offset() instead.
|
|
|
|
Audit each individual driver, make sure it'll work with the generic
|
|
|
|
implementation (there's lots of outdated locking leftovers in various
|
|
|
|
implementations), and then remove it.
|
|
|
|
|
|
|
|
Contact: Daniel Vetter, respective driver maintainers
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate
|
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
Convert existing KMS drivers to atomic modesetting
|
|
|
|
--------------------------------------------------
|
|
|
|
|
|
|
|
3.19 has the atomic modeset interfaces and helpers, so drivers can now be
|
|
|
|
converted over. Modern compositors like Wayland or Surfaceflinger on Android
|
|
|
|
really want an atomic modeset interface, so this is all about the bright
|
|
|
|
future.
|
|
|
|
|
|
|
|
There is a conversion guide for atomic and all you need is a GPU for a
|
|
|
|
non-converted driver (again virtual HW drivers for KVM are still all
|
|
|
|
suitable).
|
|
|
|
|
|
|
|
As part of this drivers also need to convert to universal plane (which means
|
|
|
|
exposing primary & cursor as proper plane objects). But that's much easier to
|
|
|
|
do by directly using the new atomic helper driver callbacks.
|
|
|
|
|
|
|
|
Contact: Daniel Vetter, respective driver maintainers
|
2017-02-27 03:38:50 +08:00
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Advanced
|
|
|
|
|
2017-02-27 03:38:50 +08:00
|
|
|
Clean up the clipped coordination confusion around planes
|
|
|
|
---------------------------------------------------------
|
|
|
|
|
|
|
|
We have a helper to get this right with drm_plane_helper_check_update(), but
|
|
|
|
it's not consistently used. This should be fixed, preferrably in the atomic
|
|
|
|
helpers (and drivers then moved over to clipped coordinates). Probably the
|
|
|
|
helper should also be moved from drm_plane_helper.c to the atomic helpers, to
|
|
|
|
avoid confusion - the other helpers in that file are all deprecated legacy
|
|
|
|
helpers.
|
|
|
|
|
|
|
|
Contact: Ville Syrjälä, Daniel Vetter, driver maintainers
|
2017-02-27 03:38:51 +08:00
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Advanced
|
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
Convert early atomic drivers to async commit helpers
|
|
|
|
----------------------------------------------------
|
|
|
|
|
|
|
|
For the first year the atomic modeset helpers didn't support asynchronous /
|
|
|
|
nonblocking commits, and every driver had to hand-roll them. This is fixed
|
|
|
|
now, but there's still a pile of existing drivers that easily could be
|
|
|
|
converted over to the new infrastructure.
|
|
|
|
|
|
|
|
One issue with the helpers is that they require that drivers handle completion
|
|
|
|
events for atomic commits correctly. But fixing these bugs is good anyway.
|
|
|
|
|
|
|
|
Contact: Daniel Vetter, respective driver maintainers
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Advanced
|
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
Fallout from atomic KMS
|
|
|
|
-----------------------
|
|
|
|
|
|
|
|
``drm_atomic_helper.c`` provides a batch of functions which implement legacy
|
|
|
|
IOCTLs on top of the new atomic driver interface. Which is really nice for
|
|
|
|
gradual conversion of drivers, but unfortunately the semantic mismatches are
|
|
|
|
a bit too severe. So there's some follow-up work to adjust the function
|
|
|
|
interfaces to fix these issues:
|
|
|
|
|
|
|
|
* atomic needs the lock acquire context. At the moment that's passed around
|
|
|
|
implicitly with some horrible hacks, and it's also allocate with
|
|
|
|
``GFP_NOFAIL`` behind the scenes. All legacy paths need to start allocating
|
|
|
|
the acquire context explicitly on stack and then also pass it down into
|
|
|
|
drivers explicitly so that the legacy-on-atomic functions can use them.
|
|
|
|
|
2018-09-06 02:15:09 +08:00
|
|
|
Except for some driver code this is done. This task should be finished by
|
|
|
|
adding WARN_ON(!drm_drv_uses_atomic_modeset) in drm_modeset_lock_all().
|
2017-09-11 14:51:51 +08:00
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
* A bunch of the vtable hooks are now in the wrong place: DRM has a split
|
|
|
|
between core vfunc tables (named ``drm_foo_funcs``), which are used to
|
|
|
|
implement the userspace ABI. And then there's the optional hooks for the
|
|
|
|
helper libraries (name ``drm_foo_helper_funcs``), which are purely for
|
|
|
|
internal use. Some of these hooks should be move from ``_funcs`` to
|
|
|
|
``_helper_funcs`` since they are not part of the core ABI. There's a
|
|
|
|
``FIXME`` comment in the kerneldoc for each such case in ``drm_crtc.h``.
|
|
|
|
|
|
|
|
Contact: Daniel Vetter
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate
|
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
Get rid of dev->struct_mutex from GEM drivers
|
|
|
|
---------------------------------------------
|
|
|
|
|
|
|
|
``dev->struct_mutex`` is the Big DRM Lock from legacy days and infested
|
|
|
|
everything. Nowadays in modern drivers the only bit where it's mandatory is
|
|
|
|
serializing GEM buffer object destruction. Which unfortunately means drivers
|
|
|
|
have to keep track of that lock and either call ``unreference`` or
|
|
|
|
``unreference_locked`` depending upon context.
|
|
|
|
|
|
|
|
Core GEM doesn't have a need for ``struct_mutex`` any more since kernel 4.8,
|
|
|
|
and there's a ``gem_free_object_unlocked`` callback for any drivers which are
|
|
|
|
entirely ``struct_mutex`` free.
|
|
|
|
|
|
|
|
For drivers that need ``struct_mutex`` it should be replaced with a driver-
|
|
|
|
private lock. The tricky part is the BO free functions, since those can't
|
|
|
|
reliably take that lock any more. Instead state needs to be protected with
|
|
|
|
suitable subordinate locks or some cleanup work pushed to a worker thread. For
|
|
|
|
performance-critical drivers it might also be better to go with a more
|
2018-09-06 02:15:09 +08:00
|
|
|
fine-grained per-buffer object and per-context lockings scheme. Currently only the
|
|
|
|
``msm`` driver still use ``struct_mutex``.
|
2017-02-08 01:51:13 +08:00
|
|
|
|
2017-04-04 17:52:54 +08:00
|
|
|
Contact: Daniel Vetter, respective driver maintainers
|
2017-02-08 01:51:13 +08:00
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Advanced
|
|
|
|
|
2019-12-20 00:17:22 +08:00
|
|
|
Convert logging to drm_* functions with drm_device paramater
|
|
|
|
------------------------------------------------------------
|
2017-09-08 22:32:07 +08:00
|
|
|
|
|
|
|
For drivers which could have multiple instances, it is necessary to
|
|
|
|
differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR
|
|
|
|
don't do this, drivers used dev_info/warn/err to make this differentiation. We
|
2019-12-20 00:17:22 +08:00
|
|
|
now have drm_* variants of the drm print functions, so we can start to convert
|
|
|
|
those drivers back to using drm-formatted specific log messages.
|
2017-09-08 22:32:07 +08:00
|
|
|
|
2017-10-30 21:15:36 +08:00
|
|
|
Before you start this conversion please contact the relevant maintainers to make
|
|
|
|
sure your work will be merged - not everyone agrees that the DRM dmesg macros
|
|
|
|
are better.
|
|
|
|
|
2017-09-08 22:32:07 +08:00
|
|
|
Contact: Sean Paul, Maintainer of the driver you plan to convert
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Starter
|
|
|
|
|
2017-11-07 03:18:12 +08:00
|
|
|
Convert drivers to use simple modeset suspend/resume
|
|
|
|
----------------------------------------------------
|
|
|
|
|
|
|
|
Most drivers (except i915 and nouveau) that use
|
|
|
|
drm_atomic_helper_suspend/resume() can probably be converted to use
|
2018-09-06 02:15:09 +08:00
|
|
|
drm_mode_config_helper_suspend/resume(). Also there's still open-coded version
|
|
|
|
of the atomic suspend/resume code in older atomic modeset drivers.
|
2017-11-07 03:18:12 +08:00
|
|
|
|
|
|
|
Contact: Maintainer of the driver you plan to convert
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate
|
|
|
|
|
2019-11-06 20:47:26 +08:00
|
|
|
Convert drivers to use drm_fbdev_generic_setup()
|
|
|
|
------------------------------------------------
|
2017-12-16 01:51:15 +08:00
|
|
|
|
2019-11-06 20:47:26 +08:00
|
|
|
Most drivers can use drm_fbdev_generic_setup(). Driver have to implement
|
|
|
|
atomic modesetting and GEM vmap support. Current generic fbdev emulation
|
|
|
|
expects the framebuffer in system memory (or system-like memory).
|
2017-12-16 01:51:15 +08:00
|
|
|
|
|
|
|
Contact: Maintainer of the driver you plan to convert
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate
|
|
|
|
|
2019-11-28 02:00:35 +08:00
|
|
|
drm_framebuffer_funcs and drm_mode_config_funcs.fb_create cleanup
|
|
|
|
-----------------------------------------------------------------
|
|
|
|
|
|
|
|
A lot more drivers could be switched over to the drm_gem_framebuffer helpers.
|
|
|
|
Various hold-ups:
|
|
|
|
|
|
|
|
- Need to switch over to the generic dirty tracking code using
|
|
|
|
drm_atomic_helper_dirtyfb first (e.g. qxl).
|
|
|
|
|
|
|
|
- Need to switch to drm_fbdev_generic_setup(), otherwise a lot of the custom fb
|
|
|
|
setup code can't be deleted.
|
|
|
|
|
|
|
|
- Many drivers wrap drm_gem_fb_create() only to check for valid formats. For
|
|
|
|
atomic drivers we could check for valid formats by calling
|
|
|
|
drm_plane_check_pixel_format() against all planes, and pass if any plane
|
|
|
|
supports the format. For non-atomic that's not possible since like the format
|
|
|
|
list for the primary plane is fake and we'd therefor reject valid formats.
|
|
|
|
|
|
|
|
- Many drivers subclass drm_framebuffer, we'd need a embedding compatible
|
|
|
|
version of the varios drm_gem_fb_create functions. Maybe called
|
|
|
|
drm_gem_fb_create/_with_dirty/_with_funcs as needed.
|
|
|
|
|
|
|
|
Contact: Daniel Vetter
|
|
|
|
|
|
|
|
Level: Intermediate
|
|
|
|
|
2018-04-25 19:17:42 +08:00
|
|
|
Clean up mmap forwarding
|
|
|
|
------------------------
|
|
|
|
|
|
|
|
A lot of drivers forward gem mmap calls to dma-buf mmap for imported buffers.
|
|
|
|
And also a lot of them forward dma-buf mmap to the gem mmap implementations.
|
2019-06-15 04:36:13 +08:00
|
|
|
There's drm_gem_prime_mmap() for this now, but still needs to be rolled out.
|
2018-04-25 19:17:42 +08:00
|
|
|
|
|
|
|
Contact: Daniel Vetter
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate
|
|
|
|
|
2019-01-07 18:22:38 +08:00
|
|
|
Generic fbdev defio support
|
|
|
|
---------------------------
|
|
|
|
|
|
|
|
The defio support code in the fbdev core has some very specific requirements,
|
2019-10-25 17:27:59 +08:00
|
|
|
which means drivers need to have a special framebuffer for fbdev. The main
|
|
|
|
issue is that it uses some fields in struct page itself, which breaks shmem
|
|
|
|
gem objects (and other things). To support defio, affected drivers require
|
|
|
|
the use of a shadow buffer, which may add CPU and memory overhead.
|
2019-01-07 18:22:38 +08:00
|
|
|
|
|
|
|
Possible solution would be to write our own defio mmap code in the drm fbdev
|
|
|
|
emulation. It would need to fully wrap the existing mmap ops, forwarding
|
|
|
|
everything after it has done the write-protect/mkwrite trickery:
|
|
|
|
|
|
|
|
- In the drm_fbdev_fb_mmap helper, if we need defio, change the
|
|
|
|
default page prots to write-protected with something like this::
|
|
|
|
|
|
|
|
vma->vm_page_prot = pgprot_wrprotect(vma->vm_page_prot);
|
|
|
|
|
|
|
|
- Set the mkwrite and fsync callbacks with similar implementions to the core
|
|
|
|
fbdev defio stuff. These should all work on plain ptes, they don't actually
|
|
|
|
require a struct page. uff. These should all work on plain ptes, they don't
|
|
|
|
actually require a struct page.
|
|
|
|
|
|
|
|
- Track the dirty pages in a separate structure (bitfield with one bit per page
|
|
|
|
should work) to avoid clobbering struct page.
|
|
|
|
|
|
|
|
Might be good to also have some igt testcases for this.
|
|
|
|
|
|
|
|
Contact: Daniel Vetter, Noralf Tronnes
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Advanced
|
|
|
|
|
2018-02-19 22:57:08 +08:00
|
|
|
idr_init_base()
|
|
|
|
---------------
|
|
|
|
|
|
|
|
DRM core&drivers uses a lot of idr (integer lookup directories) for mapping
|
|
|
|
userspace IDs to internal objects, and in most places ID=0 means NULL and hence
|
|
|
|
is never used. Switching to idr_init_base() for these would make the idr more
|
|
|
|
efficient.
|
|
|
|
|
|
|
|
Contact: Daniel Vetter
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Starter
|
|
|
|
|
2018-11-10 22:56:45 +08:00
|
|
|
struct drm_gem_object_funcs
|
|
|
|
---------------------------
|
|
|
|
|
|
|
|
GEM objects can now have a function table instead of having the callbacks on the
|
|
|
|
DRM driver struct. This is now the preferred way and drivers can be moved over.
|
|
|
|
|
2019-07-02 19:50:12 +08:00
|
|
|
We also need a 2nd version of the CMA define that doesn't require the
|
2019-06-18 22:02:41 +08:00
|
|
|
vmapping to be present (different hook for prime importing). Plus this needs to
|
|
|
|
be rolled out to all drivers using their own implementations, too.
|
2019-06-15 04:35:17 +08:00
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate
|
|
|
|
|
2018-11-30 03:58:33 +08:00
|
|
|
Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate
|
|
|
|
---------------------------------------------------------
|
|
|
|
|
|
|
|
For cases where drivers are attempting to grab the modeset locks with a local
|
|
|
|
acquire context. Replace the boilerplate code surrounding
|
|
|
|
drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and
|
|
|
|
DRM_MODESET_LOCK_ALL_END() instead.
|
|
|
|
|
|
|
|
This should also be done for all places where drm_modest_lock_all() is still
|
|
|
|
used.
|
|
|
|
|
|
|
|
As a reference, take a look at the conversions already completed in drm core.
|
|
|
|
|
|
|
|
Contact: Sean Paul, respective driver maintainers
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Starter
|
|
|
|
|
2019-01-29 21:21:53 +08:00
|
|
|
Rename CMA helpers to DMA helpers
|
|
|
|
---------------------------------
|
|
|
|
|
|
|
|
CMA (standing for contiguous memory allocator) is really a bit an accident of
|
|
|
|
what these were used for first, a much better name would be DMA helpers. In the
|
|
|
|
text these should even be called coherent DMA memory helpers (so maybe CDM, but
|
|
|
|
no one knows what that means) since underneath they just use dma_alloc_coherent.
|
|
|
|
|
|
|
|
Contact: Laurent Pinchart, Daniel Vetter
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate (mostly because it is a huge tasks without good partial
|
|
|
|
milestones, not technically itself that challenging)
|
|
|
|
|
2019-01-30 03:26:29 +08:00
|
|
|
Convert direct mode.vrefresh accesses to use drm_mode_vrefresh()
|
|
|
|
----------------------------------------------------------------
|
|
|
|
|
|
|
|
drm_display_mode.vrefresh isn't guaranteed to be populated. As such, using it
|
|
|
|
is risky and has been known to cause div-by-zero bugs. Fortunately, drm core
|
|
|
|
has helper which will use mode.vrefresh if it's !0 and will calculate it from
|
|
|
|
the timings when it's 0.
|
|
|
|
|
|
|
|
Use simple search/replace, or (more fun) cocci to replace instances of direct
|
|
|
|
vrefresh access with a call to the helper. Check out
|
|
|
|
https://lists.freedesktop.org/archives/dri-devel/2019-January/205186.html for
|
|
|
|
inspiration.
|
|
|
|
|
|
|
|
Once all instances of vrefresh have been converted, remove vrefresh from
|
|
|
|
drm_display_mode to avoid future use.
|
|
|
|
|
|
|
|
Contact: Sean Paul
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Starter
|
|
|
|
|
2019-01-30 03:26:29 +08:00
|
|
|
Remove drm_display_mode.hsync
|
|
|
|
-----------------------------
|
|
|
|
|
|
|
|
We have drm_mode_hsync() to calculate this from hsync_start/end, since drivers
|
|
|
|
shouldn't/don't use this, remove this member to avoid any temptations to use it
|
|
|
|
in the future. If there is any debug code using drm_display_mode.hsync, convert
|
|
|
|
it to use drm_mode_hsync() instead.
|
|
|
|
|
|
|
|
Contact: Sean Paul
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Starter
|
|
|
|
|
2019-05-07 02:01:30 +08:00
|
|
|
drm_fb_helper tasks
|
|
|
|
-------------------
|
|
|
|
|
|
|
|
- drm_fb_helper_restore_fbdev_mode_unlocked() should call restore_fbdev_mode()
|
|
|
|
not the _force variant so it can bail out if there is a master. But first
|
|
|
|
these igt tests need to be fixed: kms_fbcon_fbt@psr and
|
|
|
|
kms_fbcon_fbt@psr-suspend.
|
|
|
|
|
2019-11-06 20:47:26 +08:00
|
|
|
- The max connector argument for drm_fb_helper_init() isn't used anymore and
|
|
|
|
can be removed.
|
2019-05-31 22:01:11 +08:00
|
|
|
|
2019-06-08 23:26:53 +08:00
|
|
|
- The helper doesn't keep an array of connectors anymore so these can be
|
|
|
|
removed: drm_fb_helper_single_add_all_connectors(),
|
|
|
|
drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector().
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate
|
|
|
|
|
2019-09-17 20:09:36 +08:00
|
|
|
connector register/unregister fixes
|
|
|
|
-----------------------------------
|
|
|
|
|
|
|
|
- For most connectors it's a no-op to call drm_connector_register/unregister
|
|
|
|
directly from driver code, drm_dev_register/unregister take care of this
|
|
|
|
already. We can remove all of them.
|
|
|
|
|
|
|
|
- For dp drivers it's a bit more a mess, since we need the connector to be
|
|
|
|
registered when calling drm_dp_aux_register. Fix this by instead calling
|
|
|
|
drm_dp_aux_init, and moving the actual registering into a late_register
|
|
|
|
callback as recommended in the kerneldoc.
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate
|
|
|
|
|
2019-10-23 22:49:53 +08:00
|
|
|
Remove load/unload callbacks from all non-DRIVER_LEGACY drivers
|
|
|
|
---------------------------------------------------------------
|
|
|
|
|
|
|
|
The load/unload callbacks in struct &drm_driver are very much midlayers, plus
|
|
|
|
for historical reasons they get the ordering wrong (and we can't fix that)
|
|
|
|
between setting up the &drm_driver structure and calling drm_dev_register().
|
|
|
|
|
|
|
|
- Rework drivers to no longer use the load/unload callbacks, directly coding the
|
|
|
|
load/unload sequence into the driver's probe function.
|
|
|
|
|
|
|
|
- Once all non-DRIVER_LEGACY drivers are converted, disallow the load/unload
|
|
|
|
callbacks for all modern drivers.
|
|
|
|
|
|
|
|
Contact: Daniel Vetter
|
|
|
|
|
|
|
|
Level: Intermediate
|
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
Core refactorings
|
|
|
|
=================
|
|
|
|
|
|
|
|
Make panic handling work
|
|
|
|
------------------------
|
|
|
|
|
|
|
|
This is a really varied tasks with lots of little bits and pieces:
|
|
|
|
|
|
|
|
* The panic path can't be tested currently, leading to constant breaking. The
|
|
|
|
main issue here is that panics can be triggered from hardirq contexts and
|
|
|
|
hence all panic related callback can run in hardirq context. It would be
|
|
|
|
awesome if we could test at least the fbdev helper code and driver code by
|
|
|
|
e.g. trigger calls through drm debugfs files. hardirq context could be
|
|
|
|
achieved by using an IPI to the local processor.
|
|
|
|
|
|
|
|
* There's a massive confusion of different panic handlers. DRM fbdev emulation
|
|
|
|
helpers have one, but on top of that the fbcon code itself also has one. We
|
|
|
|
need to make sure that they stop fighting over each another.
|
|
|
|
|
|
|
|
* ``drm_can_sleep()`` is a mess. It hides real bugs in normal operations and
|
|
|
|
isn't a full solution for panic paths. We need to make sure that it only
|
|
|
|
returns true if there's a panic going on for real, and fix up all the
|
|
|
|
fallout.
|
|
|
|
|
|
|
|
* The panic handler must never sleep, which also means it can't ever
|
|
|
|
``mutex_lock()``. Also it can't grab any other lock unconditionally, not
|
|
|
|
even spinlocks (because NMI and hardirq can panic too). We need to either
|
|
|
|
make sure to not call such paths, or trylock everything. Really tricky.
|
|
|
|
|
|
|
|
* For the above locking troubles reasons it's pretty much impossible to
|
|
|
|
attempt a synchronous modeset from panic handlers. The only thing we could
|
|
|
|
try to achive is an atomic ``set_base`` of the primary plane, and hope that
|
|
|
|
it shows up. Everything else probably needs to be delayed to some worker or
|
|
|
|
something else which happens later on. Otherwise it just kills the box
|
|
|
|
harder, prevent the panic from going out on e.g. netconsole.
|
|
|
|
|
|
|
|
* There's also proposal for a simplied DRM console instead of the full-blown
|
|
|
|
fbcon and DRM fbdev emulation. Any kind of panic handling tricks should
|
|
|
|
obviously work for both console, in case we ever get kmslog merged.
|
|
|
|
|
|
|
|
Contact: Daniel Vetter
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Advanced
|
|
|
|
|
2017-03-23 04:54:01 +08:00
|
|
|
Clean up the debugfs support
|
|
|
|
----------------------------
|
|
|
|
|
|
|
|
There's a bunch of issues with it:
|
|
|
|
|
|
|
|
- The drm_info_list ->show() function doesn't even bother to cast to the drm
|
|
|
|
structure for you. This is lazy.
|
|
|
|
|
|
|
|
- We probably want to have some support for debugfs files on crtc/connectors and
|
|
|
|
maybe other kms objects directly in core. There's even drm_print support in
|
|
|
|
the funcs for these objects to dump kms state, so it's all there. And then the
|
|
|
|
->show() functions should obviously give you a pointer to the right object.
|
|
|
|
|
|
|
|
- The drm_info_list stuff is centered on drm_minor instead of drm_device. For
|
|
|
|
anything we want to print drm_device (or maybe drm_file) is the right thing.
|
|
|
|
|
|
|
|
- The drm_driver->debugfs_init hooks we have is just an artifact of the old
|
|
|
|
midlayered load sequence. DRM debugfs should work more like sysfs, where you
|
|
|
|
can create properties/files for an object anytime you want, and the core
|
|
|
|
takes care of publishing/unpuplishing all the files at register/unregister
|
|
|
|
time. Drivers shouldn't need to worry about these technicalities, and fixing
|
|
|
|
this (together with the drm_minor->drm_device move) would allow us to remove
|
|
|
|
debugfs_init.
|
|
|
|
|
2019-06-15 04:36:14 +08:00
|
|
|
- Drop the return code and error checking from all debugfs functions. Greg KH is
|
|
|
|
working on this already.
|
|
|
|
|
2017-03-23 04:54:01 +08:00
|
|
|
Contact: Daniel Vetter
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate
|
|
|
|
|
2017-10-18 00:29:18 +08:00
|
|
|
KMS cleanups
|
|
|
|
------------
|
|
|
|
|
|
|
|
Some of these date from the very introduction of KMS in 2008 ...
|
|
|
|
|
2018-10-05 04:24:45 +08:00
|
|
|
- Make ->funcs and ->helper_private vtables optional. There's a bunch of empty
|
|
|
|
function tables in drivers, but before we can remove them we need to make sure
|
|
|
|
that all the users in helpers and drivers do correctly check for a NULL
|
|
|
|
vtable.
|
|
|
|
|
|
|
|
- Cleanup up the various ->destroy callbacks. A lot of them just wrapt the
|
|
|
|
drm_*_cleanup implementations and can be removed. Some tack a kfree() at the
|
|
|
|
end, for which we could add drm_*_cleanup_kfree(). And then there's the (for
|
|
|
|
historical reasons) misnamed drm_primary_helper_destroy() function.
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate
|
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
Better Testing
|
|
|
|
==============
|
|
|
|
|
|
|
|
Enable trinity for DRM
|
|
|
|
----------------------
|
|
|
|
|
|
|
|
And fix up the fallout. Should be really interesting ...
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Advanced
|
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
Make KMS tests in i-g-t generic
|
|
|
|
-------------------------------
|
|
|
|
|
|
|
|
The i915 driver team maintains an extensive testsuite for the i915 DRM driver,
|
|
|
|
including tons of testcases for corner-cases in the modesetting API. It would
|
|
|
|
be awesome if those tests (at least the ones not relying on Intel-specific GEM
|
|
|
|
features) could be made to run on any KMS driver.
|
|
|
|
|
|
|
|
Basic work to run i-g-t tests on non-i915 is done, what's now missing is mass-
|
|
|
|
converting things over. For modeset tests we also first need a bit of
|
|
|
|
infrastructure to use dumb buffers for untiled buffers, to be able to run all
|
|
|
|
the non-i915 specific modeset tests.
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Advanced
|
|
|
|
|
2018-09-08 01:41:36 +08:00
|
|
|
Extend virtual test driver (VKMS)
|
|
|
|
---------------------------------
|
|
|
|
|
|
|
|
See the documentation of :ref:`VKMS <vkms>` for more details. This is an ideal
|
|
|
|
internship task, since it only requires a virtual machine and can be sized to
|
|
|
|
fit the available time.
|
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
Contact: Daniel Vetter
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: See details
|
|
|
|
|
2019-06-15 04:36:12 +08:00
|
|
|
Backlight Refactoring
|
|
|
|
---------------------
|
|
|
|
|
|
|
|
Backlight drivers have a triple enable/disable state, which is a bit overkill.
|
|
|
|
Plan to fix this:
|
|
|
|
|
|
|
|
1. Roll out backlight_enable() and backlight_disable() helpers everywhere. This
|
|
|
|
has started already.
|
|
|
|
2. In all, only look at one of the three status bits set by the above helpers.
|
|
|
|
3. Remove the other two status bits.
|
|
|
|
|
|
|
|
Contact: Daniel Vetter
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Intermediate
|
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
Driver Specific
|
|
|
|
===============
|
|
|
|
|
2017-09-28 23:53:19 +08:00
|
|
|
AMD DC Display Driver
|
|
|
|
---------------------
|
|
|
|
|
|
|
|
AMD DC is the display driver for AMD devices starting with Vega. There has been
|
|
|
|
a bunch of progress cleaning it up but there's still plenty of work to be done.
|
|
|
|
|
|
|
|
See drivers/gpu/drm/amd/display/TODO for tasks.
|
|
|
|
|
|
|
|
Contact: Harry Wentland, Alex Deucher
|
|
|
|
|
2019-06-08 23:26:57 +08:00
|
|
|
Bootsplash
|
|
|
|
==========
|
|
|
|
|
|
|
|
There is support in place now for writing internal DRM clients making it
|
|
|
|
possible to pick up the bootsplash work that was rejected because it was written
|
|
|
|
for fbdev.
|
|
|
|
|
|
|
|
- [v6,8/8] drm/client: Hack: Add bootsplash example
|
|
|
|
https://patchwork.freedesktop.org/patch/306579/
|
|
|
|
|
|
|
|
- [RFC PATCH v2 00/13] Kernel based bootsplash
|
|
|
|
https://lkml.org/lkml/2017/12/13/764
|
|
|
|
|
|
|
|
Contact: Sam Ravnborg
|
|
|
|
|
2019-10-22 23:25:30 +08:00
|
|
|
Level: Advanced
|
|
|
|
|
2017-02-08 01:51:13 +08:00
|
|
|
Outside DRM
|
|
|
|
===========
|
2019-10-17 15:47:05 +08:00
|
|
|
|
|
|
|
Convert fbdev drivers to DRM
|
|
|
|
----------------------------
|
|
|
|
|
|
|
|
There are plenty of fbdev drivers for older hardware. Some hwardware has
|
|
|
|
become obsolete, but some still provides good(-enough) framebuffers. The
|
|
|
|
drivers that are still useful should be converted to DRM and afterwards
|
|
|
|
removed from fbdev.
|
|
|
|
|
|
|
|
Very simple fbdev drivers can best be converted by starting with a new
|
|
|
|
DRM driver. Simple KMS helpers and SHMEM should be able to handle any
|
|
|
|
existing hardware. The new driver's call-back functions are filled from
|
|
|
|
existing fbdev code.
|
|
|
|
|
|
|
|
More complex fbdev drivers can be refactored step-by-step into a DRM
|
|
|
|
driver with the help of the DRM fbconv helpers. [1] These helpers provide
|
|
|
|
the transition layer between the DRM core infrastructure and the fbdev
|
|
|
|
driver interface. Create a new DRM driver on top of the fbconv helpers,
|
|
|
|
copy over the fbdev driver, and hook it up to the DRM code. Examples for
|
|
|
|
several fbdev drivers are available at [1] and a tutorial of this process
|
|
|
|
available at [2]. The result is a primitive DRM driver that can run X11
|
|
|
|
and Weston.
|
|
|
|
|
|
|
|
- [1] https://gitlab.freedesktop.org/tzimmermann/linux/tree/fbconv
|
|
|
|
- [2] https://gitlab.freedesktop.org/tzimmermann/linux/blob/fbconv/drivers/gpu/drm/drm_fbconv_helper.c
|
|
|
|
|
|
|
|
Contact: Thomas Zimmermann <tzimmermann@suse.de>
|
2019-10-22 23:25:30 +08:00
|
|
|
|
|
|
|
Level: Advanced
|