2018-06-12 13:58:38 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
//
|
|
|
|
// Renesas R-Car SSIU/SSI support
|
|
|
|
//
|
|
|
|
// Copyright (C) 2013 Renesas Solutions Corp.
|
|
|
|
// Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
|
|
|
|
//
|
|
|
|
// Based on fsi.c
|
|
|
|
// Kuninori Morimoto <morimoto.kuninori@renesas.com>
|
2018-02-13 10:08:53 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* you can enable below define if you don't need
|
|
|
|
* SSI interrupt status debug message when debugging
|
|
|
|
* see rsnd_dbg_irq_status()
|
|
|
|
*
|
|
|
|
* #define RSND_DEBUG_NO_IRQ_STATUS 1
|
|
|
|
*/
|
|
|
|
|
2017-05-18 09:28:22 +08:00
|
|
|
#include <sound/simple_card_utils.h>
|
2013-07-22 12:36:57 +08:00
|
|
|
#include <linux/delay.h>
|
|
|
|
#include "rsnd.h"
|
|
|
|
#define RSND_SSI_NAME_SIZE 16
|
|
|
|
|
|
|
|
/*
|
|
|
|
* SSICR
|
|
|
|
*/
|
|
|
|
#define FORCE (1 << 31) /* Fixed */
|
2013-07-29 09:59:02 +08:00
|
|
|
#define DMEN (1 << 28) /* DMA Enable */
|
2013-07-22 12:36:57 +08:00
|
|
|
#define UIEN (1 << 27) /* Underflow Interrupt Enable */
|
|
|
|
#define OIEN (1 << 26) /* Overflow Interrupt Enable */
|
|
|
|
#define IIEN (1 << 25) /* Idle Mode Interrupt Enable */
|
|
|
|
#define DIEN (1 << 24) /* Data Interrupt Enable */
|
2015-11-30 16:54:03 +08:00
|
|
|
#define CHNL_4 (1 << 22) /* Channels */
|
|
|
|
#define CHNL_6 (2 << 22) /* Channels */
|
|
|
|
#define CHNL_8 (3 << 22) /* Channels */
|
2018-06-12 13:52:17 +08:00
|
|
|
#define DWL_MASK (7 << 19) /* Data Word Length mask */
|
2013-07-22 12:36:57 +08:00
|
|
|
#define DWL_8 (0 << 19) /* Data Word Length */
|
|
|
|
#define DWL_16 (1 << 19) /* Data Word Length */
|
|
|
|
#define DWL_18 (2 << 19) /* Data Word Length */
|
|
|
|
#define DWL_20 (3 << 19) /* Data Word Length */
|
|
|
|
#define DWL_22 (4 << 19) /* Data Word Length */
|
|
|
|
#define DWL_24 (5 << 19) /* Data Word Length */
|
|
|
|
#define DWL_32 (6 << 19) /* Data Word Length */
|
|
|
|
|
2018-09-03 15:05:42 +08:00
|
|
|
/*
|
|
|
|
* System word length
|
|
|
|
*/
|
|
|
|
#define SWL_16 (1 << 16) /* R/W System Word Length */
|
|
|
|
#define SWL_24 (2 << 16) /* R/W System Word Length */
|
2013-07-22 12:36:57 +08:00
|
|
|
#define SWL_32 (3 << 16) /* R/W System Word Length */
|
2018-09-03 15:05:42 +08:00
|
|
|
|
2013-07-22 12:36:57 +08:00
|
|
|
#define SCKD (1 << 15) /* Serial Bit Clock Direction */
|
|
|
|
#define SWSD (1 << 14) /* Serial WS Direction */
|
|
|
|
#define SCKP (1 << 13) /* Serial Bit Clock Polarity */
|
|
|
|
#define SWSP (1 << 12) /* Serial WS Polarity */
|
|
|
|
#define SDTA (1 << 10) /* Serial Data Alignment */
|
2015-11-17 16:28:11 +08:00
|
|
|
#define PDTA (1 << 9) /* Parallel Data Alignment */
|
2013-07-22 12:36:57 +08:00
|
|
|
#define DEL (1 << 8) /* Serial Data Delay */
|
|
|
|
#define CKDV(v) (v << 4) /* Serial Clock Division Ratio */
|
|
|
|
#define TRMD (1 << 1) /* Transmit/Receive Mode Select */
|
|
|
|
#define EN (1 << 0) /* SSI Module Enable */
|
|
|
|
|
|
|
|
/*
|
|
|
|
* SSISR
|
|
|
|
*/
|
|
|
|
#define UIRQ (1 << 27) /* Underflow Error Interrupt Status */
|
|
|
|
#define OIRQ (1 << 26) /* Overflow Error Interrupt Status */
|
|
|
|
#define IIRQ (1 << 25) /* Idle Mode Interrupt Status */
|
|
|
|
#define DIRQ (1 << 24) /* Data Interrupt Status Flag */
|
|
|
|
|
2013-07-29 09:59:02 +08:00
|
|
|
/*
|
|
|
|
* SSIWSR
|
|
|
|
*/
|
|
|
|
#define CONT (1 << 8) /* WS Continue Function */
|
2015-11-30 16:54:03 +08:00
|
|
|
#define WS_MODE (1 << 0) /* WS Mode */
|
2013-07-29 09:59:02 +08:00
|
|
|
|
2014-05-23 14:25:43 +08:00
|
|
|
#define SSI_NAME "ssi"
|
|
|
|
|
2013-07-22 12:36:57 +08:00
|
|
|
struct rsnd_ssi {
|
|
|
|
struct rsnd_mod mod;
|
|
|
|
|
2015-11-10 13:11:35 +08:00
|
|
|
u32 flags;
|
2013-07-22 12:36:57 +08:00
|
|
|
u32 cr_own;
|
|
|
|
u32 cr_clk;
|
2015-10-26 16:43:57 +08:00
|
|
|
u32 cr_mode;
|
ASoC: rsnd: control SSICR::EN correctly
In case of SSI0 playback, SSI1 capture, SSI0 might be shared for
clock output if clock master mode.
Current rsnd driver had been assumed that SSI clock contiguous
output which is needed for SSI parent needs SSICR::EN (SSI module
enable) bit.
But, this bit controls data input/output, not for clock.
Clock contiguous output needs SSICR : FORCE, SCKD, SWSD,
and SSIWSR : CONT. Not SSICR : EN.
Because of this wrong assumption, and insufficient control, on current
code, for example, if it starts SSI0(playback) -> SSI1(capture) order,
SSI0 SSICR::EN bit will temporarily be 0.
It causes playback side underrun error. This is bug.
We can reproduce this issue with SSI+SRC (without DVC), and capture
during playback operation.
This patch fixup current (wrong) assumption, and control SSICR::EN bit
correctly.
Reported-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2017-08-08 09:31:39 +08:00
|
|
|
u32 cr_en;
|
2015-11-30 16:53:04 +08:00
|
|
|
u32 wsr;
|
2015-04-10 16:50:30 +08:00
|
|
|
int chan;
|
2015-10-26 16:43:57 +08:00
|
|
|
int rate;
|
2015-11-10 13:11:35 +08:00
|
|
|
int irq;
|
2013-07-22 12:36:57 +08:00
|
|
|
unsigned int usrcnt;
|
2017-06-07 08:20:47 +08:00
|
|
|
|
2017-12-11 10:40:22 +08:00
|
|
|
/* for PIO */
|
2017-06-07 08:20:47 +08:00
|
|
|
int byte_pos;
|
|
|
|
int byte_per_period;
|
|
|
|
int next_period_byte;
|
2013-07-22 12:36:57 +08:00
|
|
|
};
|
|
|
|
|
2015-11-10 13:11:35 +08:00
|
|
|
/* flags */
|
|
|
|
#define RSND_SSI_CLK_PIN_SHARE (1 << 0)
|
|
|
|
#define RSND_SSI_NO_BUSIF (1 << 1) /* SSI+DMA without BUSIF */
|
2018-11-06 13:19:48 +08:00
|
|
|
#define RSND_SSI_PROBED (1 << 2)
|
2015-11-10 13:11:35 +08:00
|
|
|
|
2013-07-22 12:36:57 +08:00
|
|
|
#define for_each_rsnd_ssi(pos, priv, i) \
|
|
|
|
for (i = 0; \
|
|
|
|
(i < rsnd_ssi_nr(priv)) && \
|
2014-01-24 10:39:40 +08:00
|
|
|
((pos) = ((struct rsnd_ssi *)(priv)->ssi + i)); \
|
2013-07-22 12:36:57 +08:00
|
|
|
i++)
|
|
|
|
|
2015-11-10 13:11:35 +08:00
|
|
|
#define rsnd_ssi_get(priv, id) ((struct rsnd_ssi *)(priv->ssi) + id)
|
2014-01-24 10:39:40 +08:00
|
|
|
#define rsnd_ssi_nr(priv) ((priv)->ssi_nr)
|
2013-07-22 12:36:57 +08:00
|
|
|
#define rsnd_mod_to_ssi(_mod) container_of((_mod), struct rsnd_ssi, mod)
|
2015-10-26 16:43:57 +08:00
|
|
|
#define rsnd_ssi_is_parent(ssi, io) ((ssi) == rsnd_io_to_mod_ssip(io))
|
2016-02-09 15:04:09 +08:00
|
|
|
#define rsnd_ssi_is_multi_slave(mod, io) \
|
|
|
|
(rsnd_ssi_multi_slaves(io) & (1 << rsnd_mod_id(mod)))
|
2016-02-18 16:19:12 +08:00
|
|
|
#define rsnd_ssi_is_run_mods(mod, io) \
|
|
|
|
(rsnd_ssi_run_mods(io) & (1 << rsnd_mod_id(mod)))
|
2017-08-08 09:32:42 +08:00
|
|
|
#define rsnd_ssi_can_output_clk(mod) (!__rsnd_ssi_is_pin_sharing(mod))
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2018-11-21 16:15:30 +08:00
|
|
|
static int rsnd_ssi_is_dma_mode(struct rsnd_mod *mod);
|
|
|
|
|
2015-10-22 11:15:46 +08:00
|
|
|
int rsnd_ssi_use_busif(struct rsnd_dai_stream *io)
|
2014-06-23 08:56:23 +08:00
|
|
|
{
|
2015-10-22 11:15:46 +08:00
|
|
|
struct rsnd_mod *mod = rsnd_io_to_mod_ssi(io);
|
2014-06-23 08:56:23 +08:00
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
|
|
|
int use_busif = 0;
|
|
|
|
|
2014-11-27 16:05:54 +08:00
|
|
|
if (!rsnd_ssi_is_dma_mode(mod))
|
|
|
|
return 0;
|
|
|
|
|
2017-10-02 07:47:50 +08:00
|
|
|
if (!(rsnd_flags_has(ssi, RSND_SSI_NO_BUSIF)))
|
2014-06-23 08:56:23 +08:00
|
|
|
use_busif = 1;
|
|
|
|
if (rsnd_io_to_mod_src(io))
|
|
|
|
use_busif = 1;
|
|
|
|
|
|
|
|
return use_busif;
|
|
|
|
}
|
|
|
|
|
2015-10-26 16:42:09 +08:00
|
|
|
static void rsnd_ssi_status_clear(struct rsnd_mod *mod)
|
|
|
|
{
|
|
|
|
rsnd_mod_write(mod, SSISR, 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static u32 rsnd_ssi_status_get(struct rsnd_mod *mod)
|
|
|
|
{
|
|
|
|
return rsnd_mod_read(mod, SSISR);
|
|
|
|
}
|
|
|
|
|
2013-07-22 12:36:57 +08:00
|
|
|
static void rsnd_ssi_status_check(struct rsnd_mod *mod,
|
|
|
|
u32 bit)
|
|
|
|
{
|
|
|
|
struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
|
|
|
|
struct device *dev = rsnd_priv_to_dev(priv);
|
|
|
|
u32 status;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < 1024; i++) {
|
2015-10-26 16:42:09 +08:00
|
|
|
status = rsnd_ssi_status_get(mod);
|
2013-07-22 12:36:57 +08:00
|
|
|
if (status & bit)
|
|
|
|
return;
|
|
|
|
|
2018-04-16 08:38:13 +08:00
|
|
|
udelay(5);
|
2013-07-22 12:36:57 +08:00
|
|
|
}
|
|
|
|
|
ASoC: rsnd: rsnd_mod_name() handles both name and ID
Current rsnd driver is using "%s[%d]" for mod name and ID,
but, this ID portion might confusable.
For example currently, CTU ID is 0 to 7, but using 00 to 13
(= 00, 01, 02, 03, 10, 11, 12, 13) is very best matching to datasheet.
In the future, we will support BUSIFn, but it will be more complicated
numbering. To avoid future confusable code, this patch modify
rsnd_mod_name() to return understandable name.
To avoid using pointless memory, it uses static char and snprintf,
thus, rsnd_mod_name() user should use it immediately, and shouldn't keep
its pointer.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2018-10-30 15:47:50 +08:00
|
|
|
dev_warn(dev, "%s status check failed\n", rsnd_mod_name(mod));
|
2013-07-22 12:36:57 +08:00
|
|
|
}
|
|
|
|
|
2016-02-18 16:18:54 +08:00
|
|
|
static u32 rsnd_ssi_multi_slaves(struct rsnd_dai_stream *io)
|
2015-12-17 11:00:10 +08:00
|
|
|
{
|
|
|
|
struct rsnd_mod *mod;
|
|
|
|
enum rsnd_mod_type types[] = {
|
|
|
|
RSND_MOD_SSIM1,
|
|
|
|
RSND_MOD_SSIM2,
|
|
|
|
RSND_MOD_SSIM3,
|
|
|
|
};
|
|
|
|
int i, mask;
|
|
|
|
|
|
|
|
mask = 0;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(types); i++) {
|
|
|
|
mod = rsnd_io_to_mod(io, types[i]);
|
|
|
|
if (!mod)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
mask |= 1 << rsnd_mod_id(mod);
|
|
|
|
}
|
|
|
|
|
|
|
|
return mask;
|
|
|
|
}
|
|
|
|
|
2016-02-18 16:19:12 +08:00
|
|
|
static u32 rsnd_ssi_run_mods(struct rsnd_dai_stream *io)
|
|
|
|
{
|
|
|
|
struct rsnd_mod *ssi_mod = rsnd_io_to_mod_ssi(io);
|
|
|
|
struct rsnd_mod *ssi_parent_mod = rsnd_io_to_mod_ssip(io);
|
2017-11-01 15:16:58 +08:00
|
|
|
u32 mods;
|
2016-02-18 16:19:12 +08:00
|
|
|
|
2017-11-01 15:16:58 +08:00
|
|
|
mods = rsnd_ssi_multi_slaves_runtime(io) |
|
|
|
|
1 << rsnd_mod_id(ssi_mod);
|
|
|
|
|
|
|
|
if (ssi_parent_mod)
|
|
|
|
mods |= 1 << rsnd_mod_id(ssi_parent_mod);
|
|
|
|
|
|
|
|
return mods;
|
2016-02-18 16:19:12 +08:00
|
|
|
}
|
|
|
|
|
2016-02-18 16:18:54 +08:00
|
|
|
u32 rsnd_ssi_multi_slaves_runtime(struct rsnd_dai_stream *io)
|
|
|
|
{
|
2018-11-06 13:19:19 +08:00
|
|
|
if (rsnd_runtime_is_multi_ssi(io))
|
2016-02-25 13:54:58 +08:00
|
|
|
return rsnd_ssi_multi_slaves(io);
|
2016-02-18 16:18:54 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-09-03 15:05:42 +08:00
|
|
|
static u32 rsnd_rdai_width_to_swl(struct rsnd_dai *rdai)
|
|
|
|
{
|
|
|
|
struct rsnd_priv *priv = rsnd_rdai_to_priv(rdai);
|
|
|
|
struct device *dev = rsnd_priv_to_dev(priv);
|
|
|
|
int width = rsnd_rdai_width_get(rdai);
|
|
|
|
|
|
|
|
switch (width) {
|
|
|
|
case 32: return SWL_32;
|
|
|
|
case 24: return SWL_24;
|
|
|
|
case 16: return SWL_16;
|
|
|
|
}
|
|
|
|
|
|
|
|
dev_err(dev, "unsupported slot width value: %d\n", width);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
unsigned int rsnd_ssi_clk_query(struct rsnd_dai *rdai,
|
2017-06-15 08:50:02 +08:00
|
|
|
int param1, int param2, int *idx)
|
|
|
|
{
|
2018-09-03 15:05:42 +08:00
|
|
|
struct rsnd_priv *priv = rsnd_rdai_to_priv(rdai);
|
2017-06-15 08:50:02 +08:00
|
|
|
int ssi_clk_mul_table[] = {
|
|
|
|
1, 2, 4, 8, 16, 6, 12,
|
|
|
|
};
|
|
|
|
int j, ret;
|
2017-06-16 08:02:59 +08:00
|
|
|
unsigned int main_rate;
|
2018-09-03 15:05:42 +08:00
|
|
|
int width = rsnd_rdai_width_get(rdai);
|
2017-06-15 08:50:02 +08:00
|
|
|
|
|
|
|
for (j = 0; j < ARRAY_SIZE(ssi_clk_mul_table); j++) {
|
|
|
|
|
|
|
|
/*
|
|
|
|
* It will set SSIWSR.CONT here, but SSICR.CKDV = 000
|
|
|
|
* with it is not allowed. (SSIWSR.WS_MODE with
|
|
|
|
* SSICR.CKDV = 000 is not allowed either).
|
|
|
|
* Skip it. See SSICR.CKDV
|
|
|
|
*/
|
|
|
|
if (j == 0)
|
|
|
|
continue;
|
|
|
|
|
2018-09-03 15:05:42 +08:00
|
|
|
main_rate = width * param1 * param2 * ssi_clk_mul_table[j];
|
2017-06-15 08:50:02 +08:00
|
|
|
|
|
|
|
ret = rsnd_adg_clk_query(priv, main_rate);
|
|
|
|
if (ret < 0)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (idx)
|
|
|
|
*idx = j;
|
|
|
|
|
|
|
|
return main_rate;
|
|
|
|
}
|
|
|
|
|
2017-06-16 08:02:59 +08:00
|
|
|
return 0;
|
2017-06-15 08:50:02 +08:00
|
|
|
}
|
|
|
|
|
2016-02-18 16:14:37 +08:00
|
|
|
static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod,
|
2013-12-20 11:28:39 +08:00
|
|
|
struct rsnd_dai_stream *io)
|
2013-07-22 12:36:57 +08:00
|
|
|
{
|
2015-01-15 16:08:34 +08:00
|
|
|
struct rsnd_priv *priv = rsnd_io_to_priv(io);
|
2013-07-22 12:36:57 +08:00
|
|
|
struct device *dev = rsnd_priv_to_dev(priv);
|
2015-10-26 16:43:57 +08:00
|
|
|
struct rsnd_dai *rdai = rsnd_io_to_rdai(io);
|
2016-02-18 16:14:37 +08:00
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
2016-02-25 13:54:58 +08:00
|
|
|
int chan = rsnd_runtime_channel_for_ssi(io);
|
2017-06-15 08:50:02 +08:00
|
|
|
int idx, ret;
|
2013-07-22 12:36:57 +08:00
|
|
|
unsigned int main_rate;
|
2016-03-07 13:08:33 +08:00
|
|
|
unsigned int rate = rsnd_io_is_play(io) ?
|
|
|
|
rsnd_src_get_out_rate(priv, io) :
|
|
|
|
rsnd_src_get_in_rate(priv, io);
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2015-10-26 16:43:57 +08:00
|
|
|
if (!rsnd_rdai_is_clk_master(rdai))
|
|
|
|
return 0;
|
|
|
|
|
2017-08-08 09:32:42 +08:00
|
|
|
if (!rsnd_ssi_can_output_clk(mod))
|
2015-10-26 16:43:57 +08:00
|
|
|
return 0;
|
|
|
|
|
2015-12-17 11:00:10 +08:00
|
|
|
if (rsnd_ssi_is_multi_slave(mod, io))
|
|
|
|
return 0;
|
|
|
|
|
2019-09-18 14:02:38 +08:00
|
|
|
if (rsnd_runtime_is_tdm_split(io))
|
|
|
|
chan = rsnd_io_converted_chan(io);
|
|
|
|
|
|
|
|
chan = rsnd_channel_normalization(chan);
|
|
|
|
|
2019-02-05 08:46:43 +08:00
|
|
|
if (ssi->usrcnt > 0) {
|
2015-10-26 16:43:57 +08:00
|
|
|
if (ssi->rate != rate) {
|
|
|
|
dev_err(dev, "SSI parent/child should use same rate\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2018-09-03 15:07:26 +08:00
|
|
|
if (ssi->chan != chan) {
|
|
|
|
dev_err(dev, "SSI parent/child should use same chan\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2015-10-26 16:43:57 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-09-03 15:05:42 +08:00
|
|
|
main_rate = rsnd_ssi_clk_query(rdai, rate, chan, &idx);
|
2017-06-16 08:02:59 +08:00
|
|
|
if (!main_rate) {
|
2017-06-15 08:50:02 +08:00
|
|
|
dev_err(dev, "unsupported clock rate\n");
|
|
|
|
return -EIO;
|
|
|
|
}
|
2015-09-10 15:03:48 +08:00
|
|
|
|
2017-06-15 08:50:02 +08:00
|
|
|
ret = rsnd_adg_ssi_clk_try_start(mod, main_rate);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
2015-10-26 16:43:57 +08:00
|
|
|
|
ASoC: rsnd: control SSICR::EN correctly
In case of SSI0 playback, SSI1 capture, SSI0 might be shared for
clock output if clock master mode.
Current rsnd driver had been assumed that SSI clock contiguous
output which is needed for SSI parent needs SSICR::EN (SSI module
enable) bit.
But, this bit controls data input/output, not for clock.
Clock contiguous output needs SSICR : FORCE, SCKD, SWSD,
and SSIWSR : CONT. Not SSICR : EN.
Because of this wrong assumption, and insufficient control, on current
code, for example, if it starts SSI0(playback) -> SSI1(capture) order,
SSI0 SSICR::EN bit will temporarily be 0.
It causes playback side underrun error. This is bug.
We can reproduce this issue with SSI+SRC (without DVC), and capture
during playback operation.
This patch fixup current (wrong) assumption, and control SSICR::EN bit
correctly.
Reported-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2017-08-08 09:31:39 +08:00
|
|
|
/*
|
|
|
|
* SSI clock will be output contiguously
|
|
|
|
* by below settings.
|
|
|
|
* This means, rsnd_ssi_master_clk_start()
|
|
|
|
* and rsnd_ssi_register_setup() are necessary
|
|
|
|
* for SSI parent
|
|
|
|
*
|
|
|
|
* SSICR : FORCE, SCKD, SWSD
|
|
|
|
* SSIWSR : CONT
|
|
|
|
*/
|
2018-09-03 15:05:42 +08:00
|
|
|
ssi->cr_clk = FORCE | rsnd_rdai_width_to_swl(rdai) |
|
|
|
|
SCKD | SWSD | CKDV(idx);
|
2017-06-15 08:50:02 +08:00
|
|
|
ssi->wsr = CONT;
|
|
|
|
ssi->rate = rate;
|
2018-09-03 15:07:26 +08:00
|
|
|
ssi->chan = chan;
|
2015-09-10 15:03:48 +08:00
|
|
|
|
2018-12-04 15:59:05 +08:00
|
|
|
dev_dbg(dev, "%s outputs %d chan %u Hz\n",
|
|
|
|
rsnd_mod_name(mod), chan, rate);
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2017-06-15 08:50:02 +08:00
|
|
|
return 0;
|
2013-07-22 12:36:57 +08:00
|
|
|
}
|
|
|
|
|
2016-02-18 16:14:37 +08:00
|
|
|
static void rsnd_ssi_master_clk_stop(struct rsnd_mod *mod,
|
2015-10-26 16:43:57 +08:00
|
|
|
struct rsnd_dai_stream *io)
|
2013-07-22 12:36:57 +08:00
|
|
|
{
|
2015-01-15 16:07:19 +08:00
|
|
|
struct rsnd_dai *rdai = rsnd_io_to_rdai(io);
|
2016-02-18 16:14:37 +08:00
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
2014-11-27 16:05:44 +08:00
|
|
|
|
2015-10-26 16:43:57 +08:00
|
|
|
if (!rsnd_rdai_is_clk_master(rdai))
|
2013-07-22 12:36:57 +08:00
|
|
|
return;
|
|
|
|
|
2017-08-08 09:32:42 +08:00
|
|
|
if (!rsnd_ssi_can_output_clk(mod))
|
2015-10-26 16:43:57 +08:00
|
|
|
return;
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2015-10-26 16:43:57 +08:00
|
|
|
if (ssi->usrcnt > 1)
|
|
|
|
return;
|
2015-04-10 16:50:30 +08:00
|
|
|
|
2015-10-26 16:43:57 +08:00
|
|
|
ssi->cr_clk = 0;
|
|
|
|
ssi->rate = 0;
|
2018-09-03 15:07:26 +08:00
|
|
|
ssi->chan = 0;
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2015-10-26 16:43:57 +08:00
|
|
|
rsnd_adg_ssi_clk_stop(mod);
|
2013-07-22 12:36:57 +08:00
|
|
|
}
|
|
|
|
|
2016-02-18 16:17:18 +08:00
|
|
|
static void rsnd_ssi_config_init(struct rsnd_mod *mod,
|
2015-11-30 16:52:38 +08:00
|
|
|
struct rsnd_dai_stream *io)
|
|
|
|
{
|
|
|
|
struct rsnd_dai *rdai = rsnd_io_to_rdai(io);
|
2018-12-04 15:59:05 +08:00
|
|
|
struct rsnd_priv *priv = rsnd_rdai_to_priv(rdai);
|
|
|
|
struct device *dev = rsnd_priv_to_dev(priv);
|
2015-11-30 16:52:38 +08:00
|
|
|
struct snd_pcm_runtime *runtime = rsnd_io_to_runtime(io);
|
2016-02-18 16:14:37 +08:00
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
2018-06-12 13:52:17 +08:00
|
|
|
u32 cr_own = ssi->cr_own;
|
|
|
|
u32 cr_mode = ssi->cr_mode;
|
|
|
|
u32 wsr = ssi->wsr;
|
2018-11-06 13:21:46 +08:00
|
|
|
int width;
|
|
|
|
int is_tdm, is_tdm_split;
|
2015-12-02 15:34:28 +08:00
|
|
|
|
2018-11-06 13:21:46 +08:00
|
|
|
is_tdm = rsnd_runtime_is_tdm(io);
|
|
|
|
is_tdm_split = rsnd_runtime_is_tdm_split(io);
|
2015-11-30 16:52:38 +08:00
|
|
|
|
2018-12-04 15:59:05 +08:00
|
|
|
if (is_tdm)
|
|
|
|
dev_dbg(dev, "TDM mode\n");
|
|
|
|
if (is_tdm_split)
|
|
|
|
dev_dbg(dev, "TDM Split mode\n");
|
|
|
|
|
2018-09-03 15:05:42 +08:00
|
|
|
cr_own |= FORCE | rsnd_rdai_width_to_swl(rdai);
|
2015-11-30 16:52:38 +08:00
|
|
|
|
|
|
|
if (rdai->bit_clk_inv)
|
|
|
|
cr_own |= SCKP;
|
2018-10-17 09:55:57 +08:00
|
|
|
if (rdai->frm_clk_inv && !is_tdm)
|
2015-11-30 16:52:38 +08:00
|
|
|
cr_own |= SWSP;
|
|
|
|
if (rdai->data_alignment)
|
|
|
|
cr_own |= SDTA;
|
|
|
|
if (rdai->sys_delay)
|
|
|
|
cr_own |= DEL;
|
2018-06-12 13:52:17 +08:00
|
|
|
|
2018-10-17 09:55:37 +08:00
|
|
|
/*
|
|
|
|
* TDM Mode
|
|
|
|
* see
|
|
|
|
* rsnd_ssiu_init_gen2()
|
|
|
|
*/
|
|
|
|
wsr = ssi->wsr;
|
2018-11-06 13:21:46 +08:00
|
|
|
if (is_tdm || is_tdm_split) {
|
2018-10-17 09:55:37 +08:00
|
|
|
wsr |= WS_MODE;
|
|
|
|
cr_own |= CHNL_8;
|
|
|
|
}
|
|
|
|
|
2018-06-12 13:52:17 +08:00
|
|
|
/*
|
|
|
|
* We shouldn't exchange SWSP after running.
|
|
|
|
* This means, parent needs to care it.
|
|
|
|
*/
|
2020-04-17 23:30:16 +08:00
|
|
|
if (rsnd_ssi_is_parent(mod, io))
|
2018-06-12 13:52:17 +08:00
|
|
|
goto init_end;
|
|
|
|
|
2015-11-30 16:52:38 +08:00
|
|
|
if (rsnd_io_is_play(io))
|
|
|
|
cr_own |= TRMD;
|
|
|
|
|
2018-06-12 13:52:17 +08:00
|
|
|
cr_own &= ~DWL_MASK;
|
2018-11-06 13:21:46 +08:00
|
|
|
width = snd_pcm_format_width(runtime->format);
|
|
|
|
if (is_tdm_split) {
|
|
|
|
/*
|
|
|
|
* The SWL and DWL bits in SSICR should be fixed at 32-bit
|
|
|
|
* setting when TDM split mode.
|
|
|
|
* see datasheet
|
|
|
|
* Operation :: TDM Format Split Function (TDM Split Mode)
|
|
|
|
*/
|
|
|
|
width = 32;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (width) {
|
2018-09-03 15:06:29 +08:00
|
|
|
case 8:
|
|
|
|
cr_own |= DWL_8;
|
|
|
|
break;
|
2015-11-30 16:52:38 +08:00
|
|
|
case 16:
|
|
|
|
cr_own |= DWL_16;
|
|
|
|
break;
|
2017-12-11 10:24:23 +08:00
|
|
|
case 24:
|
2015-11-30 16:52:38 +08:00
|
|
|
cr_own |= DWL_24;
|
|
|
|
break;
|
2018-11-06 13:21:46 +08:00
|
|
|
case 32:
|
|
|
|
cr_own |= DWL_32;
|
|
|
|
break;
|
2015-11-30 16:52:38 +08:00
|
|
|
}
|
|
|
|
|
2016-02-18 16:14:37 +08:00
|
|
|
if (rsnd_ssi_is_dma_mode(mod)) {
|
2015-11-30 16:52:38 +08:00
|
|
|
cr_mode = UIEN | OIEN | /* over/under run */
|
|
|
|
DMEN; /* DMA : enable DMA */
|
|
|
|
} else {
|
|
|
|
cr_mode = DIEN; /* PIO : enable Data interrupt */
|
|
|
|
}
|
|
|
|
|
2018-06-12 13:52:17 +08:00
|
|
|
init_end:
|
2015-11-30 16:52:38 +08:00
|
|
|
ssi->cr_own = cr_own;
|
|
|
|
ssi->cr_mode = cr_mode;
|
2015-11-30 16:54:03 +08:00
|
|
|
ssi->wsr = wsr;
|
2016-02-18 16:17:18 +08:00
|
|
|
}
|
2015-11-30 16:52:38 +08:00
|
|
|
|
2016-02-18 16:17:18 +08:00
|
|
|
static void rsnd_ssi_register_setup(struct rsnd_mod *mod)
|
|
|
|
{
|
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
|
|
|
|
|
|
|
rsnd_mod_write(mod, SSIWSR, ssi->wsr);
|
|
|
|
rsnd_mod_write(mod, SSICR, ssi->cr_own |
|
|
|
|
ssi->cr_clk |
|
ASoC: rsnd: control SSICR::EN correctly
In case of SSI0 playback, SSI1 capture, SSI0 might be shared for
clock output if clock master mode.
Current rsnd driver had been assumed that SSI clock contiguous
output which is needed for SSI parent needs SSICR::EN (SSI module
enable) bit.
But, this bit controls data input/output, not for clock.
Clock contiguous output needs SSICR : FORCE, SCKD, SWSD,
and SSIWSR : CONT. Not SSICR : EN.
Because of this wrong assumption, and insufficient control, on current
code, for example, if it starts SSI0(playback) -> SSI1(capture) order,
SSI0 SSICR::EN bit will temporarily be 0.
It causes playback side underrun error. This is bug.
We can reproduce this issue with SSI+SRC (without DVC), and capture
during playback operation.
This patch fixup current (wrong) assumption, and control SSICR::EN bit
correctly.
Reported-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2017-08-08 09:31:39 +08:00
|
|
|
ssi->cr_mode |
|
|
|
|
ssi->cr_en);
|
2015-11-30 16:52:38 +08:00
|
|
|
}
|
|
|
|
|
2013-07-22 12:36:57 +08:00
|
|
|
/*
|
|
|
|
* SSI mod common functions
|
|
|
|
*/
|
|
|
|
static int rsnd_ssi_init(struct rsnd_mod *mod,
|
2015-06-15 14:25:20 +08:00
|
|
|
struct rsnd_dai_stream *io,
|
2015-01-15 16:07:47 +08:00
|
|
|
struct rsnd_priv *priv)
|
2013-07-22 12:36:57 +08:00
|
|
|
{
|
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
2015-10-26 16:43:57 +08:00
|
|
|
|
2016-02-18 16:19:12 +08:00
|
|
|
if (!rsnd_ssi_is_run_mods(mod, io))
|
|
|
|
return 0;
|
|
|
|
|
2015-10-26 16:43:57 +08:00
|
|
|
ssi->usrcnt++;
|
|
|
|
|
|
|
|
rsnd_mod_power_on(mod);
|
|
|
|
|
2017-08-08 09:32:08 +08:00
|
|
|
rsnd_ssi_config_init(mod, io);
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2016-02-18 16:17:18 +08:00
|
|
|
rsnd_ssi_register_setup(mod);
|
2015-10-26 16:43:57 +08:00
|
|
|
|
|
|
|
/* clear error status */
|
|
|
|
rsnd_ssi_status_clear(mod);
|
|
|
|
|
2013-07-22 12:36:57 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int rsnd_ssi_quit(struct rsnd_mod *mod,
|
2015-06-15 14:25:20 +08:00
|
|
|
struct rsnd_dai_stream *io,
|
2015-01-15 16:07:47 +08:00
|
|
|
struct rsnd_priv *priv)
|
2013-07-22 12:36:57 +08:00
|
|
|
{
|
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
|
|
|
struct device *dev = rsnd_priv_to_dev(priv);
|
|
|
|
|
2016-02-18 16:19:12 +08:00
|
|
|
if (!rsnd_ssi_is_run_mods(mod, io))
|
|
|
|
return 0;
|
|
|
|
|
2015-12-24 15:02:39 +08:00
|
|
|
if (!ssi->usrcnt) {
|
ASoC: rsnd: rsnd_mod_name() handles both name and ID
Current rsnd driver is using "%s[%d]" for mod name and ID,
but, this ID portion might confusable.
For example currently, CTU ID is 0 to 7, but using 00 to 13
(= 00, 01, 02, 03, 10, 11, 12, 13) is very best matching to datasheet.
In the future, we will support BUSIFn, but it will be more complicated
numbering. To avoid future confusable code, this patch modify
rsnd_mod_name() to return understandable name.
To avoid using pointless memory, it uses static char and snprintf,
thus, rsnd_mod_name() user should use it immediately, and shouldn't keep
its pointer.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2018-10-30 15:47:50 +08:00
|
|
|
dev_err(dev, "%s usrcnt error\n", rsnd_mod_name(mod));
|
2015-12-24 15:02:39 +08:00
|
|
|
return -EIO;
|
|
|
|
}
|
2015-10-26 16:43:57 +08:00
|
|
|
|
2016-02-18 16:14:37 +08:00
|
|
|
rsnd_ssi_master_clk_stop(mod, io);
|
2015-10-26 16:43:57 +08:00
|
|
|
|
|
|
|
rsnd_mod_power_off(mod);
|
|
|
|
|
|
|
|
ssi->usrcnt--;
|
|
|
|
|
2018-06-12 13:52:17 +08:00
|
|
|
if (!ssi->usrcnt) {
|
|
|
|
ssi->cr_own = 0;
|
|
|
|
ssi->cr_mode = 0;
|
|
|
|
ssi->wsr = 0;
|
|
|
|
}
|
|
|
|
|
2013-07-22 12:36:57 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-04-10 16:50:30 +08:00
|
|
|
static int rsnd_ssi_hw_params(struct rsnd_mod *mod,
|
2015-06-15 14:25:20 +08:00
|
|
|
struct rsnd_dai_stream *io,
|
2015-04-10 16:50:30 +08:00
|
|
|
struct snd_pcm_substream *substream,
|
|
|
|
struct snd_pcm_hw_params *params)
|
|
|
|
{
|
2018-09-03 15:05:42 +08:00
|
|
|
struct rsnd_dai *rdai = rsnd_io_to_rdai(io);
|
|
|
|
unsigned int fmt_width = snd_pcm_format_width(params_format(params));
|
|
|
|
|
|
|
|
if (fmt_width > rdai->chan_width) {
|
|
|
|
struct rsnd_priv *priv = rsnd_io_to_priv(io);
|
|
|
|
struct device *dev = rsnd_priv_to_dev(priv);
|
|
|
|
|
|
|
|
dev_err(dev, "invalid combination of slot-width and format-data-width\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
2015-04-10 16:50:30 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-01-26 12:56:14 +08:00
|
|
|
static int rsnd_ssi_start(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io,
|
|
|
|
struct rsnd_priv *priv)
|
2015-10-26 16:43:57 +08:00
|
|
|
{
|
ASoC: rsnd: control SSICR::EN correctly
In case of SSI0 playback, SSI1 capture, SSI0 might be shared for
clock output if clock master mode.
Current rsnd driver had been assumed that SSI clock contiguous
output which is needed for SSI parent needs SSICR::EN (SSI module
enable) bit.
But, this bit controls data input/output, not for clock.
Clock contiguous output needs SSICR : FORCE, SCKD, SWSD,
and SSIWSR : CONT. Not SSICR : EN.
Because of this wrong assumption, and insufficient control, on current
code, for example, if it starts SSI0(playback) -> SSI1(capture) order,
SSI0 SSICR::EN bit will temporarily be 0.
It causes playback side underrun error. This is bug.
We can reproduce this issue with SSI+SRC (without DVC), and capture
during playback operation.
This patch fixup current (wrong) assumption, and control SSICR::EN bit
correctly.
Reported-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2017-08-08 09:31:39 +08:00
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
|
|
|
|
2016-02-18 16:19:12 +08:00
|
|
|
if (!rsnd_ssi_is_run_mods(mod, io))
|
|
|
|
return 0;
|
|
|
|
|
2015-12-17 11:00:10 +08:00
|
|
|
/*
|
|
|
|
* EN will be set via SSIU :: SSI_CONTROL
|
|
|
|
* if Multi channel mode
|
|
|
|
*/
|
2016-02-18 16:18:54 +08:00
|
|
|
if (rsnd_ssi_multi_slaves_runtime(io))
|
2016-02-18 16:17:18 +08:00
|
|
|
return 0;
|
2015-10-26 16:43:57 +08:00
|
|
|
|
ASoC: rsnd: control SSICR::EN correctly
In case of SSI0 playback, SSI1 capture, SSI0 might be shared for
clock output if clock master mode.
Current rsnd driver had been assumed that SSI clock contiguous
output which is needed for SSI parent needs SSICR::EN (SSI module
enable) bit.
But, this bit controls data input/output, not for clock.
Clock contiguous output needs SSICR : FORCE, SCKD, SWSD,
and SSIWSR : CONT. Not SSICR : EN.
Because of this wrong assumption, and insufficient control, on current
code, for example, if it starts SSI0(playback) -> SSI1(capture) order,
SSI0 SSICR::EN bit will temporarily be 0.
It causes playback side underrun error. This is bug.
We can reproduce this issue with SSI+SRC (without DVC), and capture
during playback operation.
This patch fixup current (wrong) assumption, and control SSICR::EN bit
correctly.
Reported-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2017-08-08 09:31:39 +08:00
|
|
|
/*
|
|
|
|
* EN is for data output.
|
|
|
|
* SSI parent EN is not needed.
|
|
|
|
*/
|
2020-04-17 23:30:16 +08:00
|
|
|
if (rsnd_ssi_is_parent(mod, io))
|
ASoC: rsnd: control SSICR::EN correctly
In case of SSI0 playback, SSI1 capture, SSI0 might be shared for
clock output if clock master mode.
Current rsnd driver had been assumed that SSI clock contiguous
output which is needed for SSI parent needs SSICR::EN (SSI module
enable) bit.
But, this bit controls data input/output, not for clock.
Clock contiguous output needs SSICR : FORCE, SCKD, SWSD,
and SSIWSR : CONT. Not SSICR : EN.
Because of this wrong assumption, and insufficient control, on current
code, for example, if it starts SSI0(playback) -> SSI1(capture) order,
SSI0 SSICR::EN bit will temporarily be 0.
It causes playback side underrun error. This is bug.
We can reproduce this issue with SSI+SRC (without DVC), and capture
during playback operation.
This patch fixup current (wrong) assumption, and control SSICR::EN bit
correctly.
Reported-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2017-08-08 09:31:39 +08:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
ssi->cr_en = EN;
|
|
|
|
|
|
|
|
rsnd_mod_write(mod, SSICR, ssi->cr_own |
|
|
|
|
ssi->cr_clk |
|
|
|
|
ssi->cr_mode |
|
|
|
|
ssi->cr_en);
|
2015-10-26 16:43:57 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-01-26 12:56:14 +08:00
|
|
|
static int rsnd_ssi_stop(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io,
|
|
|
|
struct rsnd_priv *priv)
|
2015-10-26 16:43:57 +08:00
|
|
|
{
|
2016-01-26 12:56:14 +08:00
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
|
|
|
u32 cr;
|
|
|
|
|
2016-02-18 16:19:12 +08:00
|
|
|
if (!rsnd_ssi_is_run_mods(mod, io))
|
|
|
|
return 0;
|
|
|
|
|
2020-04-17 23:30:16 +08:00
|
|
|
if (rsnd_ssi_is_parent(mod, io))
|
2016-01-26 12:56:14 +08:00
|
|
|
return 0;
|
2015-10-26 16:43:57 +08:00
|
|
|
|
|
|
|
cr = ssi->cr_own |
|
|
|
|
ssi->cr_clk;
|
2014-11-27 16:07:47 +08:00
|
|
|
|
2017-10-31 08:40:32 +08:00
|
|
|
/*
|
|
|
|
* disable all IRQ,
|
|
|
|
* Playback: Wait all data was sent
|
|
|
|
* Capture: It might not receave data. Do nothing
|
|
|
|
*/
|
|
|
|
if (rsnd_io_is_play(io)) {
|
2020-04-17 23:30:17 +08:00
|
|
|
rsnd_mod_write(mod, SSICR, cr | ssi->cr_en);
|
2017-10-31 08:40:32 +08:00
|
|
|
rsnd_ssi_status_check(mod, DIRQ);
|
|
|
|
}
|
2014-11-27 16:07:47 +08:00
|
|
|
|
2020-04-17 23:30:17 +08:00
|
|
|
/* In multi-SSI mode, stop is performed by setting ssi0129 in
|
|
|
|
* SSI_CONTROL to 0 (in rsnd_ssio_stop_gen2). Do nothing here.
|
|
|
|
*/
|
|
|
|
if (rsnd_ssi_multi_slaves_runtime(io))
|
|
|
|
return 0;
|
|
|
|
|
2015-10-26 16:43:57 +08:00
|
|
|
/*
|
|
|
|
* disable SSI,
|
|
|
|
* and, wait idle state
|
|
|
|
*/
|
|
|
|
rsnd_mod_write(mod, SSICR, cr); /* disabled all */
|
|
|
|
rsnd_ssi_status_check(mod, IIRQ);
|
2014-11-27 16:07:47 +08:00
|
|
|
|
ASoC: rsnd: control SSICR::EN correctly
In case of SSI0 playback, SSI1 capture, SSI0 might be shared for
clock output if clock master mode.
Current rsnd driver had been assumed that SSI clock contiguous
output which is needed for SSI parent needs SSICR::EN (SSI module
enable) bit.
But, this bit controls data input/output, not for clock.
Clock contiguous output needs SSICR : FORCE, SCKD, SWSD,
and SSIWSR : CONT. Not SSICR : EN.
Because of this wrong assumption, and insufficient control, on current
code, for example, if it starts SSI0(playback) -> SSI1(capture) order,
SSI0 SSICR::EN bit will temporarily be 0.
It causes playback side underrun error. This is bug.
We can reproduce this issue with SSI+SRC (without DVC), and capture
during playback operation.
This patch fixup current (wrong) assumption, and control SSICR::EN bit
correctly.
Reported-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2017-08-08 09:31:39 +08:00
|
|
|
ssi->cr_en = 0;
|
|
|
|
|
2014-11-27 16:07:47 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-02-18 16:18:16 +08:00
|
|
|
static int rsnd_ssi_irq(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io,
|
|
|
|
struct rsnd_priv *priv,
|
|
|
|
int enable)
|
|
|
|
{
|
|
|
|
u32 val = 0;
|
|
|
|
|
|
|
|
if (rsnd_is_gen1(priv))
|
|
|
|
return 0;
|
|
|
|
|
2020-04-17 23:30:16 +08:00
|
|
|
if (rsnd_ssi_is_parent(mod, io))
|
2016-02-18 16:18:16 +08:00
|
|
|
return 0;
|
|
|
|
|
2016-02-18 16:19:12 +08:00
|
|
|
if (!rsnd_ssi_is_run_mods(mod, io))
|
|
|
|
return 0;
|
|
|
|
|
2016-02-18 16:18:16 +08:00
|
|
|
if (enable)
|
|
|
|
val = rsnd_ssi_is_dma_mode(mod) ? 0x0e000000 : 0x0f000000;
|
|
|
|
|
|
|
|
rsnd_mod_write(mod, SSI_INT_ENABLE, val);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-12-11 10:40:22 +08:00
|
|
|
static bool rsnd_ssi_pio_interrupt(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io);
|
2015-06-15 14:26:56 +08:00
|
|
|
static void __rsnd_ssi_interrupt(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io)
|
2013-07-22 12:36:57 +08:00
|
|
|
{
|
2015-01-15 16:07:47 +08:00
|
|
|
struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
|
2018-02-13 10:08:53 +08:00
|
|
|
struct device *dev = rsnd_priv_to_dev(priv);
|
2015-01-15 16:09:13 +08:00
|
|
|
int is_dma = rsnd_ssi_is_dma_mode(mod);
|
2015-05-21 11:50:23 +08:00
|
|
|
u32 status;
|
2015-06-15 14:21:15 +08:00
|
|
|
bool elapsed = false;
|
2016-01-26 12:56:14 +08:00
|
|
|
bool stop = false;
|
2015-05-21 11:50:23 +08:00
|
|
|
|
|
|
|
spin_lock(&priv->lock);
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2015-05-21 11:50:23 +08:00
|
|
|
/* ignore all cases if not working */
|
2015-06-15 14:27:47 +08:00
|
|
|
if (!rsnd_io_is_working(io))
|
2015-05-21 11:50:23 +08:00
|
|
|
goto rsnd_ssi_interrupt_out;
|
|
|
|
|
2016-01-26 12:56:14 +08:00
|
|
|
status = rsnd_ssi_status_get(mod);
|
2014-11-27 16:07:47 +08:00
|
|
|
|
|
|
|
/* PIO only */
|
2017-12-11 10:40:22 +08:00
|
|
|
if (!is_dma && (status & DIRQ))
|
|
|
|
elapsed = rsnd_ssi_pio_interrupt(mod, io);
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2015-06-15 14:20:54 +08:00
|
|
|
/* DMA only */
|
2018-02-13 10:08:53 +08:00
|
|
|
if (is_dma && (status & (UIRQ | OIRQ))) {
|
ASoC: rsnd: rsnd_mod_name() handles both name and ID
Current rsnd driver is using "%s[%d]" for mod name and ID,
but, this ID portion might confusable.
For example currently, CTU ID is 0 to 7, but using 00 to 13
(= 00, 01, 02, 03, 10, 11, 12, 13) is very best matching to datasheet.
In the future, we will support BUSIFn, but it will be more complicated
numbering. To avoid future confusable code, this patch modify
rsnd_mod_name() to return understandable name.
To avoid using pointless memory, it uses static char and snprintf,
thus, rsnd_mod_name() user should use it immediately, and shouldn't keep
its pointer.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2018-10-30 15:47:50 +08:00
|
|
|
rsnd_dbg_irq_status(dev, "%s err status : 0x%08x\n",
|
|
|
|
rsnd_mod_name(mod), status);
|
2018-02-13 10:08:53 +08:00
|
|
|
|
2016-01-26 12:56:14 +08:00
|
|
|
stop = true;
|
2018-02-13 10:08:53 +08:00
|
|
|
}
|
2015-10-26 16:41:36 +08:00
|
|
|
|
2015-11-26 19:13:40 +08:00
|
|
|
rsnd_ssi_status_clear(mod);
|
2015-05-21 11:50:23 +08:00
|
|
|
rsnd_ssi_interrupt_out:
|
|
|
|
spin_unlock(&priv->lock);
|
|
|
|
|
2015-06-15 14:21:15 +08:00
|
|
|
if (elapsed)
|
|
|
|
rsnd_dai_period_elapsed(io);
|
2016-01-26 12:56:14 +08:00
|
|
|
|
|
|
|
if (stop)
|
|
|
|
snd_pcm_stop_xrun(io->substream);
|
|
|
|
|
2015-06-15 14:26:56 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static irqreturn_t rsnd_ssi_interrupt(int irq, void *data)
|
|
|
|
{
|
|
|
|
struct rsnd_mod *mod = data;
|
|
|
|
|
|
|
|
rsnd_mod_interrupt(mod, __rsnd_ssi_interrupt);
|
2015-06-15 14:21:15 +08:00
|
|
|
|
2014-11-27 16:07:47 +08:00
|
|
|
return IRQ_HANDLED;
|
2013-07-22 12:36:57 +08:00
|
|
|
}
|
|
|
|
|
2018-10-30 15:46:05 +08:00
|
|
|
static u32 *rsnd_ssi_get_status(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io,
|
|
|
|
enum rsnd_mod_type type)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* SSIP (= SSI parent) needs to be special, otherwise,
|
|
|
|
* 2nd SSI might doesn't start. see also rsnd_mod_call()
|
|
|
|
*
|
|
|
|
* We can't include parent SSI status on SSI, because we don't know
|
|
|
|
* how many SSI requests parent SSI. Thus, it is localed on "io" now.
|
|
|
|
* ex) trouble case
|
|
|
|
* Playback: SSI0
|
|
|
|
* Capture : SSI1 (needs SSI0)
|
|
|
|
*
|
|
|
|
* 1) start Capture -> SSI0/SSI1 are started.
|
|
|
|
* 2) start Playback -> SSI0 doesn't work, because it is already
|
|
|
|
* marked as "started" on 1)
|
|
|
|
*
|
|
|
|
* OTOH, using each mod's status is good for MUX case.
|
|
|
|
* It doesn't need to start in 2nd start
|
|
|
|
* ex)
|
|
|
|
* IO-0: SRC0 -> CTU1 -+-> MUX -> DVC -> SSIU -> SSI0
|
|
|
|
* |
|
|
|
|
* IO-1: SRC1 -> CTU2 -+
|
|
|
|
*
|
|
|
|
* 1) start IO-0 -> start SSI0
|
|
|
|
* 2) start IO-1 -> SSI0 doesn't need to start, because it is
|
|
|
|
* already started on 1)
|
|
|
|
*/
|
|
|
|
if (type == RSND_MOD_SSIP)
|
|
|
|
return &io->parent_ssi_status;
|
|
|
|
|
|
|
|
return rsnd_mod_get_status(mod, io, type);
|
|
|
|
}
|
|
|
|
|
2014-11-27 16:08:10 +08:00
|
|
|
/*
|
|
|
|
* SSI PIO
|
|
|
|
*/
|
2015-10-26 16:43:57 +08:00
|
|
|
static void rsnd_ssi_parent_attach(struct rsnd_mod *mod,
|
2016-02-18 16:17:52 +08:00
|
|
|
struct rsnd_dai_stream *io)
|
2015-10-26 16:43:57 +08:00
|
|
|
{
|
2016-02-18 16:17:52 +08:00
|
|
|
struct rsnd_dai *rdai = rsnd_io_to_rdai(io);
|
|
|
|
struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
|
|
|
|
|
2015-10-26 16:43:57 +08:00
|
|
|
if (!__rsnd_ssi_is_pin_sharing(mod))
|
|
|
|
return;
|
|
|
|
|
2016-02-18 16:17:52 +08:00
|
|
|
if (!rsnd_rdai_is_clk_master(rdai))
|
|
|
|
return;
|
|
|
|
|
2020-04-17 23:30:16 +08:00
|
|
|
if (rsnd_ssi_is_multi_slave(mod, io))
|
|
|
|
return;
|
|
|
|
|
2015-10-26 16:43:57 +08:00
|
|
|
switch (rsnd_mod_id(mod)) {
|
|
|
|
case 1:
|
|
|
|
case 2:
|
2019-06-26 10:00:05 +08:00
|
|
|
case 9:
|
2015-10-26 16:43:57 +08:00
|
|
|
rsnd_dai_connect(rsnd_ssi_mod_get(priv, 0), io, RSND_MOD_SSIP);
|
|
|
|
break;
|
|
|
|
case 4:
|
|
|
|
rsnd_dai_connect(rsnd_ssi_mod_get(priv, 3), io, RSND_MOD_SSIP);
|
|
|
|
break;
|
|
|
|
case 8:
|
|
|
|
rsnd_dai_connect(rsnd_ssi_mod_get(priv, 7), io, RSND_MOD_SSIP);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-02-18 16:17:52 +08:00
|
|
|
static int rsnd_ssi_pcm_new(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io,
|
|
|
|
struct snd_soc_pcm_runtime *rtd)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* rsnd_rdai_is_clk_master() will be enabled after set_fmt,
|
|
|
|
* and, pcm_new will be called after it.
|
|
|
|
* This function reuse pcm_new at this point.
|
|
|
|
*/
|
|
|
|
rsnd_ssi_parent_attach(mod, io);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-10-26 16:43:41 +08:00
|
|
|
static int rsnd_ssi_common_probe(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io,
|
|
|
|
struct rsnd_priv *priv)
|
2014-03-04 12:50:49 +08:00
|
|
|
{
|
|
|
|
struct device *dev = rsnd_priv_to_dev(priv);
|
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
ASoC: rsnd: add SSIU BUSIF support
Gen2 has BUSIF0-3, Gen3 has BUSIF0-7 on some SSIU.
Current driver is assuming it is using BUSIF0 as default.
Thus, SSI is attaching SSIU (with BUSIF0) by using rsnd_ssiu_attach().
But, TDM split mode also needs other BUSIF to use it.
This patch adds missing SSIU BUSIFx support.
BUSIF is handled by SSIU instead of SSI anymore.
Thus, its settings no longer needed on SSI node on DT.
This patch removes its settings from Document, but driver is still
keeping compatibility. Thus, old DT style is still working.
But, to avoid confusing, it doesn't indicate old compatibility things on
Document. New SoC should have SSIU on DT from this patch.
1) old style DT is still supported (= no rcar_sound,ssiu node on DT)
2) If ssiu is not indicated on playback/capture,
BUSIF0 will be used as default
playback = <&ssi3>; /* ssiu30 will be selected */
3) you can select own ssiu
playback = <&ssi32 &ssi3>; /* ssiu32 will be selected */
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2018-11-06 13:21:08 +08:00
|
|
|
int ret = 0;
|
2014-03-04 12:50:49 +08:00
|
|
|
|
2015-12-17 11:00:10 +08:00
|
|
|
/*
|
|
|
|
* SSIP/SSIU/IRQ are not needed on
|
|
|
|
* SSI Multi slaves
|
|
|
|
*/
|
|
|
|
if (rsnd_ssi_is_multi_slave(mod, io))
|
|
|
|
return 0;
|
|
|
|
|
2016-02-18 16:17:52 +08:00
|
|
|
/*
|
|
|
|
* It can't judge ssi parent at this point
|
|
|
|
* see rsnd_ssi_pcm_new()
|
|
|
|
*/
|
2015-10-26 16:43:57 +08:00
|
|
|
|
2016-10-25 08:36:34 +08:00
|
|
|
/*
|
|
|
|
* SSI might be called again as PIO fallback
|
|
|
|
* It is easy to manual handling for IRQ request/free
|
2017-08-10 08:07:38 +08:00
|
|
|
*
|
|
|
|
* OTOH, this function might be called many times if platform is
|
|
|
|
* using MIX. It needs xxx_attach() many times on xxx_probe().
|
|
|
|
* Because of it, we can't control .probe/.remove calling count by
|
|
|
|
* mod->status.
|
|
|
|
* But it don't need to call request_irq() many times.
|
|
|
|
* Let's control it by RSND_SSI_PROBED flag.
|
2016-10-25 08:36:34 +08:00
|
|
|
*/
|
2017-10-02 07:47:50 +08:00
|
|
|
if (!rsnd_flags_has(ssi, RSND_SSI_PROBED)) {
|
2017-08-10 08:07:38 +08:00
|
|
|
ret = request_irq(ssi->irq,
|
|
|
|
rsnd_ssi_interrupt,
|
|
|
|
IRQF_SHARED,
|
|
|
|
dev_name(dev), mod);
|
|
|
|
|
2017-10-02 07:47:50 +08:00
|
|
|
rsnd_flags_set(ssi, RSND_SSI_PROBED);
|
2017-08-10 08:07:38 +08:00
|
|
|
}
|
2014-05-23 14:25:43 +08:00
|
|
|
|
2014-03-04 12:50:49 +08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2017-08-10 08:07:00 +08:00
|
|
|
static int rsnd_ssi_common_remove(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io,
|
|
|
|
struct rsnd_priv *priv)
|
|
|
|
{
|
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
|
|
|
struct rsnd_mod *pure_ssi_mod = rsnd_io_to_mod_ssi(io);
|
|
|
|
|
|
|
|
/* Do nothing if non SSI (= SSI parent, multi SSI) mod */
|
|
|
|
if (pure_ssi_mod != mod)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* PIO will request IRQ again */
|
2017-10-02 07:47:50 +08:00
|
|
|
if (rsnd_flags_has(ssi, RSND_SSI_PROBED)) {
|
2017-08-10 08:07:38 +08:00
|
|
|
free_irq(ssi->irq, mod);
|
|
|
|
|
2017-10-02 07:47:50 +08:00
|
|
|
rsnd_flags_del(ssi, RSND_SSI_PROBED);
|
2017-08-10 08:07:38 +08:00
|
|
|
}
|
2017-08-10 08:07:00 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-12-11 10:40:22 +08:00
|
|
|
/*
|
|
|
|
* SSI PIO functions
|
|
|
|
*/
|
|
|
|
static bool rsnd_ssi_pio_interrupt(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io)
|
|
|
|
{
|
|
|
|
struct snd_pcm_runtime *runtime = rsnd_io_to_runtime(io);
|
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
|
|
|
u32 *buf = (u32 *)(runtime->dma_area + ssi->byte_pos);
|
|
|
|
int shift = 0;
|
|
|
|
int byte_pos;
|
|
|
|
bool elapsed = false;
|
|
|
|
|
|
|
|
if (snd_pcm_format_width(runtime->format) == 24)
|
|
|
|
shift = 8;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* 8/16/32 data can be assesse to TDR/RDR register
|
|
|
|
* directly as 32bit data
|
|
|
|
* see rsnd_ssi_init()
|
|
|
|
*/
|
|
|
|
if (rsnd_io_is_play(io))
|
|
|
|
rsnd_mod_write(mod, SSITDR, (*buf) << shift);
|
|
|
|
else
|
|
|
|
*buf = (rsnd_mod_read(mod, SSIRDR) >> shift);
|
|
|
|
|
|
|
|
byte_pos = ssi->byte_pos + sizeof(*buf);
|
|
|
|
|
|
|
|
if (byte_pos >= ssi->next_period_byte) {
|
|
|
|
int period_pos = byte_pos / ssi->byte_per_period;
|
|
|
|
|
|
|
|
if (period_pos >= runtime->periods) {
|
|
|
|
byte_pos = 0;
|
|
|
|
period_pos = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
ssi->next_period_byte = (period_pos + 1) * ssi->byte_per_period;
|
|
|
|
|
|
|
|
elapsed = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
WRITE_ONCE(ssi->byte_pos, byte_pos);
|
|
|
|
|
|
|
|
return elapsed;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int rsnd_ssi_pio_init(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io,
|
|
|
|
struct rsnd_priv *priv)
|
|
|
|
{
|
|
|
|
struct snd_pcm_runtime *runtime = rsnd_io_to_runtime(io);
|
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
|
|
|
|
|
|
|
if (!rsnd_ssi_is_parent(mod, io)) {
|
|
|
|
ssi->byte_pos = 0;
|
|
|
|
ssi->byte_per_period = runtime->period_size *
|
|
|
|
runtime->channels *
|
|
|
|
samples_to_bytes(runtime, 1);
|
|
|
|
ssi->next_period_byte = ssi->byte_per_period;
|
|
|
|
}
|
|
|
|
|
|
|
|
return rsnd_ssi_init(mod, io, priv);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int rsnd_ssi_pio_pointer(struct rsnd_mod *mod,
|
2017-06-07 08:20:01 +08:00
|
|
|
struct rsnd_dai_stream *io,
|
|
|
|
snd_pcm_uframes_t *pointer)
|
|
|
|
{
|
2017-06-07 08:20:47 +08:00
|
|
|
struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod);
|
2017-06-07 08:20:01 +08:00
|
|
|
struct snd_pcm_runtime *runtime = rsnd_io_to_runtime(io);
|
|
|
|
|
2017-12-08 14:15:38 +08:00
|
|
|
*pointer = bytes_to_frames(runtime, READ_ONCE(ssi->byte_pos));
|
2017-06-07 08:20:01 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-09-03 15:08:58 +08:00
|
|
|
static int rsnd_ssi_prepare(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io,
|
|
|
|
struct rsnd_priv *priv)
|
|
|
|
{
|
|
|
|
return rsnd_ssi_master_clk_start(mod, io);
|
|
|
|
}
|
|
|
|
|
2013-07-22 12:36:57 +08:00
|
|
|
static struct rsnd_mod_ops rsnd_ssi_pio_ops = {
|
2018-10-30 15:46:05 +08:00
|
|
|
.name = SSI_NAME,
|
|
|
|
.probe = rsnd_ssi_common_probe,
|
|
|
|
.remove = rsnd_ssi_common_remove,
|
|
|
|
.init = rsnd_ssi_pio_init,
|
|
|
|
.quit = rsnd_ssi_quit,
|
|
|
|
.start = rsnd_ssi_start,
|
|
|
|
.stop = rsnd_ssi_stop,
|
|
|
|
.irq = rsnd_ssi_irq,
|
|
|
|
.pointer = rsnd_ssi_pio_pointer,
|
|
|
|
.pcm_new = rsnd_ssi_pcm_new,
|
|
|
|
.hw_params = rsnd_ssi_hw_params,
|
|
|
|
.prepare = rsnd_ssi_prepare,
|
|
|
|
.get_status = rsnd_ssi_get_status,
|
2013-07-22 12:36:57 +08:00
|
|
|
};
|
|
|
|
|
2014-03-04 12:50:49 +08:00
|
|
|
static int rsnd_ssi_dma_probe(struct rsnd_mod *mod,
|
2015-06-15 14:25:20 +08:00
|
|
|
struct rsnd_dai_stream *io,
|
2015-01-15 16:07:47 +08:00
|
|
|
struct rsnd_priv *priv)
|
2014-03-04 12:50:49 +08:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
2015-12-17 11:00:10 +08:00
|
|
|
/*
|
|
|
|
* SSIP/SSIU/IRQ/DMA are not needed on
|
|
|
|
* SSI Multi slaves
|
|
|
|
*/
|
|
|
|
if (rsnd_ssi_is_multi_slave(mod, io))
|
|
|
|
return 0;
|
|
|
|
|
2015-10-26 16:43:41 +08:00
|
|
|
ret = rsnd_ssi_common_probe(mod, io, priv);
|
2014-11-27 16:07:47 +08:00
|
|
|
if (ret)
|
2015-03-26 12:02:32 +08:00
|
|
|
return ret;
|
2014-11-27 16:07:47 +08:00
|
|
|
|
2016-01-21 09:58:33 +08:00
|
|
|
/* SSI probe might be called many times in MUX multi path */
|
2018-09-03 15:07:07 +08:00
|
|
|
ret = rsnd_dma_attach(io, mod, &io->dma);
|
2014-05-23 14:25:43 +08:00
|
|
|
|
2014-03-04 12:50:49 +08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-11-27 16:02:43 +08:00
|
|
|
static int rsnd_ssi_fallback(struct rsnd_mod *mod,
|
2015-06-15 14:25:20 +08:00
|
|
|
struct rsnd_dai_stream *io,
|
2015-01-15 16:07:47 +08:00
|
|
|
struct rsnd_priv *priv)
|
2014-03-04 12:50:49 +08:00
|
|
|
{
|
2014-11-10 12:00:58 +08:00
|
|
|
struct device *dev = rsnd_priv_to_dev(priv);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* fallback to PIO
|
|
|
|
*
|
|
|
|
* SSI .probe might be called again.
|
|
|
|
* see
|
|
|
|
* rsnd_rdai_continuance_probe()
|
|
|
|
*/
|
|
|
|
mod->ops = &rsnd_ssi_pio_ops;
|
|
|
|
|
ASoC: rsnd: rsnd_mod_name() handles both name and ID
Current rsnd driver is using "%s[%d]" for mod name and ID,
but, this ID portion might confusable.
For example currently, CTU ID is 0 to 7, but using 00 to 13
(= 00, 01, 02, 03, 10, 11, 12, 13) is very best matching to datasheet.
In the future, we will support BUSIFn, but it will be more complicated
numbering. To avoid future confusable code, this patch modify
rsnd_mod_name() to return understandable name.
To avoid using pointless memory, it uses static char and snprintf,
thus, rsnd_mod_name() user should use it immediately, and shouldn't keep
its pointer.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2018-10-30 15:47:50 +08:00
|
|
|
dev_info(dev, "%s fallback to PIO mode\n", rsnd_mod_name(mod));
|
2014-11-10 12:00:58 +08:00
|
|
|
|
2014-03-04 12:50:49 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-06-15 14:26:25 +08:00
|
|
|
static struct dma_chan *rsnd_ssi_dma_req(struct rsnd_dai_stream *io,
|
|
|
|
struct rsnd_mod *mod)
|
2014-06-23 08:56:23 +08:00
|
|
|
{
|
ASoC: rsnd: 1st DMAC dma-names cares subnode
Renesas R-Car sound (= rsnd) needs 2 DMAC which are called as
Audio DMAC (= 1st DMAC) and Audio DMAC peri peri (2nd DMAC).
And rsnd had assumed that 1st / 2nd DMACs are implemented as DMAEngine.
But, in result of DMA ML discussion, 2nd DMAC was concluded that it is
not a general purpose DMAC (2nd DMAC is for Device to Device inside
sound system). Additionally, current DMAEngine can't support Device to
Device, and we don't have correct DT bindings for it at this point.
So the easiest solution for it is that move it from DMAEngine to rsnd
driver.
dma-names on DT was implemented as no difference between 1st / 2nd
DMAC's, since rsnd had assumed that both DMACs are implemented as
DMAEngine. That style was "src_dst". But now, 2nd DMAC was implemented
as non DMAEngine, and it doesn't need dma-names anymore. So, this
dma-names rule is no longer needed.
And additionally, dma-names was assumed that it has all
(= SSI/SSIU/SRC/DVC) nodes under sound node.
In upstream code, no SoC/platform is supporting DMA for rsnd driver yet.
This means there is no compatible issue if this patch changes
dma-names's rule of DT.
This patch assumes dma-names for 1st DMAC are tx/rx base, and listed
in each SSI/SRC/DVC subnode
ex)
rcar_sound,dvc {
dvc0: dvc@0 {
dmas = <&audma0 0xbc>;
dma-names = "tx";
};
...
rcar_sound,src {
src0: src@0 {
...
dmas = <&audma0 0x85>, <&audma1 0x9a>;
dma-names = "rx", "tx";
};
...
rcar_sound,ssi {
ssi0: ssi@0 {
...
dmas = <&audma0 0x01>, <&audma1 0x02>, <&audma0 0x15>, <&audma1 0x16>;
dma-names = "rx", "tx", "rxu", "txu";
};
...
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2015-02-20 18:31:23 +08:00
|
|
|
struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
|
|
|
|
int is_play = rsnd_io_is_play(io);
|
|
|
|
char *name;
|
|
|
|
|
ASoC: rsnd: add SSIU BUSIF support
Gen2 has BUSIF0-3, Gen3 has BUSIF0-7 on some SSIU.
Current driver is assuming it is using BUSIF0 as default.
Thus, SSI is attaching SSIU (with BUSIF0) by using rsnd_ssiu_attach().
But, TDM split mode also needs other BUSIF to use it.
This patch adds missing SSIU BUSIFx support.
BUSIF is handled by SSIU instead of SSI anymore.
Thus, its settings no longer needed on SSI node on DT.
This patch removes its settings from Document, but driver is still
keeping compatibility. Thus, old DT style is still working.
But, to avoid confusing, it doesn't indicate old compatibility things on
Document. New SoC should have SSIU on DT from this patch.
1) old style DT is still supported (= no rcar_sound,ssiu node on DT)
2) If ssiu is not indicated on playback/capture,
BUSIF0 will be used as default
playback = <&ssi3>; /* ssiu30 will be selected */
3) you can select own ssiu
playback = <&ssi32 &ssi3>; /* ssiu32 will be selected */
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2018-11-06 13:21:08 +08:00
|
|
|
/*
|
|
|
|
* It should use "rcar_sound,ssiu" on DT.
|
|
|
|
* But, we need to keep compatibility for old version.
|
|
|
|
*
|
|
|
|
* If it has "rcar_sound.ssiu", it will be used.
|
|
|
|
* If not, "rcar_sound.ssi" will be used.
|
|
|
|
* see
|
|
|
|
* rsnd_ssiu_dma_req()
|
|
|
|
* rsnd_dma_of_path()
|
|
|
|
*/
|
|
|
|
|
2015-10-22 11:15:46 +08:00
|
|
|
if (rsnd_ssi_use_busif(io))
|
ASoC: rsnd: 1st DMAC dma-names cares subnode
Renesas R-Car sound (= rsnd) needs 2 DMAC which are called as
Audio DMAC (= 1st DMAC) and Audio DMAC peri peri (2nd DMAC).
And rsnd had assumed that 1st / 2nd DMACs are implemented as DMAEngine.
But, in result of DMA ML discussion, 2nd DMAC was concluded that it is
not a general purpose DMAC (2nd DMAC is for Device to Device inside
sound system). Additionally, current DMAEngine can't support Device to
Device, and we don't have correct DT bindings for it at this point.
So the easiest solution for it is that move it from DMAEngine to rsnd
driver.
dma-names on DT was implemented as no difference between 1st / 2nd
DMAC's, since rsnd had assumed that both DMACs are implemented as
DMAEngine. That style was "src_dst". But now, 2nd DMAC was implemented
as non DMAEngine, and it doesn't need dma-names anymore. So, this
dma-names rule is no longer needed.
And additionally, dma-names was assumed that it has all
(= SSI/SSIU/SRC/DVC) nodes under sound node.
In upstream code, no SoC/platform is supporting DMA for rsnd driver yet.
This means there is no compatible issue if this patch changes
dma-names's rule of DT.
This patch assumes dma-names for 1st DMAC are tx/rx base, and listed
in each SSI/SRC/DVC subnode
ex)
rcar_sound,dvc {
dvc0: dvc@0 {
dmas = <&audma0 0xbc>;
dma-names = "tx";
};
...
rcar_sound,src {
src0: src@0 {
...
dmas = <&audma0 0x85>, <&audma1 0x9a>;
dma-names = "rx", "tx";
};
...
rcar_sound,ssi {
ssi0: ssi@0 {
...
dmas = <&audma0 0x01>, <&audma1 0x02>, <&audma0 0x15>, <&audma1 0x16>;
dma-names = "rx", "tx", "rxu", "txu";
};
...
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2015-02-20 18:31:23 +08:00
|
|
|
name = is_play ? "rxu" : "txu";
|
|
|
|
else
|
|
|
|
name = is_play ? "rx" : "tx";
|
|
|
|
|
|
|
|
return rsnd_dma_request_channel(rsnd_ssi_of_node(priv),
|
|
|
|
mod, name);
|
2014-06-23 08:56:23 +08:00
|
|
|
}
|
|
|
|
|
2013-07-29 09:59:02 +08:00
|
|
|
static struct rsnd_mod_ops rsnd_ssi_dma_ops = {
|
2018-10-30 15:46:05 +08:00
|
|
|
.name = SSI_NAME,
|
|
|
|
.dma_req = rsnd_ssi_dma_req,
|
|
|
|
.probe = rsnd_ssi_dma_probe,
|
|
|
|
.remove = rsnd_ssi_common_remove,
|
|
|
|
.init = rsnd_ssi_init,
|
|
|
|
.quit = rsnd_ssi_quit,
|
|
|
|
.start = rsnd_ssi_start,
|
|
|
|
.stop = rsnd_ssi_stop,
|
|
|
|
.irq = rsnd_ssi_irq,
|
|
|
|
.pcm_new = rsnd_ssi_pcm_new,
|
|
|
|
.fallback = rsnd_ssi_fallback,
|
|
|
|
.hw_params = rsnd_ssi_hw_params,
|
|
|
|
.prepare = rsnd_ssi_prepare,
|
|
|
|
.get_status = rsnd_ssi_get_status,
|
2013-07-29 09:59:02 +08:00
|
|
|
};
|
|
|
|
|
2018-11-21 16:15:30 +08:00
|
|
|
static int rsnd_ssi_is_dma_mode(struct rsnd_mod *mod)
|
2014-11-27 16:05:01 +08:00
|
|
|
{
|
|
|
|
return mod->ops == &rsnd_ssi_dma_ops;
|
|
|
|
}
|
|
|
|
|
2013-07-22 12:36:57 +08:00
|
|
|
/*
|
|
|
|
* ssi mod function
|
|
|
|
*/
|
2015-12-17 11:00:10 +08:00
|
|
|
static void rsnd_ssi_connect(struct rsnd_mod *mod,
|
|
|
|
struct rsnd_dai_stream *io)
|
|
|
|
{
|
|
|
|
struct rsnd_dai *rdai = rsnd_io_to_rdai(io);
|
|
|
|
enum rsnd_mod_type types[] = {
|
|
|
|
RSND_MOD_SSI,
|
|
|
|
RSND_MOD_SSIM1,
|
|
|
|
RSND_MOD_SSIM2,
|
|
|
|
RSND_MOD_SSIM3,
|
|
|
|
};
|
|
|
|
enum rsnd_mod_type type;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* try SSI -> SSIM1 -> SSIM2 -> SSIM3 */
|
|
|
|
for (i = 0; i < ARRAY_SIZE(types); i++) {
|
|
|
|
type = types[i];
|
|
|
|
if (!rsnd_io_to_mod(io, type)) {
|
|
|
|
rsnd_dai_connect(mod, io, type);
|
2017-06-15 08:49:27 +08:00
|
|
|
rsnd_rdai_channels_set(rdai, (i + 1) * 2);
|
|
|
|
rsnd_rdai_ssi_lane_set(rdai, (i + 1));
|
2015-12-17 11:00:10 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void rsnd_parse_connect_ssi(struct rsnd_dai *rdai,
|
|
|
|
struct device_node *playback,
|
|
|
|
struct device_node *capture)
|
|
|
|
{
|
|
|
|
struct rsnd_priv *priv = rsnd_rdai_to_priv(rdai);
|
|
|
|
struct device_node *node;
|
|
|
|
struct device_node *np;
|
|
|
|
struct rsnd_mod *mod;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
node = rsnd_ssi_of_node(priv);
|
|
|
|
if (!node)
|
|
|
|
return;
|
|
|
|
|
|
|
|
i = 0;
|
|
|
|
for_each_child_of_node(node, np) {
|
|
|
|
mod = rsnd_ssi_mod_get(priv, i);
|
|
|
|
if (np == playback)
|
|
|
|
rsnd_ssi_connect(mod, &rdai->playback);
|
|
|
|
if (np == capture)
|
|
|
|
rsnd_ssi_connect(mod, &rdai->capture);
|
|
|
|
i++;
|
|
|
|
}
|
|
|
|
|
|
|
|
of_node_put(node);
|
|
|
|
}
|
|
|
|
|
2013-07-22 12:36:57 +08:00
|
|
|
struct rsnd_mod *rsnd_ssi_mod_get(struct rsnd_priv *priv, int id)
|
|
|
|
{
|
2013-11-06 01:40:05 +08:00
|
|
|
if (WARN_ON(id < 0 || id >= rsnd_ssi_nr(priv)))
|
|
|
|
id = 0;
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2015-11-10 13:11:35 +08:00
|
|
|
return rsnd_mod_get(rsnd_ssi_get(priv, id));
|
2013-07-22 12:36:57 +08:00
|
|
|
}
|
|
|
|
|
2015-10-22 11:15:46 +08:00
|
|
|
int __rsnd_ssi_is_pin_sharing(struct rsnd_mod *mod)
|
2014-01-24 10:39:32 +08:00
|
|
|
{
|
2018-06-12 13:52:00 +08:00
|
|
|
if (!mod)
|
|
|
|
return 0;
|
2014-01-24 10:39:32 +08:00
|
|
|
|
2018-06-12 13:52:00 +08:00
|
|
|
return !!(rsnd_flags_has(rsnd_mod_to_ssi(mod), RSND_SSI_CLK_PIN_SHARE));
|
2014-01-24 10:39:32 +08:00
|
|
|
}
|
|
|
|
|
2015-11-10 13:14:12 +08:00
|
|
|
int rsnd_ssi_probe(struct rsnd_priv *priv)
|
2013-07-22 12:36:57 +08:00
|
|
|
{
|
2015-11-10 13:11:35 +08:00
|
|
|
struct device_node *node;
|
|
|
|
struct device_node *np;
|
2013-07-22 12:36:57 +08:00
|
|
|
struct device *dev = rsnd_priv_to_dev(priv);
|
|
|
|
struct rsnd_mod_ops *ops;
|
|
|
|
struct clk *clk;
|
|
|
|
struct rsnd_ssi *ssi;
|
|
|
|
char name[RSND_SSI_NAME_SIZE];
|
2015-03-26 12:02:09 +08:00
|
|
|
int i, nr, ret;
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2015-11-10 13:11:35 +08:00
|
|
|
node = rsnd_ssi_of_node(priv);
|
|
|
|
if (!node)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
nr = of_get_child_count(node);
|
|
|
|
if (!nr) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto rsnd_ssi_probe_done;
|
|
|
|
}
|
2014-03-18 10:29:55 +08:00
|
|
|
|
treewide: devm_kzalloc() -> devm_kcalloc()
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:
devm_kzalloc(handle, a * b, gfp)
with:
devm_kcalloc(handle, a * b, gfp)
as well as handling cases of:
devm_kzalloc(handle, a * b * c, gfp)
with:
devm_kzalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kcalloc(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kzalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 05:07:58 +08:00
|
|
|
ssi = devm_kcalloc(dev, nr, sizeof(*ssi), GFP_KERNEL);
|
2015-11-10 13:11:35 +08:00
|
|
|
if (!ssi) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto rsnd_ssi_probe_done;
|
|
|
|
}
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2014-01-24 10:39:40 +08:00
|
|
|
priv->ssi = ssi;
|
|
|
|
priv->ssi_nr = nr;
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2015-11-10 13:11:35 +08:00
|
|
|
i = 0;
|
|
|
|
for_each_child_of_node(node, np) {
|
2017-10-02 15:37:32 +08:00
|
|
|
if (!of_device_is_available(np))
|
|
|
|
goto skip;
|
|
|
|
|
2015-11-10 13:11:35 +08:00
|
|
|
ssi = rsnd_ssi_get(priv, i);
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2014-05-23 14:25:43 +08:00
|
|
|
snprintf(name, RSND_SSI_NAME_SIZE, "%s.%d",
|
|
|
|
SSI_NAME, i);
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2013-12-04 14:09:33 +08:00
|
|
|
clk = devm_clk_get(dev, name);
|
2015-11-10 13:11:35 +08:00
|
|
|
if (IS_ERR(clk)) {
|
|
|
|
ret = PTR_ERR(clk);
|
2017-07-15 15:19:07 +08:00
|
|
|
of_node_put(np);
|
2015-11-10 13:11:35 +08:00
|
|
|
goto rsnd_ssi_probe_done;
|
|
|
|
}
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2015-11-10 13:11:35 +08:00
|
|
|
if (of_get_property(np, "shared-pin", NULL))
|
2017-10-02 07:47:50 +08:00
|
|
|
rsnd_flags_set(ssi, RSND_SSI_CLK_PIN_SHARE);
|
2015-11-10 13:11:35 +08:00
|
|
|
|
|
|
|
if (of_get_property(np, "no-busif", NULL))
|
2017-10-02 07:47:50 +08:00
|
|
|
rsnd_flags_set(ssi, RSND_SSI_NO_BUSIF);
|
2015-11-10 13:11:35 +08:00
|
|
|
|
|
|
|
ssi->irq = irq_of_parse_and_map(np, 0);
|
|
|
|
if (!ssi->irq) {
|
|
|
|
ret = -EINVAL;
|
2017-07-15 15:19:07 +08:00
|
|
|
of_node_put(np);
|
2015-11-10 13:11:35 +08:00
|
|
|
goto rsnd_ssi_probe_done;
|
|
|
|
}
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2016-08-05 16:56:51 +08:00
|
|
|
if (of_property_read_bool(np, "pio-transfer"))
|
2014-03-04 12:50:49 +08:00
|
|
|
ops = &rsnd_ssi_pio_ops;
|
2015-11-10 13:11:35 +08:00
|
|
|
else
|
|
|
|
ops = &rsnd_ssi_dma_ops;
|
2013-07-22 12:36:57 +08:00
|
|
|
|
2015-09-10 15:02:21 +08:00
|
|
|
ret = rsnd_mod_init(priv, rsnd_mod_get(ssi), ops, clk,
|
2018-10-30 15:46:05 +08:00
|
|
|
RSND_MOD_SSI, i);
|
2017-07-15 15:19:07 +08:00
|
|
|
if (ret) {
|
|
|
|
of_node_put(np);
|
2015-11-10 13:11:35 +08:00
|
|
|
goto rsnd_ssi_probe_done;
|
2017-07-15 15:19:07 +08:00
|
|
|
}
|
2017-10-02 15:37:32 +08:00
|
|
|
skip:
|
2015-11-10 13:11:35 +08:00
|
|
|
i++;
|
2013-07-22 12:36:57 +08:00
|
|
|
}
|
|
|
|
|
2015-11-10 13:11:35 +08:00
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
rsnd_ssi_probe_done:
|
|
|
|
of_node_put(node);
|
|
|
|
|
|
|
|
return ret;
|
2013-07-22 12:36:57 +08:00
|
|
|
}
|
2015-03-26 12:02:09 +08:00
|
|
|
|
2015-11-10 13:14:12 +08:00
|
|
|
void rsnd_ssi_remove(struct rsnd_priv *priv)
|
2015-03-26 12:02:09 +08:00
|
|
|
{
|
|
|
|
struct rsnd_ssi *ssi;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for_each_rsnd_ssi(ssi, priv, i) {
|
2015-09-10 15:02:21 +08:00
|
|
|
rsnd_mod_quit(rsnd_mod_get(ssi));
|
2015-03-26 12:02:09 +08:00
|
|
|
}
|
|
|
|
}
|