2006-09-21 02:36:48 +08:00
|
|
|
/* Copyright (c) 2006 Coraid, Inc. See COPYING for GPL terms. */
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* aoeblk.c
|
|
|
|
* block device routines
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/hdreg.h>
|
|
|
|
#include <linux/blkdev.h>
|
2007-12-11 07:49:13 +08:00
|
|
|
#include <linux/backing-dev.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
#include <linux/fs.h>
|
|
|
|
#include <linux/ioctl.h>
|
|
|
|
#include <linux/genhd.h>
|
|
|
|
#include <linux/netdevice.h>
|
|
|
|
#include "aoe.h"
|
|
|
|
|
2006-12-07 12:33:20 +08:00
|
|
|
static struct kmem_cache *buf_pool_cache;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2007-05-22 04:08:01 +08:00
|
|
|
static ssize_t aoedisk_show_state(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *page)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2007-05-22 04:08:01 +08:00
|
|
|
struct gendisk *disk = dev_to_disk(dev);
|
2005-04-17 06:20:36 +08:00
|
|
|
struct aoedev *d = disk->private_data;
|
|
|
|
|
|
|
|
return snprintf(page, PAGE_SIZE,
|
|
|
|
"%s%s\n",
|
|
|
|
(d->flags & DEVFL_UP) ? "up" : "down",
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 20:20:00 +08:00
|
|
|
(d->flags & DEVFL_KICKME) ? ",kickme" :
|
2006-01-20 02:46:19 +08:00
|
|
|
(d->nopen && !(d->flags & DEVFL_UP)) ? ",closewait" : "");
|
|
|
|
/* I'd rather see nopen exported so we can ditch closewait */
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2007-05-22 04:08:01 +08:00
|
|
|
static ssize_t aoedisk_show_mac(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *page)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2007-05-22 04:08:01 +08:00
|
|
|
struct gendisk *disk = dev_to_disk(dev);
|
2005-04-17 06:20:36 +08:00
|
|
|
struct aoedev *d = disk->private_data;
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 20:20:00 +08:00
|
|
|
struct aoetgt *t = d->targets[0];
|
2005-04-17 06:20:36 +08:00
|
|
|
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 20:20:00 +08:00
|
|
|
if (t == NULL)
|
|
|
|
return snprintf(page, PAGE_SIZE, "none\n");
|
2008-02-08 20:20:01 +08:00
|
|
|
return snprintf(page, PAGE_SIZE, "%012llx\n", mac_addr(t->addr));
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2007-05-22 04:08:01 +08:00
|
|
|
static ssize_t aoedisk_show_netif(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *page)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2007-05-22 04:08:01 +08:00
|
|
|
struct gendisk *disk = dev_to_disk(dev);
|
2005-04-17 06:20:36 +08:00
|
|
|
struct aoedev *d = disk->private_data;
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 20:20:00 +08:00
|
|
|
struct net_device *nds[8], **nd, **nnd, **ne;
|
|
|
|
struct aoetgt **t, **te;
|
|
|
|
struct aoeif *ifp, *e;
|
|
|
|
char *p;
|
|
|
|
|
|
|
|
memset(nds, 0, sizeof nds);
|
|
|
|
nd = nds;
|
|
|
|
ne = nd + ARRAY_SIZE(nds);
|
|
|
|
t = d->targets;
|
|
|
|
te = t + NTARGETS;
|
|
|
|
for (; t < te && *t; t++) {
|
|
|
|
ifp = (*t)->ifs;
|
|
|
|
e = ifp + NAOEIFS;
|
|
|
|
for (; ifp < e && ifp->nd; ifp++) {
|
|
|
|
for (nnd = nds; nnd < nd; nnd++)
|
|
|
|
if (*nnd == ifp->nd)
|
|
|
|
break;
|
|
|
|
if (nnd == nd && nd != ne)
|
|
|
|
*nd++ = ifp->nd;
|
|
|
|
}
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 20:20:00 +08:00
|
|
|
ne = nd;
|
|
|
|
nd = nds;
|
|
|
|
if (*nd == NULL)
|
|
|
|
return snprintf(page, PAGE_SIZE, "none\n");
|
|
|
|
for (p = page; nd < ne; nd++)
|
|
|
|
p += snprintf(p, PAGE_SIZE - (p-page), "%s%s",
|
|
|
|
p == page ? "" : ",", (*nd)->name);
|
|
|
|
p += snprintf(p, PAGE_SIZE - (p-page), "\n");
|
|
|
|
return p-page;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2005-04-29 22:24:25 +08:00
|
|
|
/* firmware version */
|
2007-05-22 04:08:01 +08:00
|
|
|
static ssize_t aoedisk_show_fwver(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *page)
|
2005-04-29 22:24:25 +08:00
|
|
|
{
|
2007-05-22 04:08:01 +08:00
|
|
|
struct gendisk *disk = dev_to_disk(dev);
|
2005-04-29 22:24:25 +08:00
|
|
|
struct aoedev *d = disk->private_data;
|
|
|
|
|
|
|
|
return snprintf(page, PAGE_SIZE, "0x%04x\n", (unsigned int) d->fw_ver);
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2007-05-22 04:08:01 +08:00
|
|
|
static DEVICE_ATTR(state, S_IRUGO, aoedisk_show_state, NULL);
|
|
|
|
static DEVICE_ATTR(mac, S_IRUGO, aoedisk_show_mac, NULL);
|
|
|
|
static DEVICE_ATTR(netif, S_IRUGO, aoedisk_show_netif, NULL);
|
|
|
|
static struct device_attribute dev_attr_firmware_version = {
|
|
|
|
.attr = { .name = "firmware-version", .mode = S_IRUGO, .owner = THIS_MODULE },
|
|
|
|
.show = aoedisk_show_fwver,
|
2005-04-29 22:24:25 +08:00
|
|
|
};
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2002-04-10 03:14:34 +08:00
|
|
|
static struct attribute *aoe_attrs[] = {
|
2007-05-22 04:08:01 +08:00
|
|
|
&dev_attr_state.attr,
|
|
|
|
&dev_attr_mac.attr,
|
|
|
|
&dev_attr_netif.attr,
|
|
|
|
&dev_attr_firmware_version.attr,
|
|
|
|
NULL,
|
2002-04-10 03:14:34 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct attribute_group attr_group = {
|
|
|
|
.attrs = aoe_attrs,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int
|
2005-04-17 06:20:36 +08:00
|
|
|
aoedisk_add_sysfs(struct aoedev *d)
|
|
|
|
{
|
2007-05-22 04:08:01 +08:00
|
|
|
return sysfs_create_group(&d->gd->dev.kobj, &attr_group);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
void
|
|
|
|
aoedisk_rm_sysfs(struct aoedev *d)
|
|
|
|
{
|
2007-05-22 04:08:01 +08:00
|
|
|
sysfs_remove_group(&d->gd->dev.kobj, &attr_group);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
aoeblk_open(struct inode *inode, struct file *filp)
|
|
|
|
{
|
|
|
|
struct aoedev *d;
|
|
|
|
ulong flags;
|
|
|
|
|
|
|
|
d = inode->i_bdev->bd_disk->private_data;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
|
|
|
if (d->flags & DEVFL_UP) {
|
|
|
|
d->nopen++;
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
aoeblk_release(struct inode *inode, struct file *filp)
|
|
|
|
{
|
|
|
|
struct aoedev *d;
|
|
|
|
ulong flags;
|
|
|
|
|
|
|
|
d = inode->i_bdev->bd_disk->private_data;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
|
|
|
|
2006-01-20 02:46:27 +08:00
|
|
|
if (--d->nopen == 0) {
|
2005-04-17 06:20:36 +08:00
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
aoecmd_cfg(d->aoemajor, d->aoeminor);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2007-07-24 15:28:11 +08:00
|
|
|
aoeblk_make_request(struct request_queue *q, struct bio *bio)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct aoedev *d;
|
|
|
|
struct buf *buf;
|
|
|
|
struct sk_buff *sl;
|
|
|
|
ulong flags;
|
|
|
|
|
|
|
|
blk_queue_bounce(q, &bio);
|
|
|
|
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 20:20:00 +08:00
|
|
|
if (bio == NULL) {
|
|
|
|
printk(KERN_ERR "aoe: bio is NULL\n");
|
|
|
|
BUG();
|
|
|
|
return 0;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
d = bio->bi_bdev->bd_disk->private_data;
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 20:20:00 +08:00
|
|
|
if (d == NULL) {
|
|
|
|
printk(KERN_ERR "aoe: bd_disk->private_data is NULL\n");
|
|
|
|
BUG();
|
|
|
|
bio_endio(bio, -ENXIO);
|
|
|
|
return 0;
|
|
|
|
} else if (bio->bi_io_vec == NULL) {
|
|
|
|
printk(KERN_ERR "aoe: bi_io_vec is NULL\n");
|
|
|
|
BUG();
|
|
|
|
bio_endio(bio, -ENXIO);
|
|
|
|
return 0;
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
buf = mempool_alloc(d->bufpool, GFP_NOIO);
|
|
|
|
if (buf == NULL) {
|
2006-09-21 02:36:51 +08:00
|
|
|
printk(KERN_INFO "aoe: buf allocation failure\n");
|
2007-09-27 18:47:43 +08:00
|
|
|
bio_endio(bio, -ENOMEM);
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
memset(buf, 0, sizeof(*buf));
|
|
|
|
INIT_LIST_HEAD(&buf->bufs);
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 20:20:00 +08:00
|
|
|
buf->stime = jiffies;
|
2005-04-17 06:20:36 +08:00
|
|
|
buf->bio = bio;
|
|
|
|
buf->resid = bio->bi_size;
|
|
|
|
buf->sector = bio->bi_sector;
|
2006-09-21 02:36:50 +08:00
|
|
|
buf->bv = &bio->bi_io_vec[bio->bi_idx];
|
2005-04-17 06:20:36 +08:00
|
|
|
buf->bv_resid = buf->bv->bv_len;
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 20:20:00 +08:00
|
|
|
WARN_ON(buf->bv_resid == 0);
|
|
|
|
buf->bv_off = buf->bv->bv_offset;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
|
|
|
|
|
|
|
if ((d->flags & DEVFL_UP) == 0) {
|
2006-09-21 02:36:51 +08:00
|
|
|
printk(KERN_INFO "aoe: device %ld.%ld is not up\n",
|
|
|
|
d->aoemajor, d->aoeminor);
|
2005-04-17 06:20:36 +08:00
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
mempool_free(buf, d->bufpool);
|
2007-09-27 18:47:43 +08:00
|
|
|
bio_endio(bio, -ENXIO);
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
list_add_tail(&buf->bufs, &d->bufq);
|
|
|
|
|
2006-01-20 02:46:19 +08:00
|
|
|
aoecmd_work(d);
|
2005-04-19 13:00:22 +08:00
|
|
|
sl = d->sendq_hd;
|
|
|
|
d->sendq_hd = d->sendq_tl = NULL;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
aoenet_xmit(sl);
|
2006-01-20 02:46:19 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2006-01-08 17:02:50 +08:00
|
|
|
aoeblk_getgeo(struct block_device *bdev, struct hd_geometry *geo)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2006-01-08 17:02:50 +08:00
|
|
|
struct aoedev *d = bdev->bd_disk->private_data;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
if ((d->flags & DEVFL_UP) == 0) {
|
2006-09-21 02:36:51 +08:00
|
|
|
printk(KERN_ERR "aoe: disk not up\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
2006-01-08 17:02:50 +08:00
|
|
|
geo->cylinders = d->geo.cylinders;
|
|
|
|
geo->heads = d->geo.heads;
|
|
|
|
geo->sectors = d->geo.sectors;
|
|
|
|
return 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct block_device_operations aoe_bdops = {
|
|
|
|
.open = aoeblk_open,
|
|
|
|
.release = aoeblk_release,
|
2006-01-08 17:02:50 +08:00
|
|
|
.getgeo = aoeblk_getgeo,
|
2005-04-17 06:20:36 +08:00
|
|
|
.owner = THIS_MODULE,
|
|
|
|
};
|
|
|
|
|
|
|
|
/* alloc_disk and add_disk can sleep */
|
|
|
|
void
|
|
|
|
aoeblk_gdalloc(void *vp)
|
|
|
|
{
|
|
|
|
struct aoedev *d = vp;
|
|
|
|
struct gendisk *gd;
|
|
|
|
ulong flags;
|
|
|
|
|
|
|
|
gd = alloc_disk(AOE_PARTITIONS);
|
|
|
|
if (gd == NULL) {
|
2006-09-21 02:36:51 +08:00
|
|
|
printk(KERN_ERR "aoe: cannot allocate disk structure for %ld.%ld\n",
|
2006-09-21 02:36:49 +08:00
|
|
|
d->aoemajor, d->aoeminor);
|
2007-12-11 07:49:13 +08:00
|
|
|
goto err;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2006-03-26 17:37:50 +08:00
|
|
|
d->bufpool = mempool_create_slab_pool(MIN_BUFS, buf_pool_cache);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (d->bufpool == NULL) {
|
2006-09-21 02:36:51 +08:00
|
|
|
printk(KERN_ERR "aoe: cannot allocate bufpool for %ld.%ld\n",
|
2006-09-21 02:36:49 +08:00
|
|
|
d->aoemajor, d->aoeminor);
|
2007-12-11 07:49:13 +08:00
|
|
|
goto err_disk;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
blk_queue_make_request(&d->blkq, aoeblk_make_request);
|
2007-12-11 07:49:13 +08:00
|
|
|
if (bdi_init(&d->blkq.backing_dev_info))
|
|
|
|
goto err_mempool;
|
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
2005-04-17 06:20:36 +08:00
|
|
|
gd->major = AOE_MAJOR;
|
|
|
|
gd->first_minor = d->sysminor * AOE_PARTITIONS;
|
|
|
|
gd->fops = &aoe_bdops;
|
|
|
|
gd->private_data = d;
|
|
|
|
gd->capacity = d->ssize;
|
aoe: handle multiple network paths to AoE device
A remote AoE device is something can process ATA commands and is identified by
an AoE shelf number and an AoE slot number. Such a device might have more
than one network interface, and it might be reachable by more than one local
network interface. This patch tracks the available network paths available to
each AoE device, allowing them to be used more efficiently.
Andrew Morton asked about the call to msleep_interruptible in the revalidate
function. Yes, if a signal is pending, then msleep_interruptible will not
return 0. That means we will not loop but will call aoenet_xmit with a NULL
skb, which is a noop. If the system is too low on memory or the aoe driver is
too low on frames, then the user can hit control-C to interrupt the attempt to
do a revalidate. I have added a comment to the code summarizing that.
Andrew Morton asked whether the allocation performed inside addtgt could use a
more relaxed allocation like GFP_KERNEL, but addtgt is called when the aoedev
lock has been locked with spin_lock_irqsave. It would be nice to allocate the
memory under fewer restrictions, but targets are only added when the device is
being discovered, and if the target can't be added right now, we can try again
in a minute when then next AoE config query broadcast goes out.
Andrew Morton pointed out that the "too many targets" message could be printed
for failing GFP_ATOMIC allocations. The last patch in this series makes the
messages more specific.
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 20:20:00 +08:00
|
|
|
snprintf(gd->disk_name, sizeof gd->disk_name, "etherd/e%ld.%d",
|
2005-04-17 06:20:36 +08:00
|
|
|
d->aoemajor, d->aoeminor);
|
|
|
|
|
|
|
|
gd->queue = &d->blkq;
|
|
|
|
d->gd = gd;
|
2006-01-20 02:46:19 +08:00
|
|
|
d->flags &= ~DEVFL_GDALLOC;
|
2005-04-17 06:20:36 +08:00
|
|
|
d->flags |= DEVFL_UP;
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
|
|
|
|
|
|
|
add_disk(gd);
|
|
|
|
aoedisk_add_sysfs(d);
|
2007-12-11 07:49:13 +08:00
|
|
|
return;
|
|
|
|
|
|
|
|
err_mempool:
|
|
|
|
mempool_destroy(d->bufpool);
|
|
|
|
err_disk:
|
|
|
|
put_disk(gd);
|
|
|
|
err:
|
|
|
|
spin_lock_irqsave(&d->lock, flags);
|
|
|
|
d->flags &= ~DEVFL_GDALLOC;
|
|
|
|
spin_unlock_irqrestore(&d->lock, flags);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
aoeblk_exit(void)
|
|
|
|
{
|
|
|
|
kmem_cache_destroy(buf_pool_cache);
|
|
|
|
}
|
|
|
|
|
|
|
|
int __init
|
|
|
|
aoeblk_init(void)
|
|
|
|
{
|
2007-07-20 09:11:58 +08:00
|
|
|
buf_pool_cache = kmem_cache_create("aoe_bufs",
|
2005-04-17 06:20:36 +08:00
|
|
|
sizeof(struct buf),
|
2007-07-20 09:11:58 +08:00
|
|
|
0, 0, NULL);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (buf_pool_cache == NULL)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|