2019-05-24 18:04:03 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2017-08-13 18:16:51 +08:00
|
|
|
/*
|
|
|
|
* Intel CHT Whiskey Cove PMIC I2C Master driver
|
|
|
|
* Copyright (C) 2017 Hans de Goede <hdegoede@redhat.com>
|
|
|
|
*
|
|
|
|
* Based on various non upstream patches to support the CHT Whiskey Cove PMIC:
|
|
|
|
* Copyright (C) 2011 - 2014 Intel Corporation. All rights reserved.
|
|
|
|
*/
|
|
|
|
|
2017-10-11 17:41:20 +08:00
|
|
|
#include <linux/acpi.h>
|
2017-08-13 18:16:51 +08:00
|
|
|
#include <linux/completion.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/i2c.h>
|
|
|
|
#include <linux/interrupt.h>
|
|
|
|
#include <linux/irq.h>
|
|
|
|
#include <linux/irqdomain.h>
|
|
|
|
#include <linux/mfd/intel_soc_pmic.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/platform_device.h>
|
2017-10-11 17:41:20 +08:00
|
|
|
#include <linux/power/bq24190_charger.h>
|
2017-08-13 18:16:51 +08:00
|
|
|
#include <linux/slab.h>
|
|
|
|
|
|
|
|
#define CHT_WC_I2C_CTRL 0x5e24
|
|
|
|
#define CHT_WC_I2C_CTRL_WR BIT(0)
|
|
|
|
#define CHT_WC_I2C_CTRL_RD BIT(1)
|
|
|
|
#define CHT_WC_I2C_CLIENT_ADDR 0x5e25
|
|
|
|
#define CHT_WC_I2C_REG_OFFSET 0x5e26
|
|
|
|
#define CHT_WC_I2C_WRDATA 0x5e27
|
|
|
|
#define CHT_WC_I2C_RDDATA 0x5e28
|
|
|
|
|
|
|
|
#define CHT_WC_EXTCHGRIRQ 0x6e0a
|
|
|
|
#define CHT_WC_EXTCHGRIRQ_CLIENT_IRQ BIT(0)
|
|
|
|
#define CHT_WC_EXTCHGRIRQ_WRITE_IRQ BIT(1)
|
|
|
|
#define CHT_WC_EXTCHGRIRQ_READ_IRQ BIT(2)
|
|
|
|
#define CHT_WC_EXTCHGRIRQ_NACK_IRQ BIT(3)
|
|
|
|
#define CHT_WC_EXTCHGRIRQ_ADAP_IRQMASK ((u8)GENMASK(3, 1))
|
|
|
|
#define CHT_WC_EXTCHGRIRQ_MSK 0x6e17
|
|
|
|
|
|
|
|
struct cht_wc_i2c_adap {
|
|
|
|
struct i2c_adapter adapter;
|
|
|
|
wait_queue_head_t wait;
|
|
|
|
struct irq_chip irqchip;
|
2017-08-15 04:17:24 +08:00
|
|
|
struct mutex adap_lock;
|
2017-08-13 18:16:51 +08:00
|
|
|
struct mutex irqchip_lock;
|
|
|
|
struct regmap *regmap;
|
|
|
|
struct irq_domain *irq_domain;
|
|
|
|
struct i2c_client *client;
|
|
|
|
int client_irq;
|
|
|
|
u8 irq_mask;
|
|
|
|
u8 old_irq_mask;
|
2017-08-15 04:17:25 +08:00
|
|
|
int read_data;
|
|
|
|
bool io_error;
|
2017-08-13 18:16:51 +08:00
|
|
|
bool done;
|
|
|
|
};
|
|
|
|
|
|
|
|
static irqreturn_t cht_wc_i2c_adap_thread_handler(int id, void *data)
|
|
|
|
{
|
|
|
|
struct cht_wc_i2c_adap *adap = data;
|
|
|
|
int ret, reg;
|
|
|
|
|
2017-08-15 04:17:24 +08:00
|
|
|
mutex_lock(&adap->adap_lock);
|
|
|
|
|
2017-08-13 18:16:51 +08:00
|
|
|
/* Read IRQs */
|
|
|
|
ret = regmap_read(adap->regmap, CHT_WC_EXTCHGRIRQ, ®);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(&adap->adapter.dev, "Error reading extchgrirq reg\n");
|
2017-08-15 04:17:24 +08:00
|
|
|
mutex_unlock(&adap->adap_lock);
|
2017-08-13 18:16:51 +08:00
|
|
|
return IRQ_NONE;
|
|
|
|
}
|
|
|
|
|
|
|
|
reg &= ~adap->irq_mask;
|
|
|
|
|
2017-08-15 04:17:25 +08:00
|
|
|
/* Reads must be acked after reading the received data. */
|
|
|
|
ret = regmap_read(adap->regmap, CHT_WC_I2C_RDDATA, &adap->read_data);
|
|
|
|
if (ret)
|
|
|
|
adap->io_error = true;
|
|
|
|
|
2017-08-13 18:16:51 +08:00
|
|
|
/*
|
|
|
|
* Immediately ack IRQs, so that if new IRQs arrives while we're
|
|
|
|
* handling the previous ones our irq will re-trigger when we're done.
|
|
|
|
*/
|
|
|
|
ret = regmap_write(adap->regmap, CHT_WC_EXTCHGRIRQ, reg);
|
|
|
|
if (ret)
|
|
|
|
dev_err(&adap->adapter.dev, "Error writing extchgrirq reg\n");
|
|
|
|
|
2017-08-15 04:17:24 +08:00
|
|
|
if (reg & CHT_WC_EXTCHGRIRQ_ADAP_IRQMASK) {
|
2017-08-15 04:17:25 +08:00
|
|
|
adap->io_error |= !!(reg & CHT_WC_EXTCHGRIRQ_NACK_IRQ);
|
2017-08-15 04:17:24 +08:00
|
|
|
adap->done = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
mutex_unlock(&adap->adap_lock);
|
|
|
|
|
|
|
|
if (reg & CHT_WC_EXTCHGRIRQ_ADAP_IRQMASK)
|
|
|
|
wake_up(&adap->wait);
|
|
|
|
|
2017-08-13 18:16:51 +08:00
|
|
|
/*
|
|
|
|
* Do NOT use handle_nested_irq here, the client irq handler will
|
|
|
|
* likely want to do i2c transfers and the i2c controller uses this
|
|
|
|
* interrupt handler as well, so running the client irq handler from
|
|
|
|
* this thread will cause things to lock up.
|
|
|
|
*/
|
|
|
|
if (reg & CHT_WC_EXTCHGRIRQ_CLIENT_IRQ) {
|
|
|
|
/*
|
|
|
|
* generic_handle_irq expects local IRQs to be disabled
|
|
|
|
* as normally it is called from interrupt context.
|
|
|
|
*/
|
|
|
|
local_irq_disable();
|
|
|
|
generic_handle_irq(adap->client_irq);
|
|
|
|
local_irq_enable();
|
|
|
|
}
|
|
|
|
|
|
|
|
return IRQ_HANDLED;
|
|
|
|
}
|
|
|
|
|
|
|
|
static u32 cht_wc_i2c_adap_master_func(struct i2c_adapter *adap)
|
|
|
|
{
|
|
|
|
/* This i2c adapter only supports SMBUS byte transfers */
|
|
|
|
return I2C_FUNC_SMBUS_BYTE_DATA;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int cht_wc_i2c_adap_smbus_xfer(struct i2c_adapter *_adap, u16 addr,
|
|
|
|
unsigned short flags, char read_write,
|
|
|
|
u8 command, int size,
|
|
|
|
union i2c_smbus_data *data)
|
|
|
|
{
|
|
|
|
struct cht_wc_i2c_adap *adap = i2c_get_adapdata(_adap);
|
2017-08-15 04:17:25 +08:00
|
|
|
int ret;
|
2017-08-13 18:16:51 +08:00
|
|
|
|
2017-08-15 04:17:24 +08:00
|
|
|
mutex_lock(&adap->adap_lock);
|
2017-08-15 04:17:25 +08:00
|
|
|
adap->io_error = false;
|
2017-08-13 18:16:51 +08:00
|
|
|
adap->done = false;
|
2017-08-15 04:17:24 +08:00
|
|
|
mutex_unlock(&adap->adap_lock);
|
2017-08-13 18:16:51 +08:00
|
|
|
|
|
|
|
ret = regmap_write(adap->regmap, CHT_WC_I2C_CLIENT_ADDR, addr);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
if (read_write == I2C_SMBUS_WRITE) {
|
|
|
|
ret = regmap_write(adap->regmap, CHT_WC_I2C_WRDATA, data->byte);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = regmap_write(adap->regmap, CHT_WC_I2C_REG_OFFSET, command);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
ret = regmap_write(adap->regmap, CHT_WC_I2C_CTRL,
|
|
|
|
(read_write == I2C_SMBUS_WRITE) ?
|
|
|
|
CHT_WC_I2C_CTRL_WR : CHT_WC_I2C_CTRL_RD);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2017-08-15 04:17:26 +08:00
|
|
|
ret = wait_event_timeout(adap->wait, adap->done, msecs_to_jiffies(30));
|
|
|
|
if (ret == 0) {
|
|
|
|
/*
|
|
|
|
* The CHT GPIO controller serializes all IRQs, sometimes
|
|
|
|
* causing significant delays, check status manually.
|
|
|
|
*/
|
|
|
|
cht_wc_i2c_adap_thread_handler(0, adap);
|
|
|
|
if (!adap->done)
|
|
|
|
return -ETIMEDOUT;
|
|
|
|
}
|
2017-08-13 18:16:51 +08:00
|
|
|
|
2017-08-15 04:17:24 +08:00
|
|
|
ret = 0;
|
|
|
|
mutex_lock(&adap->adap_lock);
|
2017-08-15 04:17:25 +08:00
|
|
|
if (adap->io_error)
|
2017-08-15 04:17:24 +08:00
|
|
|
ret = -EIO;
|
2017-08-15 04:17:25 +08:00
|
|
|
else if (read_write == I2C_SMBUS_READ)
|
|
|
|
data->byte = adap->read_data;
|
2017-08-15 04:17:24 +08:00
|
|
|
mutex_unlock(&adap->adap_lock);
|
2017-08-13 18:16:51 +08:00
|
|
|
|
2017-08-15 04:17:24 +08:00
|
|
|
return ret;
|
2017-08-13 18:16:51 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static const struct i2c_algorithm cht_wc_i2c_adap_algo = {
|
|
|
|
.functionality = cht_wc_i2c_adap_master_func,
|
|
|
|
.smbus_xfer = cht_wc_i2c_adap_smbus_xfer,
|
|
|
|
};
|
|
|
|
|
i2c-cht-wc: Fix lockdep warning
When the kernel is build with lockdep support and the i2c-cht-wc driver is
used, the following warning is shown:
[ 66.674334] ======================================================
[ 66.674337] WARNING: possible circular locking dependency detected
[ 66.674340] 5.3.0-rc4+ #83 Not tainted
[ 66.674342] ------------------------------------------------------
[ 66.674345] systemd-udevd/1232 is trying to acquire lock:
[ 66.674349] 00000000a74dab07 (intel_soc_pmic_chtwc:167:(&cht_wc_regmap_cfg)->lock){+.+.}, at: regmap_write+0x31/0x70
[ 66.674360]
but task is already holding lock:
[ 66.674362] 00000000d44a85b7 (i2c_register_adapter){+.+.}, at: i2c_smbus_xfer+0x49/0xf0
[ 66.674370]
which lock already depends on the new lock.
[ 66.674371]
the existing dependency chain (in reverse order) is:
[ 66.674374]
-> #1 (i2c_register_adapter){+.+.}:
[ 66.674381] rt_mutex_lock_nested+0x46/0x60
[ 66.674384] i2c_smbus_xfer+0x49/0xf0
[ 66.674387] i2c_smbus_read_byte_data+0x45/0x70
[ 66.674391] cht_wc_byte_reg_read+0x35/0x50
[ 66.674394] _regmap_read+0x63/0x1a0
[ 66.674396] _regmap_update_bits+0xa8/0xe0
[ 66.674399] regmap_update_bits_base+0x63/0xa0
[ 66.674403] regmap_irq_update_bits.isra.0+0x3b/0x50
[ 66.674406] regmap_add_irq_chip+0x592/0x7a0
[ 66.674409] devm_regmap_add_irq_chip+0x89/0xed
[ 66.674412] cht_wc_probe+0x102/0x158
[ 66.674415] i2c_device_probe+0x95/0x250
[ 66.674419] really_probe+0xf3/0x380
[ 66.674422] driver_probe_device+0x59/0xd0
[ 66.674425] device_driver_attach+0x53/0x60
[ 66.674428] __driver_attach+0x92/0x150
[ 66.674431] bus_for_each_dev+0x7d/0xc0
[ 66.674434] bus_add_driver+0x14d/0x1f0
[ 66.674437] driver_register+0x6d/0xb0
[ 66.674440] i2c_register_driver+0x45/0x80
[ 66.674445] do_one_initcall+0x60/0x2f4
[ 66.674450] kernel_init_freeable+0x20d/0x2b4
[ 66.674453] kernel_init+0xa/0x10c
[ 66.674457] ret_from_fork+0x3a/0x50
[ 66.674459]
-> #0 (intel_soc_pmic_chtwc:167:(&cht_wc_regmap_cfg)->lock){+.+.}:
[ 66.674465] __lock_acquire+0xe07/0x1930
[ 66.674468] lock_acquire+0x9d/0x1a0
[ 66.674472] __mutex_lock+0xa8/0x9a0
[ 66.674474] regmap_write+0x31/0x70
[ 66.674480] cht_wc_i2c_adap_smbus_xfer+0x72/0x240 [i2c_cht_wc]
[ 66.674483] __i2c_smbus_xfer+0x1a3/0x640
[ 66.674486] i2c_smbus_xfer+0x67/0xf0
[ 66.674489] i2c_smbus_read_byte_data+0x45/0x70
[ 66.674494] bq24190_probe+0x26b/0x410 [bq24190_charger]
[ 66.674497] i2c_device_probe+0x189/0x250
[ 66.674500] really_probe+0xf3/0x380
[ 66.674503] driver_probe_device+0x59/0xd0
[ 66.674506] device_driver_attach+0x53/0x60
[ 66.674509] __driver_attach+0x92/0x150
[ 66.674512] bus_for_each_dev+0x7d/0xc0
[ 66.674515] bus_add_driver+0x14d/0x1f0
[ 66.674518] driver_register+0x6d/0xb0
[ 66.674521] i2c_register_driver+0x45/0x80
[ 66.674524] do_one_initcall+0x60/0x2f4
[ 66.674528] do_init_module+0x5c/0x230
[ 66.674531] load_module+0x2707/0x2a20
[ 66.674534] __do_sys_init_module+0x188/0x1b0
[ 66.674537] do_syscall_64+0x5c/0xb0
[ 66.674541] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[ 66.674543]
other info that might help us debug this:
[ 66.674545] Possible unsafe locking scenario:
[ 66.674547] CPU0 CPU1
[ 66.674548] ---- ----
[ 66.674550] lock(i2c_register_adapter);
[ 66.674553] lock(intel_soc_pmic_chtwc:167:(&cht_wc_regmap_cfg)->lock);
[ 66.674556] lock(i2c_register_adapter);
[ 66.674559] lock(intel_soc_pmic_chtwc:167:(&cht_wc_regmap_cfg)->lock);
[ 66.674561]
*** DEADLOCK ***
The problem is that the CHT Whiskey Cove PMIC's builtin i2c-adapter is
itself a part of an i2c-client (the PMIC). This means that transfers done
through it take adapter->bus_lock twice, once for the parent i2c-adapter
and once for its own bus_lock. Lockdep does not like this nested locking.
To make lockdep happy in the case of busses with muxes, the i2c-core's
i2c_adapter_lock_bus function calls:
rt_mutex_lock_nested(&adapter->bus_lock, i2c_adapter_depth(adapter));
But i2c_adapter_depth only works when the direct parent of the adapter is
another adapter, as it is only meant for muxes. In this case there is an
i2c-client and MFD instantiated platform_device in the parent->child chain
between the 2 devices.
This commit overrides the default i2c_lock_operations, passing a hardcoded
depth of 1 to rt_mutex_lock_nested, making lockdep happy.
Note that if there were to be a mux attached to the i2c-wc-cht adapter,
this would break things again since the i2c-mux code expects the
root-adapter to have a locking depth of 0. But the i2c-wc-cht adapter
always has only 1 client directly attached in the form of the charger IC
paired with the CHT Whiskey Cove PMIC.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2019-08-13 18:03:01 +08:00
|
|
|
/*
|
|
|
|
* We are an i2c-adapter which itself is part of an i2c-client. This means that
|
|
|
|
* transfers done through us take adapter->bus_lock twice, once for our parent
|
|
|
|
* i2c-adapter and once to take our own bus_lock. Lockdep does not like this
|
|
|
|
* nested locking, to make lockdep happy in the case of busses with muxes, the
|
|
|
|
* i2c-core's i2c_adapter_lock_bus function calls:
|
|
|
|
* rt_mutex_lock_nested(&adapter->bus_lock, i2c_adapter_depth(adapter));
|
|
|
|
*
|
|
|
|
* But i2c_adapter_depth only works when the direct parent of the adapter is
|
|
|
|
* another adapter, as it is only meant for muxes. In our case there is an
|
|
|
|
* i2c-client and MFD instantiated platform_device in the parent->child chain
|
|
|
|
* between the 2 devices.
|
|
|
|
*
|
|
|
|
* So we override the default i2c_lock_operations and pass a hardcoded
|
|
|
|
* depth of 1 to rt_mutex_lock_nested, to make lockdep happy.
|
|
|
|
*
|
|
|
|
* Note that if there were to be a mux attached to our adapter, this would
|
|
|
|
* break things again since the i2c-mux code expects the root-adapter to have
|
|
|
|
* a locking depth of 0. But we always have only 1 client directly attached
|
|
|
|
* in the form of the Charger IC paired with the CHT Whiskey Cove PMIC.
|
|
|
|
*/
|
|
|
|
static void cht_wc_i2c_adap_lock_bus(struct i2c_adapter *adapter,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
|
|
|
rt_mutex_lock_nested(&adapter->bus_lock, 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int cht_wc_i2c_adap_trylock_bus(struct i2c_adapter *adapter,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
|
|
|
return rt_mutex_trylock(&adapter->bus_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cht_wc_i2c_adap_unlock_bus(struct i2c_adapter *adapter,
|
|
|
|
unsigned int flags)
|
|
|
|
{
|
|
|
|
rt_mutex_unlock(&adapter->bus_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct i2c_lock_operations cht_wc_i2c_adap_lock_ops = {
|
|
|
|
.lock_bus = cht_wc_i2c_adap_lock_bus,
|
|
|
|
.trylock_bus = cht_wc_i2c_adap_trylock_bus,
|
|
|
|
.unlock_bus = cht_wc_i2c_adap_unlock_bus,
|
|
|
|
};
|
|
|
|
|
2017-08-13 18:16:51 +08:00
|
|
|
/**** irqchip for the client connected to the extchgr i2c adapter ****/
|
|
|
|
static void cht_wc_i2c_irq_lock(struct irq_data *data)
|
|
|
|
{
|
|
|
|
struct cht_wc_i2c_adap *adap = irq_data_get_irq_chip_data(data);
|
|
|
|
|
|
|
|
mutex_lock(&adap->irqchip_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cht_wc_i2c_irq_sync_unlock(struct irq_data *data)
|
|
|
|
{
|
|
|
|
struct cht_wc_i2c_adap *adap = irq_data_get_irq_chip_data(data);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (adap->irq_mask != adap->old_irq_mask) {
|
|
|
|
ret = regmap_write(adap->regmap, CHT_WC_EXTCHGRIRQ_MSK,
|
|
|
|
adap->irq_mask);
|
|
|
|
if (ret == 0)
|
|
|
|
adap->old_irq_mask = adap->irq_mask;
|
|
|
|
else
|
|
|
|
dev_err(&adap->adapter.dev, "Error writing EXTCHGRIRQ_MSK\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
mutex_unlock(&adap->irqchip_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cht_wc_i2c_irq_enable(struct irq_data *data)
|
|
|
|
{
|
|
|
|
struct cht_wc_i2c_adap *adap = irq_data_get_irq_chip_data(data);
|
|
|
|
|
|
|
|
adap->irq_mask &= ~CHT_WC_EXTCHGRIRQ_CLIENT_IRQ;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void cht_wc_i2c_irq_disable(struct irq_data *data)
|
|
|
|
{
|
|
|
|
struct cht_wc_i2c_adap *adap = irq_data_get_irq_chip_data(data);
|
|
|
|
|
|
|
|
adap->irq_mask |= CHT_WC_EXTCHGRIRQ_CLIENT_IRQ;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct irq_chip cht_wc_i2c_irq_chip = {
|
|
|
|
.irq_bus_lock = cht_wc_i2c_irq_lock,
|
|
|
|
.irq_bus_sync_unlock = cht_wc_i2c_irq_sync_unlock,
|
|
|
|
.irq_disable = cht_wc_i2c_irq_disable,
|
|
|
|
.irq_enable = cht_wc_i2c_irq_enable,
|
|
|
|
.name = "cht_wc_ext_chrg_irq_chip",
|
|
|
|
};
|
|
|
|
|
2018-07-01 17:48:35 +08:00
|
|
|
static const char * const bq24190_suppliers[] = {
|
|
|
|
"tcpm-source-psy-i2c-fusb302" };
|
2017-10-11 17:41:20 +08:00
|
|
|
|
2017-08-13 18:16:51 +08:00
|
|
|
static const struct property_entry bq24190_props[] = {
|
2017-10-11 17:41:20 +08:00
|
|
|
PROPERTY_ENTRY_STRING_ARRAY("supplied-from", bq24190_suppliers),
|
2017-08-13 18:16:51 +08:00
|
|
|
PROPERTY_ENTRY_BOOL("omit-battery-class"),
|
|
|
|
PROPERTY_ENTRY_BOOL("disable-reset"),
|
|
|
|
{ }
|
|
|
|
};
|
|
|
|
|
2017-10-11 17:41:20 +08:00
|
|
|
static struct regulator_consumer_supply fusb302_consumer = {
|
|
|
|
.supply = "vbus",
|
|
|
|
/* Must match fusb302 dev_name in intel_cht_int33fe.c */
|
|
|
|
.dev_name = "i2c-fusb302",
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct regulator_init_data bq24190_vbus_init_data = {
|
|
|
|
.constraints = {
|
|
|
|
/* The name is used in intel_cht_int33fe.c do not change. */
|
|
|
|
.name = "cht_wc_usb_typec_vbus",
|
|
|
|
.valid_ops_mask = REGULATOR_CHANGE_STATUS,
|
|
|
|
},
|
|
|
|
.consumer_supplies = &fusb302_consumer,
|
|
|
|
.num_consumer_supplies = 1,
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct bq24190_platform_data bq24190_pdata = {
|
|
|
|
.regulator_init_data = &bq24190_vbus_init_data,
|
|
|
|
};
|
|
|
|
|
2017-08-13 18:16:51 +08:00
|
|
|
static int cht_wc_i2c_adap_i2c_probe(struct platform_device *pdev)
|
|
|
|
{
|
|
|
|
struct intel_soc_pmic *pmic = dev_get_drvdata(pdev->dev.parent);
|
|
|
|
struct cht_wc_i2c_adap *adap;
|
|
|
|
struct i2c_board_info board_info = {
|
|
|
|
.type = "bq24190",
|
|
|
|
.addr = 0x6b,
|
2017-10-11 17:41:20 +08:00
|
|
|
.dev_name = "bq24190",
|
2017-08-13 18:16:51 +08:00
|
|
|
.properties = bq24190_props,
|
2017-10-11 17:41:20 +08:00
|
|
|
.platform_data = &bq24190_pdata,
|
2017-08-13 18:16:51 +08:00
|
|
|
};
|
2017-08-15 04:17:25 +08:00
|
|
|
int ret, reg, irq;
|
2017-08-13 18:16:51 +08:00
|
|
|
|
|
|
|
irq = platform_get_irq(pdev, 0);
|
|
|
|
if (irq < 0) {
|
|
|
|
dev_err(&pdev->dev, "Error missing irq resource\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
adap = devm_kzalloc(&pdev->dev, sizeof(*adap), GFP_KERNEL);
|
|
|
|
if (!adap)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
init_waitqueue_head(&adap->wait);
|
2017-08-15 04:17:24 +08:00
|
|
|
mutex_init(&adap->adap_lock);
|
2017-08-13 18:16:51 +08:00
|
|
|
mutex_init(&adap->irqchip_lock);
|
|
|
|
adap->irqchip = cht_wc_i2c_irq_chip;
|
|
|
|
adap->regmap = pmic->regmap;
|
|
|
|
adap->adapter.owner = THIS_MODULE;
|
|
|
|
adap->adapter.class = I2C_CLASS_HWMON;
|
|
|
|
adap->adapter.algo = &cht_wc_i2c_adap_algo;
|
i2c-cht-wc: Fix lockdep warning
When the kernel is build with lockdep support and the i2c-cht-wc driver is
used, the following warning is shown:
[ 66.674334] ======================================================
[ 66.674337] WARNING: possible circular locking dependency detected
[ 66.674340] 5.3.0-rc4+ #83 Not tainted
[ 66.674342] ------------------------------------------------------
[ 66.674345] systemd-udevd/1232 is trying to acquire lock:
[ 66.674349] 00000000a74dab07 (intel_soc_pmic_chtwc:167:(&cht_wc_regmap_cfg)->lock){+.+.}, at: regmap_write+0x31/0x70
[ 66.674360]
but task is already holding lock:
[ 66.674362] 00000000d44a85b7 (i2c_register_adapter){+.+.}, at: i2c_smbus_xfer+0x49/0xf0
[ 66.674370]
which lock already depends on the new lock.
[ 66.674371]
the existing dependency chain (in reverse order) is:
[ 66.674374]
-> #1 (i2c_register_adapter){+.+.}:
[ 66.674381] rt_mutex_lock_nested+0x46/0x60
[ 66.674384] i2c_smbus_xfer+0x49/0xf0
[ 66.674387] i2c_smbus_read_byte_data+0x45/0x70
[ 66.674391] cht_wc_byte_reg_read+0x35/0x50
[ 66.674394] _regmap_read+0x63/0x1a0
[ 66.674396] _regmap_update_bits+0xa8/0xe0
[ 66.674399] regmap_update_bits_base+0x63/0xa0
[ 66.674403] regmap_irq_update_bits.isra.0+0x3b/0x50
[ 66.674406] regmap_add_irq_chip+0x592/0x7a0
[ 66.674409] devm_regmap_add_irq_chip+0x89/0xed
[ 66.674412] cht_wc_probe+0x102/0x158
[ 66.674415] i2c_device_probe+0x95/0x250
[ 66.674419] really_probe+0xf3/0x380
[ 66.674422] driver_probe_device+0x59/0xd0
[ 66.674425] device_driver_attach+0x53/0x60
[ 66.674428] __driver_attach+0x92/0x150
[ 66.674431] bus_for_each_dev+0x7d/0xc0
[ 66.674434] bus_add_driver+0x14d/0x1f0
[ 66.674437] driver_register+0x6d/0xb0
[ 66.674440] i2c_register_driver+0x45/0x80
[ 66.674445] do_one_initcall+0x60/0x2f4
[ 66.674450] kernel_init_freeable+0x20d/0x2b4
[ 66.674453] kernel_init+0xa/0x10c
[ 66.674457] ret_from_fork+0x3a/0x50
[ 66.674459]
-> #0 (intel_soc_pmic_chtwc:167:(&cht_wc_regmap_cfg)->lock){+.+.}:
[ 66.674465] __lock_acquire+0xe07/0x1930
[ 66.674468] lock_acquire+0x9d/0x1a0
[ 66.674472] __mutex_lock+0xa8/0x9a0
[ 66.674474] regmap_write+0x31/0x70
[ 66.674480] cht_wc_i2c_adap_smbus_xfer+0x72/0x240 [i2c_cht_wc]
[ 66.674483] __i2c_smbus_xfer+0x1a3/0x640
[ 66.674486] i2c_smbus_xfer+0x67/0xf0
[ 66.674489] i2c_smbus_read_byte_data+0x45/0x70
[ 66.674494] bq24190_probe+0x26b/0x410 [bq24190_charger]
[ 66.674497] i2c_device_probe+0x189/0x250
[ 66.674500] really_probe+0xf3/0x380
[ 66.674503] driver_probe_device+0x59/0xd0
[ 66.674506] device_driver_attach+0x53/0x60
[ 66.674509] __driver_attach+0x92/0x150
[ 66.674512] bus_for_each_dev+0x7d/0xc0
[ 66.674515] bus_add_driver+0x14d/0x1f0
[ 66.674518] driver_register+0x6d/0xb0
[ 66.674521] i2c_register_driver+0x45/0x80
[ 66.674524] do_one_initcall+0x60/0x2f4
[ 66.674528] do_init_module+0x5c/0x230
[ 66.674531] load_module+0x2707/0x2a20
[ 66.674534] __do_sys_init_module+0x188/0x1b0
[ 66.674537] do_syscall_64+0x5c/0xb0
[ 66.674541] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[ 66.674543]
other info that might help us debug this:
[ 66.674545] Possible unsafe locking scenario:
[ 66.674547] CPU0 CPU1
[ 66.674548] ---- ----
[ 66.674550] lock(i2c_register_adapter);
[ 66.674553] lock(intel_soc_pmic_chtwc:167:(&cht_wc_regmap_cfg)->lock);
[ 66.674556] lock(i2c_register_adapter);
[ 66.674559] lock(intel_soc_pmic_chtwc:167:(&cht_wc_regmap_cfg)->lock);
[ 66.674561]
*** DEADLOCK ***
The problem is that the CHT Whiskey Cove PMIC's builtin i2c-adapter is
itself a part of an i2c-client (the PMIC). This means that transfers done
through it take adapter->bus_lock twice, once for the parent i2c-adapter
and once for its own bus_lock. Lockdep does not like this nested locking.
To make lockdep happy in the case of busses with muxes, the i2c-core's
i2c_adapter_lock_bus function calls:
rt_mutex_lock_nested(&adapter->bus_lock, i2c_adapter_depth(adapter));
But i2c_adapter_depth only works when the direct parent of the adapter is
another adapter, as it is only meant for muxes. In this case there is an
i2c-client and MFD instantiated platform_device in the parent->child chain
between the 2 devices.
This commit overrides the default i2c_lock_operations, passing a hardcoded
depth of 1 to rt_mutex_lock_nested, making lockdep happy.
Note that if there were to be a mux attached to the i2c-wc-cht adapter,
this would break things again since the i2c-mux code expects the
root-adapter to have a locking depth of 0. But the i2c-wc-cht adapter
always has only 1 client directly attached in the form of the charger IC
paired with the CHT Whiskey Cove PMIC.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2019-08-13 18:03:01 +08:00
|
|
|
adap->adapter.lock_ops = &cht_wc_i2c_adap_lock_ops;
|
2017-08-13 18:16:51 +08:00
|
|
|
strlcpy(adap->adapter.name, "PMIC I2C Adapter",
|
|
|
|
sizeof(adap->adapter.name));
|
|
|
|
adap->adapter.dev.parent = &pdev->dev;
|
|
|
|
|
|
|
|
/* Clear and activate i2c-adapter interrupts, disable client IRQ */
|
|
|
|
adap->old_irq_mask = adap->irq_mask = ~CHT_WC_EXTCHGRIRQ_ADAP_IRQMASK;
|
2017-08-15 04:17:25 +08:00
|
|
|
|
|
|
|
ret = regmap_read(adap->regmap, CHT_WC_I2C_RDDATA, ®);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2017-08-13 18:16:51 +08:00
|
|
|
ret = regmap_write(adap->regmap, CHT_WC_EXTCHGRIRQ, ~adap->irq_mask);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
ret = regmap_write(adap->regmap, CHT_WC_EXTCHGRIRQ_MSK, adap->irq_mask);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
/* Alloc and register client IRQ */
|
|
|
|
adap->irq_domain = irq_domain_add_linear(pdev->dev.of_node, 1,
|
|
|
|
&irq_domain_simple_ops, NULL);
|
|
|
|
if (!adap->irq_domain)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
adap->client_irq = irq_create_mapping(adap->irq_domain, 0);
|
|
|
|
if (!adap->client_irq) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto remove_irq_domain;
|
|
|
|
}
|
|
|
|
|
|
|
|
irq_set_chip_data(adap->client_irq, adap);
|
|
|
|
irq_set_chip_and_handler(adap->client_irq, &adap->irqchip,
|
|
|
|
handle_simple_irq);
|
|
|
|
|
|
|
|
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
|
|
|
|
cht_wc_i2c_adap_thread_handler,
|
|
|
|
IRQF_ONESHOT, "PMIC I2C Adapter", adap);
|
|
|
|
if (ret)
|
|
|
|
goto remove_irq_domain;
|
|
|
|
|
|
|
|
i2c_set_adapdata(&adap->adapter, adap);
|
|
|
|
ret = i2c_add_adapter(&adap->adapter);
|
|
|
|
if (ret)
|
|
|
|
goto remove_irq_domain;
|
|
|
|
|
2017-10-11 17:41:20 +08:00
|
|
|
/*
|
|
|
|
* Normally the Whiskey Cove PMIC is paired with a TI bq24292i charger,
|
|
|
|
* connected to this i2c bus, and a max17047 fuel-gauge and a fusb302
|
|
|
|
* USB Type-C controller connected to another i2c bus. In this setup
|
|
|
|
* the max17047 and fusb302 devices are enumerated through an INT33FE
|
|
|
|
* ACPI device. If this device is present register an i2c-client for
|
|
|
|
* the TI bq24292i charger.
|
|
|
|
*/
|
|
|
|
if (acpi_dev_present("INT33FE", NULL, -1)) {
|
|
|
|
board_info.irq = adap->client_irq;
|
|
|
|
adap->client = i2c_new_device(&adap->adapter, &board_info);
|
|
|
|
if (!adap->client) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto del_adapter;
|
|
|
|
}
|
2017-08-13 18:16:51 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
platform_set_drvdata(pdev, adap);
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
del_adapter:
|
|
|
|
i2c_del_adapter(&adap->adapter);
|
|
|
|
remove_irq_domain:
|
|
|
|
irq_domain_remove(adap->irq_domain);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int cht_wc_i2c_adap_i2c_remove(struct platform_device *pdev)
|
|
|
|
{
|
|
|
|
struct cht_wc_i2c_adap *adap = platform_get_drvdata(pdev);
|
|
|
|
|
2017-10-11 17:41:20 +08:00
|
|
|
if (adap->client)
|
|
|
|
i2c_unregister_device(adap->client);
|
2017-08-13 18:16:51 +08:00
|
|
|
i2c_del_adapter(&adap->adapter);
|
|
|
|
irq_domain_remove(adap->irq_domain);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-11-28 18:25:07 +08:00
|
|
|
static const struct platform_device_id cht_wc_i2c_adap_id_table[] = {
|
2017-08-13 18:16:51 +08:00
|
|
|
{ .name = "cht_wcove_ext_chgr" },
|
|
|
|
{},
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(platform, cht_wc_i2c_adap_id_table);
|
|
|
|
|
2017-08-16 17:16:59 +08:00
|
|
|
static struct platform_driver cht_wc_i2c_adap_driver = {
|
2017-08-13 18:16:51 +08:00
|
|
|
.probe = cht_wc_i2c_adap_i2c_probe,
|
|
|
|
.remove = cht_wc_i2c_adap_i2c_remove,
|
|
|
|
.driver = {
|
|
|
|
.name = "cht_wcove_ext_chgr",
|
|
|
|
},
|
|
|
|
.id_table = cht_wc_i2c_adap_id_table,
|
|
|
|
};
|
|
|
|
module_platform_driver(cht_wc_i2c_adap_driver);
|
|
|
|
|
|
|
|
MODULE_DESCRIPTION("Intel CHT Whiskey Cove PMIC I2C Master driver");
|
|
|
|
MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
|
|
|
|
MODULE_LICENSE("GPL");
|