2007-04-30 14:30:56 +08:00
|
|
|
#ifndef _ASM_POWERPC_PGALLOC_32_H
|
|
|
|
|
#define _ASM_POWERPC_PGALLOC_32_H
|
|
|
|
|
|
|
|
|
|
#include <linux/threads.h>
|
|
|
|
|
|
2009-10-29 00:27:18 +08:00
|
|
|
/* For 32-bit, all levels of page tables are just drawn from get_free_page() */
|
|
|
|
|
#define MAX_PGTABLE_INDEX_SIZE 0
|
2008-11-19 20:50:04 +08:00
|
|
|
|
2007-04-30 14:30:56 +08:00
|
|
|
extern void __bad_pte(pmd_t *pmd);
|
|
|
|
|
|
|
|
|
|
extern pgd_t *pgd_alloc(struct mm_struct *mm);
|
2008-02-05 14:29:14 +08:00
|
|
|
extern void pgd_free(struct mm_struct *mm, pgd_t *pgd);
|
2007-04-30 14:30:56 +08:00
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* We don't have any real pmd's, and this code never triggers because
|
|
|
|
|
* the pgd will always be present..
|
|
|
|
|
*/
|
2007-05-08 10:46:49 +08:00
|
|
|
/* #define pmd_alloc_one(mm,address) ({ BUG(); ((pmd_t *)2); }) */
|
2008-02-05 14:29:14 +08:00
|
|
|
#define pmd_free(mm, x) do { } while (0)
|
mm: Pass virtual address to [__]p{te,ud,md}_free_tlb()
mm: Pass virtual address to [__]p{te,ud,md}_free_tlb()
Upcoming paches to support the new 64-bit "BookE" powerpc architecture
will need to have the virtual address corresponding to PTE page when
freeing it, due to the way the HW table walker works.
Basically, the TLB can be loaded with "large" pages that cover the whole
virtual space (well, sort-of, half of it actually) represented by a PTE
page, and which contain an "indirect" bit indicating that this TLB entry
RPN points to an array of PTEs from which the TLB can then create direct
entries. Thus, in order to invalidate those when PTE pages are deleted,
we need the virtual address to pass to tlbilx or tlbivax instructions.
The old trick of sticking it somewhere in the PTE page struct page sucks
too much, the address is almost readily available in all call sites and
almost everybody implemets these as macros, so we may as well add the
argument everywhere. I added it to the pmd and pud variants for consistency.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: David Howells <dhowells@redhat.com> [MN10300 & FRV]
Acked-by: Nick Piggin <npiggin@suse.de>
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com> [s390]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-07-22 13:44:28 +08:00
|
|
|
#define __pmd_free_tlb(tlb,x,a) do { } while (0)
|
2007-05-08 10:46:49 +08:00
|
|
|
/* #define pgd_populate(mm, pmd, pte) BUG() */
|
2007-04-30 14:30:56 +08:00
|
|
|
|
|
|
|
|
#ifndef CONFIG_BOOKE
|
|
|
|
|
#define pmd_populate_kernel(mm, pmd, pte) \
|
|
|
|
|
(pmd_val(*(pmd)) = __pa(pte) | _PMD_PRESENT)
|
|
|
|
|
#define pmd_populate(mm, pmd, pte) \
|
|
|
|
|
(pmd_val(*(pmd)) = (page_to_pfn(pte) << PAGE_SHIFT) | _PMD_PRESENT)
|
2008-02-08 20:22:04 +08:00
|
|
|
#define pmd_pgtable(pmd) pmd_page(pmd)
|
2007-04-30 14:30:56 +08:00
|
|
|
#else
|
|
|
|
|
#define pmd_populate_kernel(mm, pmd, pte) \
|
|
|
|
|
(pmd_val(*(pmd)) = (unsigned long)pte | _PMD_PRESENT)
|
|
|
|
|
#define pmd_populate(mm, pmd, pte) \
|
|
|
|
|
(pmd_val(*(pmd)) = (unsigned long)lowmem_page_address(pte) | _PMD_PRESENT)
|
2008-02-08 20:22:04 +08:00
|
|
|
#define pmd_pgtable(pmd) pmd_page(pmd)
|
2007-04-30 14:30:56 +08:00
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
extern pte_t *pte_alloc_one_kernel(struct mm_struct *mm, unsigned long addr);
|
2008-02-08 20:22:04 +08:00
|
|
|
extern pgtable_t pte_alloc_one(struct mm_struct *mm, unsigned long addr);
|
2007-04-30 14:30:56 +08:00
|
|
|
|
2013-04-28 17:37:32 +08:00
|
|
|
static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte)
|
|
|
|
|
{
|
|
|
|
|
free_page((unsigned long)pte);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static inline void pte_free(struct mm_struct *mm, pgtable_t ptepage)
|
|
|
|
|
{
|
|
|
|
|
pgtable_page_dtor(ptepage);
|
|
|
|
|
__free_page(ptepage);
|
|
|
|
|
}
|
|
|
|
|
|
2009-10-29 00:27:18 +08:00
|
|
|
static inline void pgtable_free(void *table, unsigned index_size)
|
2008-11-19 20:50:04 +08:00
|
|
|
{
|
2009-10-29 00:27:18 +08:00
|
|
|
BUG_ON(index_size); /* 32-bit doesn't use this */
|
|
|
|
|
free_page((unsigned long)table);
|
2008-11-19 20:50:04 +08:00
|
|
|
}
|
2007-04-30 14:30:56 +08:00
|
|
|
|
|
|
|
|
#define check_pgt_cache() do { } while (0)
|
|
|
|
|
|
2013-04-28 17:37:32 +08:00
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
|
static inline void pgtable_free_tlb(struct mmu_gather *tlb,
|
|
|
|
|
void *table, int shift)
|
|
|
|
|
{
|
|
|
|
|
unsigned long pgf = (unsigned long)table;
|
|
|
|
|
BUG_ON(shift > MAX_PGTABLE_INDEX_SIZE);
|
|
|
|
|
pgf |= shift;
|
|
|
|
|
tlb_remove_table(tlb, (void *)pgf);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static inline void __tlb_remove_table(void *_table)
|
|
|
|
|
{
|
|
|
|
|
void *table = (void *)((unsigned long)_table & ~MAX_PGTABLE_INDEX_SIZE);
|
|
|
|
|
unsigned shift = (unsigned long)_table & MAX_PGTABLE_INDEX_SIZE;
|
|
|
|
|
|
|
|
|
|
pgtable_free(table, shift);
|
|
|
|
|
}
|
|
|
|
|
#else
|
|
|
|
|
static inline void pgtable_free_tlb(struct mmu_gather *tlb,
|
|
|
|
|
void *table, int shift)
|
|
|
|
|
{
|
|
|
|
|
pgtable_free(table, shift);
|
|
|
|
|
}
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t table,
|
|
|
|
|
unsigned long address)
|
|
|
|
|
{
|
|
|
|
|
tlb_flush_pgtable(tlb, address);
|
powerpc: Fix PTE page address mismatch in pgtable ctor/dtor
In pte_alloc_one(), pgtable_page_ctor() is passed an address that has
not been converted by page_address() to the newly allocated PTE page.
When the PTE is freed, __pte_free_tlb() calls pgtable_page_dtor()
with an address to the PTE page that has been converted by page_address().
The mismatch in the PTE's page address causes pgtable_page_dtor() to access
invalid memory, so resources for that PTE (such as the page lock) is not
properly cleaned up.
On PPC32, only SMP kernels are affected.
On PPC64, only SMP kernels with 4K page size are affected.
This bug was introduced by commit d614bb041209fd7cb5e4b35e11a7b2f6ee8f62b8
"powerpc: Move the pte free routines from common header".
On a preempt-rt kernel, a spinlock is dynamically allocated for each
PTE in pgtable_page_ctor(). When the PTE is freed, calling
pgtable_page_dtor() with a mismatched page address causes a memory leak,
as the pointer to the PTE's spinlock is bogus.
On mainline, there isn't any immediately obvious symptoms, but the
problem still exists here.
Fixes: d614bb041209fd7c "powerpc: Move the pte free routes from common header"
Cc: Paul Mackerras <paulus@samba.org>
Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-stable <stable@vger.kernel.org> # v3.10+
Signed-off-by: Hong H. Pham <hong.pham@windriver.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2013-12-07 22:06:33 +08:00
|
|
|
pgtable_page_dtor(table);
|
|
|
|
|
pgtable_free_tlb(tlb, page_address(table), 0);
|
2013-04-28 17:37:32 +08:00
|
|
|
}
|
2007-04-30 14:30:56 +08:00
|
|
|
#endif /* _ASM_POWERPC_PGALLOC_32_H */
|