2019-06-04 16:11:33 +08:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0-only */
|
2016-12-16 18:02:56 +08:00
|
|
|
/*
|
|
|
|
*
|
|
|
|
* Copyright (C) 2011 Novell Inc.
|
|
|
|
* Copyright (C) 2016 Red Hat, Inc.
|
|
|
|
*/
|
|
|
|
|
|
|
|
struct ovl_config {
|
|
|
|
char *lowerdir;
|
|
|
|
char *upperdir;
|
|
|
|
char *workdir;
|
|
|
|
bool default_permissions;
|
2016-12-16 18:02:56 +08:00
|
|
|
bool redirect_dir;
|
2017-12-11 18:28:10 +08:00
|
|
|
bool redirect_follow;
|
|
|
|
const char *redirect_mode;
|
2017-06-21 20:28:36 +08:00
|
|
|
bool index;
|
2018-01-19 17:26:53 +08:00
|
|
|
bool nfs_export;
|
2018-03-29 14:08:18 +08:00
|
|
|
int xino;
|
2018-05-11 23:49:27 +08:00
|
|
|
bool metacopy;
|
2016-12-16 18:02:56 +08:00
|
|
|
};
|
|
|
|
|
2018-03-29 01:22:41 +08:00
|
|
|
struct ovl_sb {
|
|
|
|
struct super_block *sb;
|
|
|
|
dev_t pseudo_dev;
|
2019-11-15 04:28:41 +08:00
|
|
|
/* Unusable (conflicting) uuid */
|
|
|
|
bool bad_uuid;
|
2018-03-29 01:22:41 +08:00
|
|
|
};
|
|
|
|
|
2017-07-24 14:57:54 +08:00
|
|
|
struct ovl_layer {
|
|
|
|
struct vfsmount *mnt;
|
ovl: detect overlapping layers
Overlapping overlay layers are not supported and can cause unexpected
behavior, but overlayfs does not currently check or warn about these
configurations.
User is not supposed to specify the same directory for upper and
lower dirs or for different lower layers and user is not supposed to
specify directories that are descendants of each other for overlay
layers, but that is exactly what this zysbot repro did:
https://syzkaller.appspot.com/x/repro.syz?x=12c7a94f400000
Moving layer root directories into other layers while overlayfs
is mounted could also result in unexpected behavior.
This commit places "traps" in the overlay inode hash table.
Those traps are dummy overlay inodes that are hashed by the layers
root inodes.
On mount, the hash table trap entries are used to verify that overlay
layers are not overlapping. While at it, we also verify that overlay
layers are not overlapping with directories "in-use" by other overlay
instances as upperdir/workdir.
On lookup, the trap entries are used to verify that overlay layers
root inodes have not been moved into other layers after mount.
Some examples:
$ ./run --ov --samefs -s
...
( mkdir -p base/upper/0/u base/upper/0/w base/lower lower upper mnt
mount -o bind base/lower lower
mount -o bind base/upper upper
mount -t overlay none mnt ...
-o lowerdir=lower,upperdir=upper/0/u,workdir=upper/0/w)
$ umount mnt
$ mount -t overlay none mnt ...
-o lowerdir=base,upperdir=upper/0/u,workdir=upper/0/w
[ 94.434900] overlayfs: overlapping upperdir path
mount: mount overlay on mnt failed: Too many levels of symbolic links
$ mount -t overlay none mnt ...
-o lowerdir=upper/0/u,upperdir=upper/0/u,workdir=upper/0/w
[ 151.350132] overlayfs: conflicting lowerdir path
mount: none is already mounted or mnt busy
$ mount -t overlay none mnt ...
-o lowerdir=lower:lower/a,upperdir=upper/0/u,workdir=upper/0/w
[ 201.205045] overlayfs: overlapping lowerdir path
mount: mount overlay on mnt failed: Too many levels of symbolic links
$ mount -t overlay none mnt ...
-o lowerdir=lower,upperdir=upper/0/u,workdir=upper/0/w
$ mv base/upper/0/ base/lower/
$ find mnt/0
mnt/0
mnt/0/w
find: 'mnt/0/w/work': Too many levels of symbolic links
find: 'mnt/0/u': Too many levels of symbolic links
Reported-by: syzbot+9c69c282adc4edd2b540@syzkaller.appspotmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
2019-04-18 22:42:08 +08:00
|
|
|
/* Trap in ovl inode cache */
|
|
|
|
struct inode *trap;
|
2018-03-29 01:22:41 +08:00
|
|
|
struct ovl_sb *fs;
|
|
|
|
/* Index of this layer in fs root (upper idx == 0) */
|
2017-11-09 01:23:36 +08:00
|
|
|
int idx;
|
2018-03-29 01:22:41 +08:00
|
|
|
/* One fsid per unique underlying sb (upper fsid == 0) */
|
|
|
|
int fsid;
|
2017-07-24 14:57:54 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
struct ovl_path {
|
|
|
|
struct ovl_layer *layer;
|
|
|
|
struct dentry *dentry;
|
|
|
|
};
|
|
|
|
|
2016-12-16 18:02:56 +08:00
|
|
|
/* private information held for overlayfs's superblock */
|
|
|
|
struct ovl_fs {
|
|
|
|
struct vfsmount *upper_mnt;
|
2018-03-29 01:22:41 +08:00
|
|
|
unsigned int numlower;
|
|
|
|
/* Number of unique lower sb that differ from upper sb */
|
|
|
|
unsigned int numlowerfs;
|
2017-07-24 14:57:54 +08:00
|
|
|
struct ovl_layer *lower_layers;
|
2018-03-29 01:22:41 +08:00
|
|
|
struct ovl_sb *lower_fs;
|
2017-06-21 20:28:33 +08:00
|
|
|
/* workbasedir is the path at workdir= mount option */
|
|
|
|
struct dentry *workbasedir;
|
|
|
|
/* workdir is the 'work' directory under workbasedir */
|
2016-12-16 18:02:56 +08:00
|
|
|
struct dentry *workdir;
|
2017-06-21 20:28:36 +08:00
|
|
|
/* index directory listing overlay inodes by origin file handle */
|
|
|
|
struct dentry *indexdir;
|
2016-12-16 18:02:56 +08:00
|
|
|
long namelen;
|
2016-12-16 18:02:56 +08:00
|
|
|
/* pathnames of lower and upper dirs, for show_options */
|
|
|
|
struct ovl_config config;
|
|
|
|
/* creds of process who forced instantiation of super block */
|
|
|
|
const struct cred *creator_cred;
|
2017-01-17 12:34:53 +08:00
|
|
|
bool tmpfile;
|
2017-05-17 05:12:40 +08:00
|
|
|
bool noxattr;
|
2017-09-29 15:21:21 +08:00
|
|
|
/* Did we take the inuse lock? */
|
|
|
|
bool upperdir_locked;
|
|
|
|
bool workdir_locked;
|
ovl: detect overlapping layers
Overlapping overlay layers are not supported and can cause unexpected
behavior, but overlayfs does not currently check or warn about these
configurations.
User is not supposed to specify the same directory for upper and
lower dirs or for different lower layers and user is not supposed to
specify directories that are descendants of each other for overlay
layers, but that is exactly what this zysbot repro did:
https://syzkaller.appspot.com/x/repro.syz?x=12c7a94f400000
Moving layer root directories into other layers while overlayfs
is mounted could also result in unexpected behavior.
This commit places "traps" in the overlay inode hash table.
Those traps are dummy overlay inodes that are hashed by the layers
root inodes.
On mount, the hash table trap entries are used to verify that overlay
layers are not overlapping. While at it, we also verify that overlay
layers are not overlapping with directories "in-use" by other overlay
instances as upperdir/workdir.
On lookup, the trap entries are used to verify that overlay layers
root inodes have not been moved into other layers after mount.
Some examples:
$ ./run --ov --samefs -s
...
( mkdir -p base/upper/0/u base/upper/0/w base/lower lower upper mnt
mount -o bind base/lower lower
mount -o bind base/upper upper
mount -t overlay none mnt ...
-o lowerdir=lower,upperdir=upper/0/u,workdir=upper/0/w)
$ umount mnt
$ mount -t overlay none mnt ...
-o lowerdir=base,upperdir=upper/0/u,workdir=upper/0/w
[ 94.434900] overlayfs: overlapping upperdir path
mount: mount overlay on mnt failed: Too many levels of symbolic links
$ mount -t overlay none mnt ...
-o lowerdir=upper/0/u,upperdir=upper/0/u,workdir=upper/0/w
[ 151.350132] overlayfs: conflicting lowerdir path
mount: none is already mounted or mnt busy
$ mount -t overlay none mnt ...
-o lowerdir=lower:lower/a,upperdir=upper/0/u,workdir=upper/0/w
[ 201.205045] overlayfs: overlapping lowerdir path
mount: mount overlay on mnt failed: Too many levels of symbolic links
$ mount -t overlay none mnt ...
-o lowerdir=lower,upperdir=upper/0/u,workdir=upper/0/w
$ mv base/upper/0/ base/lower/
$ find mnt/0
mnt/0
mnt/0/w
find: 'mnt/0/w/work': Too many levels of symbolic links
find: 'mnt/0/u': Too many levels of symbolic links
Reported-by: syzbot+9c69c282adc4edd2b540@syzkaller.appspotmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
2019-04-18 22:42:08 +08:00
|
|
|
/* Traps in ovl inode cache */
|
|
|
|
struct inode *upperdir_trap;
|
2019-07-12 20:24:34 +08:00
|
|
|
struct inode *workbasedir_trap;
|
ovl: detect overlapping layers
Overlapping overlay layers are not supported and can cause unexpected
behavior, but overlayfs does not currently check or warn about these
configurations.
User is not supposed to specify the same directory for upper and
lower dirs or for different lower layers and user is not supposed to
specify directories that are descendants of each other for overlay
layers, but that is exactly what this zysbot repro did:
https://syzkaller.appspot.com/x/repro.syz?x=12c7a94f400000
Moving layer root directories into other layers while overlayfs
is mounted could also result in unexpected behavior.
This commit places "traps" in the overlay inode hash table.
Those traps are dummy overlay inodes that are hashed by the layers
root inodes.
On mount, the hash table trap entries are used to verify that overlay
layers are not overlapping. While at it, we also verify that overlay
layers are not overlapping with directories "in-use" by other overlay
instances as upperdir/workdir.
On lookup, the trap entries are used to verify that overlay layers
root inodes have not been moved into other layers after mount.
Some examples:
$ ./run --ov --samefs -s
...
( mkdir -p base/upper/0/u base/upper/0/w base/lower lower upper mnt
mount -o bind base/lower lower
mount -o bind base/upper upper
mount -t overlay none mnt ...
-o lowerdir=lower,upperdir=upper/0/u,workdir=upper/0/w)
$ umount mnt
$ mount -t overlay none mnt ...
-o lowerdir=base,upperdir=upper/0/u,workdir=upper/0/w
[ 94.434900] overlayfs: overlapping upperdir path
mount: mount overlay on mnt failed: Too many levels of symbolic links
$ mount -t overlay none mnt ...
-o lowerdir=upper/0/u,upperdir=upper/0/u,workdir=upper/0/w
[ 151.350132] overlayfs: conflicting lowerdir path
mount: none is already mounted or mnt busy
$ mount -t overlay none mnt ...
-o lowerdir=lower:lower/a,upperdir=upper/0/u,workdir=upper/0/w
[ 201.205045] overlayfs: overlapping lowerdir path
mount: mount overlay on mnt failed: Too many levels of symbolic links
$ mount -t overlay none mnt ...
-o lowerdir=lower,upperdir=upper/0/u,workdir=upper/0/w
$ mv base/upper/0/ base/lower/
$ find mnt/0
mnt/0
mnt/0/w
find: 'mnt/0/w/work': Too many levels of symbolic links
find: 'mnt/0/u': Too many levels of symbolic links
Reported-by: syzbot+9c69c282adc4edd2b540@syzkaller.appspotmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
2019-04-18 22:42:08 +08:00
|
|
|
struct inode *workdir_trap;
|
|
|
|
struct inode *indexdir_trap;
|
2017-11-07 19:55:04 +08:00
|
|
|
/* Inode numbers in all layers do not use the high xino_bits */
|
|
|
|
unsigned int xino_bits;
|
2016-12-16 18:02:56 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
/* private information held for every overlayfs dentry */
|
|
|
|
struct ovl_entry {
|
|
|
|
union {
|
2017-07-05 04:03:18 +08:00
|
|
|
struct {
|
2018-01-15 01:25:31 +08:00
|
|
|
unsigned long flags;
|
2017-07-05 04:03:18 +08:00
|
|
|
};
|
2016-12-16 18:02:56 +08:00
|
|
|
struct rcu_head rcu;
|
|
|
|
};
|
|
|
|
unsigned numlower;
|
2017-07-24 14:57:54 +08:00
|
|
|
struct ovl_path lowerstack[];
|
2016-12-16 18:02:56 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
struct ovl_entry *ovl_alloc_entry(unsigned int numlower);
|
|
|
|
|
2018-01-15 01:25:31 +08:00
|
|
|
static inline struct ovl_entry *OVL_E(struct dentry *dentry)
|
|
|
|
{
|
|
|
|
return (struct ovl_entry *) dentry->d_fsdata;
|
|
|
|
}
|
|
|
|
|
2017-06-12 14:54:40 +08:00
|
|
|
struct ovl_inode {
|
2018-05-11 23:49:30 +08:00
|
|
|
union {
|
|
|
|
struct ovl_dir_cache *cache; /* directory */
|
|
|
|
struct inode *lowerdata; /* regular file */
|
|
|
|
};
|
2017-07-05 04:03:16 +08:00
|
|
|
const char *redirect;
|
2017-07-05 04:03:16 +08:00
|
|
|
u64 version;
|
2017-07-05 04:03:16 +08:00
|
|
|
unsigned long flags;
|
2017-06-12 14:54:40 +08:00
|
|
|
struct inode vfs_inode;
|
2017-07-05 04:03:16 +08:00
|
|
|
struct dentry *__upperdentry;
|
2017-07-05 04:03:16 +08:00
|
|
|
struct inode *lower;
|
2017-06-21 20:28:51 +08:00
|
|
|
|
|
|
|
/* synchronize copy up and more */
|
|
|
|
struct mutex lock;
|
2017-06-12 14:54:40 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static inline struct ovl_inode *OVL_I(struct inode *inode)
|
|
|
|
{
|
|
|
|
return container_of(inode, struct ovl_inode, vfs_inode);
|
|
|
|
}
|
2017-07-05 04:03:16 +08:00
|
|
|
|
|
|
|
static inline struct dentry *ovl_upperdentry_dereference(struct ovl_inode *oi)
|
|
|
|
{
|
2017-10-24 18:22:48 +08:00
|
|
|
return READ_ONCE(oi->__upperdentry);
|
2017-07-05 04:03:16 +08:00
|
|
|
}
|