License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 22:07:57 +08:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2008-10-23 13:26:29 +08:00
|
|
|
#ifndef _ASM_X86_ASM_H
|
|
|
|
|
#define _ASM_X86_ASM_H
|
2008-01-30 20:30:06 +08:00
|
|
|
|
2008-06-17 07:08:17 +08:00
|
|
|
#ifdef __ASSEMBLY__
|
|
|
|
|
# define __ASM_FORM(x) x
|
2013-08-30 03:13:04 +08:00
|
|
|
# define __ASM_FORM_RAW(x) x
|
2011-07-19 20:00:45 +08:00
|
|
|
# define __ASM_FORM_COMMA(x) x,
|
2008-06-17 07:08:17 +08:00
|
|
|
#else
|
2019-09-06 21:13:48 +08:00
|
|
|
#include <linux/stringify.h>
|
|
|
|
|
|
|
|
|
|
# define __ASM_FORM(x) " " __stringify(x) " "
|
|
|
|
|
# define __ASM_FORM_RAW(x) __stringify(x)
|
|
|
|
|
# define __ASM_FORM_COMMA(x) " " __stringify(x) ","
|
2008-06-17 07:08:17 +08:00
|
|
|
#endif
|
2008-01-30 20:31:26 +08:00
|
|
|
|
x86/asm: Fix inline asm call constraints for GCC 4.4
The kernel test bot (run by Xiaolong Ye) reported that the following commit:
f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang")
is causing double faults in a kernel compiled with GCC 4.4.
Linus subsequently diagnosed the crash pattern and the buggy commit and found that
the issue is with this code:
register unsigned int __asm_call_sp asm("esp");
#define ASM_CALL_CONSTRAINT "+r" (__asm_call_sp)
Even on a 64-bit kernel, it's using ESP instead of RSP. That causes GCC
to produce the following bogus code:
ffffffff8147461d: 89 e0 mov %esp,%eax
ffffffff8147461f: 4c 89 f7 mov %r14,%rdi
ffffffff81474622: 4c 89 fe mov %r15,%rsi
ffffffff81474625: ba 20 00 00 00 mov $0x20,%edx
ffffffff8147462a: 89 c4 mov %eax,%esp
ffffffff8147462c: e8 bf 52 05 00 callq ffffffff814c98f0 <copy_user_generic_unrolled>
Despite the absurdity of it backing up and restoring the stack pointer
for no reason, the bug is actually the fact that it's only backing up
and restoring the lower 32 bits of the stack pointer. The upper 32 bits
are getting cleared out, corrupting the stack pointer.
So change the '__asm_call_sp' register variable to be associated with
the actual full-size stack pointer.
This also requires changing the __ASM_SEL() macro to be based on the
actual compiled arch size, rather than the CONFIG value, because
CONFIG_X86_64 compiles some files with '-m32' (e.g., realmode and vdso).
Otherwise Clang fails to build the kernel because it complains about the
use of a 64-bit register (RSP) in a 32-bit file.
Reported-and-Bisected-and-Tested-by: kernel test robot <xiaolong.ye@intel.com>
Diagnosed-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Dmitriy Vyukov <dvyukov@google.com>
Cc: LKP <lkp@01.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang")
Link: http://lkml.kernel.org/r/20170928215826.6sdpmwtkiydiytim@treble
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2017-09-29 05:58:26 +08:00
|
|
|
#ifndef __x86_64__
|
|
|
|
|
/* 32 bit */
|
2008-06-17 07:08:17 +08:00
|
|
|
# define __ASM_SEL(a,b) __ASM_FORM(a)
|
2013-08-30 03:13:04 +08:00
|
|
|
# define __ASM_SEL_RAW(a,b) __ASM_FORM_RAW(a)
|
2008-01-30 20:30:06 +08:00
|
|
|
#else
|
x86/asm: Fix inline asm call constraints for GCC 4.4
The kernel test bot (run by Xiaolong Ye) reported that the following commit:
f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang")
is causing double faults in a kernel compiled with GCC 4.4.
Linus subsequently diagnosed the crash pattern and the buggy commit and found that
the issue is with this code:
register unsigned int __asm_call_sp asm("esp");
#define ASM_CALL_CONSTRAINT "+r" (__asm_call_sp)
Even on a 64-bit kernel, it's using ESP instead of RSP. That causes GCC
to produce the following bogus code:
ffffffff8147461d: 89 e0 mov %esp,%eax
ffffffff8147461f: 4c 89 f7 mov %r14,%rdi
ffffffff81474622: 4c 89 fe mov %r15,%rsi
ffffffff81474625: ba 20 00 00 00 mov $0x20,%edx
ffffffff8147462a: 89 c4 mov %eax,%esp
ffffffff8147462c: e8 bf 52 05 00 callq ffffffff814c98f0 <copy_user_generic_unrolled>
Despite the absurdity of it backing up and restoring the stack pointer
for no reason, the bug is actually the fact that it's only backing up
and restoring the lower 32 bits of the stack pointer. The upper 32 bits
are getting cleared out, corrupting the stack pointer.
So change the '__asm_call_sp' register variable to be associated with
the actual full-size stack pointer.
This also requires changing the __ASM_SEL() macro to be based on the
actual compiled arch size, rather than the CONFIG value, because
CONFIG_X86_64 compiles some files with '-m32' (e.g., realmode and vdso).
Otherwise Clang fails to build the kernel because it complains about the
use of a 64-bit register (RSP) in a 32-bit file.
Reported-and-Bisected-and-Tested-by: kernel test robot <xiaolong.ye@intel.com>
Diagnosed-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Dmitriy Vyukov <dvyukov@google.com>
Cc: LKP <lkp@01.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang")
Link: http://lkml.kernel.org/r/20170928215826.6sdpmwtkiydiytim@treble
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2017-09-29 05:58:26 +08:00
|
|
|
/* 64 bit */
|
2008-06-17 07:08:17 +08:00
|
|
|
# define __ASM_SEL(a,b) __ASM_FORM(b)
|
2013-08-30 03:13:04 +08:00
|
|
|
# define __ASM_SEL_RAW(a,b) __ASM_FORM_RAW(b)
|
2008-06-17 07:08:17 +08:00
|
|
|
#endif
|
2008-01-30 20:30:06 +08:00
|
|
|
|
2011-07-19 19:59:51 +08:00
|
|
|
#define __ASM_SIZE(inst, ...) __ASM_SEL(inst##l##__VA_ARGS__, \
|
|
|
|
|
inst##q##__VA_ARGS__)
|
2013-08-30 03:13:04 +08:00
|
|
|
#define __ASM_REG(reg) __ASM_SEL_RAW(e##reg, r##reg)
|
2008-01-30 20:30:06 +08:00
|
|
|
|
2008-06-17 07:08:17 +08:00
|
|
|
#define _ASM_PTR __ASM_SEL(.long, .quad)
|
|
|
|
|
#define _ASM_ALIGN __ASM_SEL(.balign 4, .balign 8)
|
2008-01-30 20:31:26 +08:00
|
|
|
|
2008-08-19 09:13:33 +08:00
|
|
|
#define _ASM_MOV __ASM_SIZE(mov)
|
2008-06-17 07:08:17 +08:00
|
|
|
#define _ASM_INC __ASM_SIZE(inc)
|
|
|
|
|
#define _ASM_DEC __ASM_SIZE(dec)
|
|
|
|
|
#define _ASM_ADD __ASM_SIZE(add)
|
|
|
|
|
#define _ASM_SUB __ASM_SIZE(sub)
|
|
|
|
|
#define _ASM_XADD __ASM_SIZE(xadd)
|
2017-05-02 06:47:41 +08:00
|
|
|
#define _ASM_MUL __ASM_SIZE(mul)
|
2008-08-19 09:13:33 +08:00
|
|
|
|
2008-06-24 22:37:57 +08:00
|
|
|
#define _ASM_AX __ASM_REG(ax)
|
2008-06-25 04:36:31 +08:00
|
|
|
#define _ASM_BX __ASM_REG(bx)
|
|
|
|
|
#define _ASM_CX __ASM_REG(cx)
|
2008-06-24 22:37:57 +08:00
|
|
|
#define _ASM_DX __ASM_REG(dx)
|
2008-08-19 09:13:33 +08:00
|
|
|
#define _ASM_SP __ASM_REG(sp)
|
|
|
|
|
#define _ASM_BP __ASM_REG(bp)
|
|
|
|
|
#define _ASM_SI __ASM_REG(si)
|
|
|
|
|
#define _ASM_DI __ASM_REG(di)
|
2008-01-30 20:30:06 +08:00
|
|
|
|
2018-06-22 00:23:23 +08:00
|
|
|
#ifndef __x86_64__
|
|
|
|
|
/* 32 bit */
|
|
|
|
|
|
|
|
|
|
#define _ASM_ARG1 _ASM_AX
|
|
|
|
|
#define _ASM_ARG2 _ASM_DX
|
|
|
|
|
#define _ASM_ARG3 _ASM_CX
|
|
|
|
|
|
|
|
|
|
#define _ASM_ARG1L eax
|
|
|
|
|
#define _ASM_ARG2L edx
|
|
|
|
|
#define _ASM_ARG3L ecx
|
|
|
|
|
|
|
|
|
|
#define _ASM_ARG1W ax
|
|
|
|
|
#define _ASM_ARG2W dx
|
|
|
|
|
#define _ASM_ARG3W cx
|
|
|
|
|
|
|
|
|
|
#define _ASM_ARG1B al
|
|
|
|
|
#define _ASM_ARG2B dl
|
|
|
|
|
#define _ASM_ARG3B cl
|
|
|
|
|
|
|
|
|
|
#else
|
|
|
|
|
/* 64 bit */
|
|
|
|
|
|
|
|
|
|
#define _ASM_ARG1 _ASM_DI
|
|
|
|
|
#define _ASM_ARG2 _ASM_SI
|
|
|
|
|
#define _ASM_ARG3 _ASM_DX
|
|
|
|
|
#define _ASM_ARG4 _ASM_CX
|
|
|
|
|
#define _ASM_ARG5 r8
|
|
|
|
|
#define _ASM_ARG6 r9
|
|
|
|
|
|
|
|
|
|
#define _ASM_ARG1Q rdi
|
|
|
|
|
#define _ASM_ARG2Q rsi
|
|
|
|
|
#define _ASM_ARG3Q rdx
|
|
|
|
|
#define _ASM_ARG4Q rcx
|
|
|
|
|
#define _ASM_ARG5Q r8
|
|
|
|
|
#define _ASM_ARG6Q r9
|
|
|
|
|
|
|
|
|
|
#define _ASM_ARG1L edi
|
|
|
|
|
#define _ASM_ARG2L esi
|
|
|
|
|
#define _ASM_ARG3L edx
|
|
|
|
|
#define _ASM_ARG4L ecx
|
|
|
|
|
#define _ASM_ARG5L r8d
|
|
|
|
|
#define _ASM_ARG6L r9d
|
|
|
|
|
|
|
|
|
|
#define _ASM_ARG1W di
|
|
|
|
|
#define _ASM_ARG2W si
|
|
|
|
|
#define _ASM_ARG3W dx
|
|
|
|
|
#define _ASM_ARG4W cx
|
|
|
|
|
#define _ASM_ARG5W r8w
|
|
|
|
|
#define _ASM_ARG6W r9w
|
|
|
|
|
|
|
|
|
|
#define _ASM_ARG1B dil
|
|
|
|
|
#define _ASM_ARG2B sil
|
|
|
|
|
#define _ASM_ARG3B dl
|
|
|
|
|
#define _ASM_ARG4B cl
|
|
|
|
|
#define _ASM_ARG5B r8b
|
|
|
|
|
#define _ASM_ARG6B r9b
|
|
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
|
2016-06-09 03:38:40 +08:00
|
|
|
/*
|
|
|
|
|
* Macros to generate condition code outputs from inline assembly,
|
|
|
|
|
* The output operand must be type "bool".
|
|
|
|
|
*/
|
|
|
|
|
#ifdef __GCC_ASM_FLAG_OUTPUTS__
|
|
|
|
|
# define CC_SET(c) "\n\t/* output condition code " #c "*/\n"
|
|
|
|
|
# define CC_OUT(c) "=@cc" #c
|
|
|
|
|
#else
|
|
|
|
|
# define CC_SET(c) "\n\tset" #c " %[_cc_" #c "]\n"
|
|
|
|
|
# define CC_OUT(c) [_cc_ ## c] "=qm"
|
|
|
|
|
#endif
|
|
|
|
|
|
2008-02-04 23:47:56 +08:00
|
|
|
/* Exception table entry */
|
2009-09-01 02:57:20 +08:00
|
|
|
#ifdef __ASSEMBLY__
|
2016-02-18 02:20:12 +08:00
|
|
|
# define _ASM_EXTABLE_HANDLE(from, to, handler) \
|
2018-12-19 18:20:37 +08:00
|
|
|
.pushsection "__ex_table","a" ; \
|
|
|
|
|
.balign 4 ; \
|
|
|
|
|
.long (from) - . ; \
|
|
|
|
|
.long (to) - . ; \
|
|
|
|
|
.long (handler) - . ; \
|
2012-04-21 07:57:35 +08:00
|
|
|
.popsection
|
|
|
|
|
|
2016-02-18 02:20:12 +08:00
|
|
|
# define _ASM_EXTABLE(from, to) \
|
|
|
|
|
_ASM_EXTABLE_HANDLE(from, to, ex_handler_default)
|
|
|
|
|
|
2018-08-29 04:14:18 +08:00
|
|
|
# define _ASM_EXTABLE_UA(from, to) \
|
|
|
|
|
_ASM_EXTABLE_HANDLE(from, to, ex_handler_uaccess)
|
|
|
|
|
|
2016-02-18 02:20:12 +08:00
|
|
|
# define _ASM_EXTABLE_FAULT(from, to) \
|
|
|
|
|
_ASM_EXTABLE_HANDLE(from, to, ex_handler_fault)
|
|
|
|
|
|
|
|
|
|
# define _ASM_EXTABLE_EX(from, to) \
|
|
|
|
|
_ASM_EXTABLE_HANDLE(from, to, ex_handler_ext)
|
2014-04-17 16:17:05 +08:00
|
|
|
|
|
|
|
|
# define _ASM_NOKPROBE(entry) \
|
|
|
|
|
.pushsection "_kprobe_blacklist","aw" ; \
|
|
|
|
|
_ASM_ALIGN ; \
|
|
|
|
|
_ASM_PTR (entry); \
|
|
|
|
|
.popsection
|
2015-05-14 01:42:23 +08:00
|
|
|
|
2018-12-19 18:20:37 +08:00
|
|
|
#else
|
|
|
|
|
# define _EXPAND_EXTABLE_HANDLE(x) #x
|
|
|
|
|
# define _ASM_EXTABLE_HANDLE(from, to, handler) \
|
|
|
|
|
" .pushsection \"__ex_table\",\"a\"\n" \
|
|
|
|
|
" .balign 4\n" \
|
|
|
|
|
" .long (" #from ") - .\n" \
|
|
|
|
|
" .long (" #to ") - .\n" \
|
|
|
|
|
" .long (" _EXPAND_EXTABLE_HANDLE(handler) ") - .\n" \
|
|
|
|
|
" .popsection\n"
|
|
|
|
|
|
|
|
|
|
# define _ASM_EXTABLE(from, to) \
|
|
|
|
|
_ASM_EXTABLE_HANDLE(from, to, ex_handler_default)
|
|
|
|
|
|
|
|
|
|
# define _ASM_EXTABLE_UA(from, to) \
|
|
|
|
|
_ASM_EXTABLE_HANDLE(from, to, ex_handler_uaccess)
|
|
|
|
|
|
|
|
|
|
# define _ASM_EXTABLE_FAULT(from, to) \
|
|
|
|
|
_ASM_EXTABLE_HANDLE(from, to, ex_handler_fault)
|
|
|
|
|
|
|
|
|
|
# define _ASM_EXTABLE_EX(from, to) \
|
|
|
|
|
_ASM_EXTABLE_HANDLE(from, to, ex_handler_ext)
|
|
|
|
|
|
|
|
|
|
/* For C file, we already have NOKPROBE_SYMBOL macro */
|
|
|
|
|
#endif
|
2008-02-04 23:47:56 +08:00
|
|
|
|
x86/asm: Fix inline asm call constraints for Clang
For inline asm statements which have a CALL instruction, we list the
stack pointer as a constraint to convince GCC to ensure the frame
pointer is set up first:
static inline void foo()
{
register void *__sp asm(_ASM_SP);
asm("call bar" : "+r" (__sp))
}
Unfortunately, that pattern causes Clang to corrupt the stack pointer.
The fix is easy: convert the stack pointer register variable to a global
variable.
It should be noted that the end result is different based on the GCC
version. With GCC 6.4, this patch has exactly the same result as
before:
defconfig defconfig-nofp distro distro-nofp
before 9820389 9491555 8816046 8516940
after 9820389 9491555 8816046 8516940
With GCC 7.2, however, GCC's behavior has changed. It now changes its
behavior based on the conversion of the register variable to a global.
That somehow convinces it to *always* set up the frame pointer before
inserting *any* inline asm. (Therefore, listing the variable as an
output constraint is a no-op and is no longer necessary.) It's a bit
overkill, but the performance impact should be negligible. And in fact,
there's a nice improvement with frame pointers disabled:
defconfig defconfig-nofp distro distro-nofp
before 9796316 9468236 9076191 8790305
after 9796957 9464267 9076381 8785949
So in summary, while listing the stack pointer as an output constraint
is no longer necessary for newer versions of GCC, it's still needed for
older versions.
Suggested-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Reported-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Dmitriy Vyukov <dvyukov@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/3db862e970c432ae823cf515c52b54fec8270e0e.1505942196.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2017-09-21 05:24:33 +08:00
|
|
|
#ifndef __ASSEMBLY__
|
|
|
|
|
/*
|
|
|
|
|
* This output constraint should be used for any inline asm which has a "call"
|
|
|
|
|
* instruction. Otherwise the asm may be inserted before the frame pointer
|
|
|
|
|
* gets set up by the containing function. If you forget to do this, objtool
|
|
|
|
|
* may print a "call without frame pointer save/setup" warning.
|
|
|
|
|
*/
|
2017-09-29 22:15:36 +08:00
|
|
|
register unsigned long current_stack_pointer asm(_ASM_SP);
|
|
|
|
|
#define ASM_CALL_CONSTRAINT "+r" (current_stack_pointer)
|
x86/asm: Fix inline asm call constraints for Clang
For inline asm statements which have a CALL instruction, we list the
stack pointer as a constraint to convince GCC to ensure the frame
pointer is set up first:
static inline void foo()
{
register void *__sp asm(_ASM_SP);
asm("call bar" : "+r" (__sp))
}
Unfortunately, that pattern causes Clang to corrupt the stack pointer.
The fix is easy: convert the stack pointer register variable to a global
variable.
It should be noted that the end result is different based on the GCC
version. With GCC 6.4, this patch has exactly the same result as
before:
defconfig defconfig-nofp distro distro-nofp
before 9820389 9491555 8816046 8516940
after 9820389 9491555 8816046 8516940
With GCC 7.2, however, GCC's behavior has changed. It now changes its
behavior based on the conversion of the register variable to a global.
That somehow convinces it to *always* set up the frame pointer before
inserting *any* inline asm. (Therefore, listing the variable as an
output constraint is a no-op and is no longer necessary.) It's a bit
overkill, but the performance impact should be negligible. And in fact,
there's a nice improvement with frame pointers disabled:
defconfig defconfig-nofp distro distro-nofp
before 9796316 9468236 9076191 8790305
after 9796957 9464267 9076381 8785949
So in summary, while listing the stack pointer as an output constraint
is no longer necessary for newer versions of GCC, it's still needed for
older versions.
Suggested-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Reported-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Dmitriy Vyukov <dvyukov@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/3db862e970c432ae823cf515c52b54fec8270e0e.1505942196.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2017-09-21 05:24:33 +08:00
|
|
|
#endif
|
|
|
|
|
|
2008-10-23 13:26:29 +08:00
|
|
|
#endif /* _ASM_X86_ASM_H */
|