License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 22:07:57 +08:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
arch: x86: New MailBox support driver for Intel SOC's
Current Intel SOC cores use a MailBox Interface (MBI) to provide access to
configuration registers on devices (called units) connected to the system
fabric. This is a support driver that implements access to this interface on
those platforms that can enumerate the device using PCI. Initial support is for
BayTrail, for which port definitons are provided. This is a requirement for
implementing platform specific features (e.g. RAPL driver requires this to
perform platform specific power management using the registers in PUNIT).
Dependant modules should select IOSF_MBI in their respective Kconfig
configuraiton. Serialized access is handled by all exported routines with
spinlocks.
The API includes 3 functions for access to unit registers:
int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr)
int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr)
int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask)
port: indicating the unit being accessed
opcode: the read or write port specific opcode
offset: the register offset within the port
mdr: the register data to be read, written, or modified
mask: bit locations in mdr to change
Returns nonzero on error
Note: GPU code handles access to the GFX unit. Therefore access to that unit
with this driver is disallowed to avoid conflicts.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Link: http://lkml.kernel.org/r/1389216471-734-1-git-send-email-david.e.box@linux.intel.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
2014-01-09 05:27:51 +08:00
|
|
|
/*
|
2015-11-12 01:59:29 +08:00
|
|
|
* Intel OnChip System Fabric MailBox access support
|
arch: x86: New MailBox support driver for Intel SOC's
Current Intel SOC cores use a MailBox Interface (MBI) to provide access to
configuration registers on devices (called units) connected to the system
fabric. This is a support driver that implements access to this interface on
those platforms that can enumerate the device using PCI. Initial support is for
BayTrail, for which port definitons are provided. This is a requirement for
implementing platform specific features (e.g. RAPL driver requires this to
perform platform specific power management using the registers in PUNIT).
Dependant modules should select IOSF_MBI in their respective Kconfig
configuraiton. Serialized access is handled by all exported routines with
spinlocks.
The API includes 3 functions for access to unit registers:
int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr)
int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr)
int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask)
port: indicating the unit being accessed
opcode: the read or write port specific opcode
offset: the register offset within the port
mdr: the register data to be read, written, or modified
mask: bit locations in mdr to change
Returns nonzero on error
Note: GPU code handles access to the GFX unit. Therefore access to that unit
with this driver is disallowed to avoid conflicts.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Link: http://lkml.kernel.org/r/1389216471-734-1-git-send-email-david.e.box@linux.intel.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
2014-01-09 05:27:51 +08:00
|
|
|
*/
|
|
|
|
|
|
|
|
#ifndef IOSF_MBI_SYMS_H
|
|
|
|
#define IOSF_MBI_SYMS_H
|
|
|
|
|
2017-02-24 17:29:02 +08:00
|
|
|
#include <linux/notifier.h>
|
|
|
|
|
arch: x86: New MailBox support driver for Intel SOC's
Current Intel SOC cores use a MailBox Interface (MBI) to provide access to
configuration registers on devices (called units) connected to the system
fabric. This is a support driver that implements access to this interface on
those platforms that can enumerate the device using PCI. Initial support is for
BayTrail, for which port definitons are provided. This is a requirement for
implementing platform specific features (e.g. RAPL driver requires this to
perform platform specific power management using the registers in PUNIT).
Dependant modules should select IOSF_MBI in their respective Kconfig
configuraiton. Serialized access is handled by all exported routines with
spinlocks.
The API includes 3 functions for access to unit registers:
int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr)
int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr)
int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask)
port: indicating the unit being accessed
opcode: the read or write port specific opcode
offset: the register offset within the port
mdr: the register data to be read, written, or modified
mask: bit locations in mdr to change
Returns nonzero on error
Note: GPU code handles access to the GFX unit. Therefore access to that unit
with this driver is disallowed to avoid conflicts.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Link: http://lkml.kernel.org/r/1389216471-734-1-git-send-email-david.e.box@linux.intel.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
2014-01-09 05:27:51 +08:00
|
|
|
#define MBI_MCR_OFFSET 0xD0
|
|
|
|
#define MBI_MDR_OFFSET 0xD4
|
|
|
|
#define MBI_MCRX_OFFSET 0xD8
|
|
|
|
|
|
|
|
#define MBI_RD_MASK 0xFEFFFFFF
|
|
|
|
#define MBI_WR_MASK 0X01000000
|
|
|
|
|
|
|
|
#define MBI_MASK_HI 0xFFFFFF00
|
|
|
|
#define MBI_MASK_LO 0x000000FF
|
|
|
|
#define MBI_ENABLE 0xF0
|
|
|
|
|
2015-11-12 01:59:29 +08:00
|
|
|
/* IOSF SB read/write opcodes */
|
|
|
|
#define MBI_MMIO_READ 0x00
|
|
|
|
#define MBI_MMIO_WRITE 0x01
|
2015-12-12 09:45:06 +08:00
|
|
|
#define MBI_CFG_READ 0x04
|
|
|
|
#define MBI_CFG_WRITE 0x05
|
2015-11-12 01:59:29 +08:00
|
|
|
#define MBI_CR_READ 0x06
|
|
|
|
#define MBI_CR_WRITE 0x07
|
|
|
|
#define MBI_REG_READ 0x10
|
|
|
|
#define MBI_REG_WRITE 0x11
|
|
|
|
#define MBI_ESRAM_READ 0x12
|
|
|
|
#define MBI_ESRAM_WRITE 0x13
|
|
|
|
|
arch: x86: New MailBox support driver for Intel SOC's
Current Intel SOC cores use a MailBox Interface (MBI) to provide access to
configuration registers on devices (called units) connected to the system
fabric. This is a support driver that implements access to this interface on
those platforms that can enumerate the device using PCI. Initial support is for
BayTrail, for which port definitons are provided. This is a requirement for
implementing platform specific features (e.g. RAPL driver requires this to
perform platform specific power management using the registers in PUNIT).
Dependant modules should select IOSF_MBI in their respective Kconfig
configuraiton. Serialized access is handled by all exported routines with
spinlocks.
The API includes 3 functions for access to unit registers:
int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr)
int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr)
int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask)
port: indicating the unit being accessed
opcode: the read or write port specific opcode
offset: the register offset within the port
mdr: the register data to be read, written, or modified
mask: bit locations in mdr to change
Returns nonzero on error
Note: GPU code handles access to the GFX unit. Therefore access to that unit
with this driver is disallowed to avoid conflicts.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Link: http://lkml.kernel.org/r/1389216471-734-1-git-send-email-david.e.box@linux.intel.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
2014-01-09 05:27:51 +08:00
|
|
|
/* Baytrail available units */
|
|
|
|
#define BT_MBI_UNIT_AUNIT 0x00
|
|
|
|
#define BT_MBI_UNIT_SMC 0x01
|
|
|
|
#define BT_MBI_UNIT_CPU 0x02
|
|
|
|
#define BT_MBI_UNIT_BUNIT 0x03
|
|
|
|
#define BT_MBI_UNIT_PMC 0x04
|
|
|
|
#define BT_MBI_UNIT_GFX 0x06
|
|
|
|
#define BT_MBI_UNIT_SMI 0x0C
|
|
|
|
#define BT_MBI_UNIT_USB 0x43
|
|
|
|
#define BT_MBI_UNIT_SATA 0xA3
|
|
|
|
#define BT_MBI_UNIT_PCIE 0xA6
|
|
|
|
|
2014-05-10 04:44:06 +08:00
|
|
|
/* Quark available units */
|
|
|
|
#define QRK_MBI_UNIT_HBA 0x00
|
2015-07-08 22:45:08 +08:00
|
|
|
#define QRK_MBI_UNIT_HB 0x03
|
2014-05-10 04:44:06 +08:00
|
|
|
#define QRK_MBI_UNIT_RMU 0x04
|
2015-07-08 22:45:08 +08:00
|
|
|
#define QRK_MBI_UNIT_MM 0x05
|
2014-05-10 04:44:06 +08:00
|
|
|
#define QRK_MBI_UNIT_SOC 0x31
|
|
|
|
|
2017-02-24 17:29:02 +08:00
|
|
|
/* Action values for the pmic_bus_access_notifier functions */
|
|
|
|
#define MBI_PMIC_BUS_ACCESS_BEGIN 1
|
|
|
|
#define MBI_PMIC_BUS_ACCESS_END 2
|
|
|
|
|
2014-05-10 04:44:05 +08:00
|
|
|
#if IS_ENABLED(CONFIG_IOSF_MBI)
|
|
|
|
|
|
|
|
bool iosf_mbi_available(void);
|
|
|
|
|
arch: x86: New MailBox support driver for Intel SOC's
Current Intel SOC cores use a MailBox Interface (MBI) to provide access to
configuration registers on devices (called units) connected to the system
fabric. This is a support driver that implements access to this interface on
those platforms that can enumerate the device using PCI. Initial support is for
BayTrail, for which port definitons are provided. This is a requirement for
implementing platform specific features (e.g. RAPL driver requires this to
perform platform specific power management using the registers in PUNIT).
Dependant modules should select IOSF_MBI in their respective Kconfig
configuraiton. Serialized access is handled by all exported routines with
spinlocks.
The API includes 3 functions for access to unit registers:
int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr)
int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr)
int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask)
port: indicating the unit being accessed
opcode: the read or write port specific opcode
offset: the register offset within the port
mdr: the register data to be read, written, or modified
mask: bit locations in mdr to change
Returns nonzero on error
Note: GPU code handles access to the GFX unit. Therefore access to that unit
with this driver is disallowed to avoid conflicts.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Link: http://lkml.kernel.org/r/1389216471-734-1-git-send-email-david.e.box@linux.intel.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
2014-01-09 05:27:51 +08:00
|
|
|
/**
|
|
|
|
* iosf_mbi_read() - MailBox Interface read command
|
|
|
|
* @port: port indicating subunit being accessed
|
|
|
|
* @opcode: port specific read or write opcode
|
|
|
|
* @offset: register address offset
|
|
|
|
* @mdr: register data to be read
|
|
|
|
*
|
|
|
|
* Locking is handled by spinlock - cannot sleep.
|
|
|
|
* Return: Nonzero on error
|
|
|
|
*/
|
|
|
|
int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iosf_mbi_write() - MailBox unmasked write command
|
|
|
|
* @port: port indicating subunit being accessed
|
|
|
|
* @opcode: port specific read or write opcode
|
|
|
|
* @offset: register address offset
|
|
|
|
* @mdr: register data to be written
|
|
|
|
*
|
|
|
|
* Locking is handled by spinlock - cannot sleep.
|
|
|
|
* Return: Nonzero on error
|
|
|
|
*/
|
|
|
|
int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iosf_mbi_modify() - MailBox masked write command
|
|
|
|
* @port: port indicating subunit being accessed
|
|
|
|
* @opcode: port specific read or write opcode
|
|
|
|
* @offset: register address offset
|
|
|
|
* @mdr: register data being modified
|
|
|
|
* @mask: mask indicating bits in mdr to be modified
|
|
|
|
*
|
|
|
|
* Locking is handled by spinlock - cannot sleep.
|
|
|
|
* Return: Nonzero on error
|
|
|
|
*/
|
|
|
|
int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask);
|
|
|
|
|
2017-02-10 18:27:51 +08:00
|
|
|
/**
|
|
|
|
* iosf_mbi_punit_acquire() - Acquire access to the P-Unit
|
|
|
|
*
|
|
|
|
* One some systems the P-Unit accesses the PMIC to change various voltages
|
|
|
|
* through the same bus as other kernel drivers use for e.g. battery monitoring.
|
|
|
|
*
|
|
|
|
* If a driver sends requests to the P-Unit which require the P-Unit to access
|
|
|
|
* the PMIC bus while another driver is also accessing the PMIC bus various bad
|
|
|
|
* things happen.
|
|
|
|
*
|
x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code
On some BYT/CHT systems the SoC's P-Unit shares the I2C bus with the
kernel. The P-Unit has a semaphore for the PMIC bus which we can take to
block it from accessing the shared bus while the kernel wants to access it.
Currently we have the I2C-controller driver acquiring and releasing the
semaphore around each I2C transfer. There are 2 problems with this:
1) PMIC accesses often come in the form of a read-modify-write on one of
the PMIC registers, we currently release the P-Unit's PMIC bus semaphore
between the read and the write. If the P-Unit modifies the register during
this window?, then we end up overwriting the P-Unit's changes.
I believe that this is mostly an academic problem, but I'm not sure.
2) To safely access the shared I2C bus, we need to do 3 things:
a) Notify the GPU driver that we are starting a window in which it may not
access the P-Unit, since the P-Unit seems to ignore the semaphore for
explicit power-level requests made by the GPU driver
b) Make a pm_qos request to force all CPU cores out of C6/C7 since entering
C6/C7 while we hold the semaphore hangs the SoC
c) Finally take the P-Unit's PMIC bus semaphore
All 3 these steps together are somewhat expensive, so ideally if we have
a bunch of i2c transfers grouped together we only do this once for the
entire group.
Taking the read-modify-write on a PMIC register as example then ideally we
would only do all 3 steps once at the beginning and undo all 3 steps once
at the end.
For this we need to be able to take the semaphore from within e.g. the PMIC
opregion driver, yet we do not want to remove the taking of the semaphore
from the I2C-controller driver, as that is still necessary to protect many
other code-paths leading to accessing the shared I2C bus.
This means that we first have the PMIC driver acquire the semaphore and
then have the I2C controller driver trying to acquire it again.
To make this possible this commit does the following:
1) Move the semaphore code from being private to the I2C controller driver
into the generic iosf_mbi code, which already has other code to deal with
the shared bus so that it can be accessed outside of the I2C bus driver.
2) Rework the code so that it can be called multiple times nested, while
still blocking I2C accesses while e.g. the GPU driver has indicated the
P-Unit needs the bus through a iosf_mbi_punit_acquire() call.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2018-10-11 22:29:09 +08:00
|
|
|
* Call this function before sending requests to the P-Unit which may make it
|
|
|
|
* access the PMIC, be it through iosf_mbi* functions or through other means.
|
|
|
|
* This function will block all kernel access to the PMIC I2C bus, so that the
|
|
|
|
* P-Unit can safely access the PMIC over the shared I2C bus.
|
2017-02-10 18:27:51 +08:00
|
|
|
*
|
|
|
|
* Note on these systems the i2c-bus driver will request a sempahore from the
|
|
|
|
* P-Unit for exclusive access to the PMIC bus when i2c drivers are accessing
|
|
|
|
* it, but this does not appear to be sufficient, we still need to avoid making
|
|
|
|
* certain P-Unit requests during the access window to avoid problems.
|
|
|
|
*
|
|
|
|
* This function locks a mutex, as such it may sleep.
|
|
|
|
*/
|
|
|
|
void iosf_mbi_punit_acquire(void);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iosf_mbi_punit_release() - Release access to the P-Unit
|
|
|
|
*/
|
|
|
|
void iosf_mbi_punit_release(void);
|
|
|
|
|
x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code
On some BYT/CHT systems the SoC's P-Unit shares the I2C bus with the
kernel. The P-Unit has a semaphore for the PMIC bus which we can take to
block it from accessing the shared bus while the kernel wants to access it.
Currently we have the I2C-controller driver acquiring and releasing the
semaphore around each I2C transfer. There are 2 problems with this:
1) PMIC accesses often come in the form of a read-modify-write on one of
the PMIC registers, we currently release the P-Unit's PMIC bus semaphore
between the read and the write. If the P-Unit modifies the register during
this window?, then we end up overwriting the P-Unit's changes.
I believe that this is mostly an academic problem, but I'm not sure.
2) To safely access the shared I2C bus, we need to do 3 things:
a) Notify the GPU driver that we are starting a window in which it may not
access the P-Unit, since the P-Unit seems to ignore the semaphore for
explicit power-level requests made by the GPU driver
b) Make a pm_qos request to force all CPU cores out of C6/C7 since entering
C6/C7 while we hold the semaphore hangs the SoC
c) Finally take the P-Unit's PMIC bus semaphore
All 3 these steps together are somewhat expensive, so ideally if we have
a bunch of i2c transfers grouped together we only do this once for the
entire group.
Taking the read-modify-write on a PMIC register as example then ideally we
would only do all 3 steps once at the beginning and undo all 3 steps once
at the end.
For this we need to be able to take the semaphore from within e.g. the PMIC
opregion driver, yet we do not want to remove the taking of the semaphore
from the I2C-controller driver, as that is still necessary to protect many
other code-paths leading to accessing the shared I2C bus.
This means that we first have the PMIC driver acquire the semaphore and
then have the I2C controller driver trying to acquire it again.
To make this possible this commit does the following:
1) Move the semaphore code from being private to the I2C controller driver
into the generic iosf_mbi code, which already has other code to deal with
the shared bus so that it can be accessed outside of the I2C bus driver.
2) Rework the code so that it can be called multiple times nested, while
still blocking I2C accesses while e.g. the GPU driver has indicated the
P-Unit needs the bus through a iosf_mbi_punit_acquire() call.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2018-10-11 22:29:09 +08:00
|
|
|
/**
|
|
|
|
* iosf_mbi_block_punit_i2c_access() - Block P-Unit accesses to the PMIC bus
|
|
|
|
*
|
|
|
|
* Call this function to block P-Unit access to the PMIC I2C bus, so that the
|
|
|
|
* kernel can safely access the PMIC over the shared I2C bus.
|
|
|
|
*
|
|
|
|
* This function acquires the P-Unit bus semaphore and notifies
|
|
|
|
* pmic_bus_access_notifier listeners that they may no longer access the
|
|
|
|
* P-Unit in a way which may cause it to access the shared I2C bus.
|
|
|
|
*
|
|
|
|
* Note this function may be called multiple times and the bus will not
|
|
|
|
* be released until iosf_mbi_unblock_punit_i2c_access() has been called the
|
|
|
|
* same amount of times.
|
|
|
|
*
|
|
|
|
* Return: Nonzero on error
|
|
|
|
*/
|
|
|
|
int iosf_mbi_block_punit_i2c_access(void);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* iosf_mbi_unblock_punit_i2c_access() - Release PMIC I2C bus block
|
|
|
|
*
|
|
|
|
* Release i2c access block gotten through iosf_mbi_block_punit_i2c_access().
|
|
|
|
*/
|
|
|
|
void iosf_mbi_unblock_punit_i2c_access(void);
|
|
|
|
|
2017-02-24 17:29:02 +08:00
|
|
|
/**
|
|
|
|
* iosf_mbi_register_pmic_bus_access_notifier - Register PMIC bus notifier
|
|
|
|
*
|
|
|
|
* This function can be used by drivers which may need to acquire P-Unit
|
|
|
|
* managed resources from interrupt context, where iosf_mbi_punit_acquire()
|
|
|
|
* can not be used.
|
|
|
|
*
|
|
|
|
* This function allows a driver to register a notifier to get notified (in a
|
|
|
|
* process context) before other drivers start accessing the PMIC bus.
|
|
|
|
*
|
|
|
|
* This allows the driver to acquire any resources, which it may need during
|
|
|
|
* the window the other driver is accessing the PMIC, before hand.
|
|
|
|
*
|
|
|
|
* @nb: notifier_block to register
|
|
|
|
*/
|
|
|
|
int iosf_mbi_register_pmic_bus_access_notifier(struct notifier_block *nb);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iosf_mbi_register_pmic_bus_access_notifier - Unregister PMIC bus notifier
|
|
|
|
*
|
|
|
|
* @nb: notifier_block to unregister
|
|
|
|
*/
|
|
|
|
int iosf_mbi_unregister_pmic_bus_access_notifier(struct notifier_block *nb);
|
|
|
|
|
2017-10-19 19:16:19 +08:00
|
|
|
/**
|
|
|
|
* iosf_mbi_unregister_pmic_bus_access_notifier_unlocked - Unregister PMIC bus
|
|
|
|
* notifier, unlocked
|
|
|
|
*
|
|
|
|
* Like iosf_mbi_unregister_pmic_bus_access_notifier(), but for use when the
|
|
|
|
* caller has already called iosf_mbi_punit_acquire() itself.
|
|
|
|
*
|
|
|
|
* @nb: notifier_block to unregister
|
|
|
|
*/
|
|
|
|
int iosf_mbi_unregister_pmic_bus_access_notifier_unlocked(
|
|
|
|
struct notifier_block *nb);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iosf_mbi_assert_punit_acquired - Assert that the P-Unit has been acquired.
|
|
|
|
*/
|
|
|
|
void iosf_mbi_assert_punit_acquired(void);
|
|
|
|
|
2014-05-10 04:44:05 +08:00
|
|
|
#else /* CONFIG_IOSF_MBI is not enabled */
|
|
|
|
static inline
|
|
|
|
bool iosf_mbi_available(void)
|
|
|
|
{
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline
|
|
|
|
int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr)
|
|
|
|
{
|
|
|
|
WARN(1, "IOSF_MBI driver not available");
|
|
|
|
return -EPERM;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline
|
|
|
|
int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr)
|
|
|
|
{
|
|
|
|
WARN(1, "IOSF_MBI driver not available");
|
|
|
|
return -EPERM;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline
|
|
|
|
int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask)
|
|
|
|
{
|
|
|
|
WARN(1, "IOSF_MBI driver not available");
|
|
|
|
return -EPERM;
|
|
|
|
}
|
2017-02-10 18:27:51 +08:00
|
|
|
|
|
|
|
static inline void iosf_mbi_punit_acquire(void) {}
|
|
|
|
static inline void iosf_mbi_punit_release(void) {}
|
|
|
|
|
2017-02-24 17:29:02 +08:00
|
|
|
static inline
|
|
|
|
int iosf_mbi_register_pmic_bus_access_notifier(struct notifier_block *nb)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline
|
|
|
|
int iosf_mbi_unregister_pmic_bus_access_notifier(struct notifier_block *nb)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-10-19 19:16:19 +08:00
|
|
|
static inline int
|
|
|
|
iosf_mbi_unregister_pmic_bus_access_notifier_unlocked(struct notifier_block *nb)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-02-24 17:29:02 +08:00
|
|
|
static inline
|
|
|
|
int iosf_mbi_call_pmic_bus_access_notifier_chain(unsigned long val, void *v)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-10-19 19:16:19 +08:00
|
|
|
static inline void iosf_mbi_assert_punit_acquired(void) {}
|
|
|
|
|
2014-05-10 04:44:05 +08:00
|
|
|
#endif /* CONFIG_IOSF_MBI */
|
|
|
|
|
arch: x86: New MailBox support driver for Intel SOC's
Current Intel SOC cores use a MailBox Interface (MBI) to provide access to
configuration registers on devices (called units) connected to the system
fabric. This is a support driver that implements access to this interface on
those platforms that can enumerate the device using PCI. Initial support is for
BayTrail, for which port definitons are provided. This is a requirement for
implementing platform specific features (e.g. RAPL driver requires this to
perform platform specific power management using the registers in PUNIT).
Dependant modules should select IOSF_MBI in their respective Kconfig
configuraiton. Serialized access is handled by all exported routines with
spinlocks.
The API includes 3 functions for access to unit registers:
int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr)
int iosf_mbi_write(u8 port, u8 opcode, u32 offset, u32 mdr)
int iosf_mbi_modify(u8 port, u8 opcode, u32 offset, u32 mdr, u32 mask)
port: indicating the unit being accessed
opcode: the read or write port specific opcode
offset: the register offset within the port
mdr: the register data to be read, written, or modified
mask: bit locations in mdr to change
Returns nonzero on error
Note: GPU code handles access to the GFX unit. Therefore access to that unit
with this driver is disallowed to avoid conflicts.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Link: http://lkml.kernel.org/r/1389216471-734-1-git-send-email-david.e.box@linux.intel.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
2014-01-09 05:27:51 +08:00
|
|
|
#endif /* IOSF_MBI_SYMS_H */
|