openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

[media] tuner-core: handle errors when getting signal strength/afc 

If those callbacks fail, it should return zero, and not a random
value. The previous code assumed that all drivers would only change
signal strength if it succeeds, but this may not be true.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Mauro Carvalho Chehab 2013-03-25 09:55:59 -03:00
parent 6f8ca0b541
commit 004e45d736
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/media/v4l2-core/tuner-core.c
View File

@ -220,18 +220,20 @@ static void fe_standby(struct dvb_frontend *fe)
static int fe_has_signal(struct dvb_frontend *fe)
{
u16 strength = 0;
u16 strength;
fe->ops.tuner_ops.get_rf_strength(fe, &strength);
if (fe->ops.tuner_ops.get_rf_strength(fe, &strength) < 0)
return 0;
return strength;
}
static int fe_get_afc(struct dvb_frontend *fe)
{
s32 afc = 0;
s32 afc;
fe->ops.tuner_ops.get_afc(fe, &afc);
if (fe->ops.tuner_ops.get_afc(fe, &afc) < 0)
return 0;
return afc;
}