openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: Change the layout of structure trace_event_raw_fib_table_lookup 

There is an unalignment access about the structure
'trace_event_raw_fib_table_lookup'.

In include/trace/events/fib.h, there is a memory operation which casting
the 'src' data member to a pointer, and then store a value to this
pointer point to.

p32 = (__be32 *) __entry->src;
*p32 = flp->saddr;

The offset of 'src' in structure trace_event_raw_fib_table_lookup is not
four bytes alignment. On some architectures, they don't permit the
unalignment access, it need to pay the price to handle this situation in
exception handler.

Adjust the layout of structure to avoid this case.

Fixes: 9f323973c9 ("net/ipv4: Udate fib_table_lookup tracepoint")
Signed-off-by: Zong Li <zong@andestech.com>
Acked-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Zong Li 2018-08-13 10:26:52 +08:00 committed by David S. Miller
parent a72ce9ad7c
commit 0192e7d46c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/trace/events/fib.h
View File

@ -22,6 +22,7 @@ TRACE_EVENT(fib_table_lookup,
__field( int, err ) __field( int, err )
__field( int, oif ) __field( int, oif )
__field( int, iif ) __field( int, iif )
__field( u8, proto )
__field( __u8, tos ) __field( __u8, tos )
__field( __u8, scope ) __field( __u8, scope )
__field( __u8, flags ) __field( __u8, flags )
@ -31,7 +32,6 @@ TRACE_EVENT(fib_table_lookup,
__array( __u8, saddr, 4 ) __array( __u8, saddr, 4 )
__field( u16, sport ) __field( u16, sport )
__field( u16, dport ) __field( u16, dport )
__field( u8, proto )
__dynamic_array(char, name, IFNAMSIZ ) __dynamic_array(char, name, IFNAMSIZ )
), ),