mirror of https://gitee.com/openkylin/linux.git
Merge branch 'superblock-scaling' of git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next into for-next
Conflicts: include/linux/fs.h
This commit is contained in:
commit
061f98e959
|
@ -1769,7 +1769,7 @@ void iterate_bdevs(void (*func)(struct block_device *, void *), void *arg)
|
|||
{
|
||||
struct inode *inode, *old_inode = NULL;
|
||||
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
spin_lock(&blockdev_superblock->s_inode_list_lock);
|
||||
list_for_each_entry(inode, &blockdev_superblock->s_inodes, i_sb_list) {
|
||||
struct address_space *mapping = inode->i_mapping;
|
||||
|
||||
|
@ -1781,13 +1781,13 @@ void iterate_bdevs(void (*func)(struct block_device *, void *), void *arg)
|
|||
}
|
||||
__iget(inode);
|
||||
spin_unlock(&inode->i_lock);
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&blockdev_superblock->s_inode_list_lock);
|
||||
/*
|
||||
* We hold a reference to 'inode' so it couldn't have been
|
||||
* removed from s_inodes list while we dropped the
|
||||
* inode_sb_list_lock. We cannot iput the inode now as we can
|
||||
* s_inode_list_lock We cannot iput the inode now as we can
|
||||
* be holding the last reference and we cannot iput it under
|
||||
* inode_sb_list_lock. So we keep the reference and iput it
|
||||
* s_inode_list_lock. So we keep the reference and iput it
|
||||
* later.
|
||||
*/
|
||||
iput(old_inode);
|
||||
|
@ -1795,8 +1795,8 @@ void iterate_bdevs(void (*func)(struct block_device *, void *), void *arg)
|
|||
|
||||
func(I_BDEV(inode), arg);
|
||||
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
spin_lock(&blockdev_superblock->s_inode_list_lock);
|
||||
}
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&blockdev_superblock->s_inode_list_lock);
|
||||
iput(old_inode);
|
||||
}
|
||||
|
|
|
@ -17,7 +17,7 @@ static void drop_pagecache_sb(struct super_block *sb, void *unused)
|
|||
{
|
||||
struct inode *inode, *toput_inode = NULL;
|
||||
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
spin_lock(&sb->s_inode_list_lock);
|
||||
list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
|
||||
spin_lock(&inode->i_lock);
|
||||
if ((inode->i_state & (I_FREEING|I_WILL_FREE|I_NEW)) ||
|
||||
|
@ -27,13 +27,15 @@ static void drop_pagecache_sb(struct super_block *sb, void *unused)
|
|||
}
|
||||
__iget(inode);
|
||||
spin_unlock(&inode->i_lock);
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
|
||||
invalidate_mapping_pages(inode->i_mapping, 0, -1);
|
||||
iput(toput_inode);
|
||||
toput_inode = inode;
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
|
||||
spin_lock(&sb->s_inode_list_lock);
|
||||
}
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
iput(toput_inode);
|
||||
}
|
||||
|
||||
|
|
|
@ -88,7 +88,7 @@ unsigned int dirtytime_expire_interval = 12 * 60 * 60;
|
|||
|
||||
static inline struct inode *wb_inode(struct list_head *head)
|
||||
{
|
||||
return list_entry(head, struct inode, i_wb_list);
|
||||
return list_entry(head, struct inode, i_io_list);
|
||||
}
|
||||
|
||||
/*
|
||||
|
@ -125,22 +125,22 @@ static void wb_io_lists_depopulated(struct bdi_writeback *wb)
|
|||
}
|
||||
|
||||
/**
|
||||
* inode_wb_list_move_locked - move an inode onto a bdi_writeback IO list
|
||||
* inode_io_list_move_locked - move an inode onto a bdi_writeback IO list
|
||||
* @inode: inode to be moved
|
||||
* @wb: target bdi_writeback
|
||||
* @head: one of @wb->b_{dirty|io|more_io}
|
||||
*
|
||||
* Move @inode->i_wb_list to @list of @wb and set %WB_has_dirty_io.
|
||||
* Move @inode->i_io_list to @list of @wb and set %WB_has_dirty_io.
|
||||
* Returns %true if @inode is the first occupant of the !dirty_time IO
|
||||
* lists; otherwise, %false.
|
||||
*/
|
||||
static bool inode_wb_list_move_locked(struct inode *inode,
|
||||
static bool inode_io_list_move_locked(struct inode *inode,
|
||||
struct bdi_writeback *wb,
|
||||
struct list_head *head)
|
||||
{
|
||||
assert_spin_locked(&wb->list_lock);
|
||||
|
||||
list_move(&inode->i_wb_list, head);
|
||||
list_move(&inode->i_io_list, head);
|
||||
|
||||
/* dirty_time doesn't count as dirty_io until expiration */
|
||||
if (head != &wb->b_dirty_time)
|
||||
|
@ -151,19 +151,19 @@ static bool inode_wb_list_move_locked(struct inode *inode,
|
|||
}
|
||||
|
||||
/**
|
||||
* inode_wb_list_del_locked - remove an inode from its bdi_writeback IO list
|
||||
* inode_io_list_del_locked - remove an inode from its bdi_writeback IO list
|
||||
* @inode: inode to be removed
|
||||
* @wb: bdi_writeback @inode is being removed from
|
||||
*
|
||||
* Remove @inode which may be on one of @wb->b_{dirty|io|more_io} lists and
|
||||
* clear %WB_has_dirty_io if all are empty afterwards.
|
||||
*/
|
||||
static void inode_wb_list_del_locked(struct inode *inode,
|
||||
static void inode_io_list_del_locked(struct inode *inode,
|
||||
struct bdi_writeback *wb)
|
||||
{
|
||||
assert_spin_locked(&wb->list_lock);
|
||||
|
||||
list_del_init(&inode->i_wb_list);
|
||||
list_del_init(&inode->i_io_list);
|
||||
wb_io_lists_depopulated(wb);
|
||||
}
|
||||
|
||||
|
@ -351,7 +351,7 @@ static void inode_switch_wbs_work_fn(struct work_struct *work)
|
|||
|
||||
/*
|
||||
* Once I_FREEING is visible under i_lock, the eviction path owns
|
||||
* the inode and we shouldn't modify ->i_wb_list.
|
||||
* the inode and we shouldn't modify ->i_io_list.
|
||||
*/
|
||||
if (unlikely(inode->i_state & I_FREEING))
|
||||
goto skip_switch;
|
||||
|
@ -390,16 +390,16 @@ static void inode_switch_wbs_work_fn(struct work_struct *work)
|
|||
* is always correct including from ->b_dirty_time. The transfer
|
||||
* preserves @inode->dirtied_when ordering.
|
||||
*/
|
||||
if (!list_empty(&inode->i_wb_list)) {
|
||||
if (!list_empty(&inode->i_io_list)) {
|
||||
struct inode *pos;
|
||||
|
||||
inode_wb_list_del_locked(inode, old_wb);
|
||||
inode_io_list_del_locked(inode, old_wb);
|
||||
inode->i_wb = new_wb;
|
||||
list_for_each_entry(pos, &new_wb->b_dirty, i_wb_list)
|
||||
list_for_each_entry(pos, &new_wb->b_dirty, i_io_list)
|
||||
if (time_after_eq(inode->dirtied_when,
|
||||
pos->dirtied_when))
|
||||
break;
|
||||
inode_wb_list_move_locked(inode, new_wb, pos->i_wb_list.prev);
|
||||
inode_io_list_move_locked(inode, new_wb, pos->i_io_list.prev);
|
||||
} else {
|
||||
inode->i_wb = new_wb;
|
||||
}
|
||||
|
@ -961,12 +961,12 @@ void wb_start_background_writeback(struct bdi_writeback *wb)
|
|||
/*
|
||||
* Remove the inode from the writeback list it is on.
|
||||
*/
|
||||
void inode_wb_list_del(struct inode *inode)
|
||||
void inode_io_list_del(struct inode *inode)
|
||||
{
|
||||
struct bdi_writeback *wb;
|
||||
|
||||
wb = inode_to_wb_and_lock_list(inode);
|
||||
inode_wb_list_del_locked(inode, wb);
|
||||
inode_io_list_del_locked(inode, wb);
|
||||
spin_unlock(&wb->list_lock);
|
||||
}
|
||||
|
||||
|
@ -988,7 +988,7 @@ static void redirty_tail(struct inode *inode, struct bdi_writeback *wb)
|
|||
if (time_before(inode->dirtied_when, tail->dirtied_when))
|
||||
inode->dirtied_when = jiffies;
|
||||
}
|
||||
inode_wb_list_move_locked(inode, wb, &wb->b_dirty);
|
||||
inode_io_list_move_locked(inode, wb, &wb->b_dirty);
|
||||
}
|
||||
|
||||
/*
|
||||
|
@ -996,7 +996,7 @@ static void redirty_tail(struct inode *inode, struct bdi_writeback *wb)
|
|||
*/
|
||||
static void requeue_io(struct inode *inode, struct bdi_writeback *wb)
|
||||
{
|
||||
inode_wb_list_move_locked(inode, wb, &wb->b_more_io);
|
||||
inode_io_list_move_locked(inode, wb, &wb->b_more_io);
|
||||
}
|
||||
|
||||
static void inode_sync_complete(struct inode *inode)
|
||||
|
@ -1055,7 +1055,7 @@ static int move_expired_inodes(struct list_head *delaying_queue,
|
|||
if (older_than_this &&
|
||||
inode_dirtied_after(inode, *older_than_this))
|
||||
break;
|
||||
list_move(&inode->i_wb_list, &tmp);
|
||||
list_move(&inode->i_io_list, &tmp);
|
||||
moved++;
|
||||
if (flags & EXPIRE_DIRTY_ATIME)
|
||||
set_bit(__I_DIRTY_TIME_EXPIRED, &inode->i_state);
|
||||
|
@ -1078,7 +1078,7 @@ static int move_expired_inodes(struct list_head *delaying_queue,
|
|||
list_for_each_prev_safe(pos, node, &tmp) {
|
||||
inode = wb_inode(pos);
|
||||
if (inode->i_sb == sb)
|
||||
list_move(&inode->i_wb_list, dispatch_queue);
|
||||
list_move(&inode->i_io_list, dispatch_queue);
|
||||
}
|
||||
}
|
||||
out:
|
||||
|
@ -1232,10 +1232,10 @@ static void requeue_inode(struct inode *inode, struct bdi_writeback *wb,
|
|||
redirty_tail(inode, wb);
|
||||
} else if (inode->i_state & I_DIRTY_TIME) {
|
||||
inode->dirtied_when = jiffies;
|
||||
inode_wb_list_move_locked(inode, wb, &wb->b_dirty_time);
|
||||
inode_io_list_move_locked(inode, wb, &wb->b_dirty_time);
|
||||
} else {
|
||||
/* The inode is clean. Remove from writeback lists. */
|
||||
inode_wb_list_del_locked(inode, wb);
|
||||
inode_io_list_del_locked(inode, wb);
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -1378,7 +1378,7 @@ writeback_single_inode(struct inode *inode, struct bdi_writeback *wb,
|
|||
* touch it. See comment above for explanation.
|
||||
*/
|
||||
if (!(inode->i_state & I_DIRTY_ALL))
|
||||
inode_wb_list_del_locked(inode, wb);
|
||||
inode_io_list_del_locked(inode, wb);
|
||||
spin_unlock(&wb->list_lock);
|
||||
inode_sync_complete(inode);
|
||||
out:
|
||||
|
@ -1439,7 +1439,9 @@ static long writeback_sb_inodes(struct super_block *sb,
|
|||
unsigned long start_time = jiffies;
|
||||
long write_chunk;
|
||||
long wrote = 0; /* count both pages and inodes */
|
||||
struct blk_plug plug;
|
||||
|
||||
blk_start_plug(&plug);
|
||||
while (!list_empty(&wb->b_io)) {
|
||||
struct inode *inode = wb_inode(wb->b_io.prev);
|
||||
|
||||
|
@ -1537,6 +1539,7 @@ static long writeback_sb_inodes(struct super_block *sb,
|
|||
break;
|
||||
}
|
||||
}
|
||||
blk_finish_plug(&plug);
|
||||
return wrote;
|
||||
}
|
||||
|
||||
|
@ -2088,7 +2091,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
|
|||
else
|
||||
dirty_list = &wb->b_dirty_time;
|
||||
|
||||
wakeup_bdi = inode_wb_list_move_locked(inode, wb,
|
||||
wakeup_bdi = inode_io_list_move_locked(inode, wb,
|
||||
dirty_list);
|
||||
|
||||
spin_unlock(&wb->list_lock);
|
||||
|
@ -2111,6 +2114,15 @@ void __mark_inode_dirty(struct inode *inode, int flags)
|
|||
}
|
||||
EXPORT_SYMBOL(__mark_inode_dirty);
|
||||
|
||||
/*
|
||||
* The @s_sync_lock is used to serialise concurrent sync operations
|
||||
* to avoid lock contention problems with concurrent wait_sb_inodes() calls.
|
||||
* Concurrent callers will block on the s_sync_lock rather than doing contending
|
||||
* walks. The queueing maintains sync(2) required behaviour as all the IO that
|
||||
* has been issued up to the time this function is enter is guaranteed to be
|
||||
* completed by the time we have gained the lock and waited for all IO that is
|
||||
* in progress regardless of the order callers are granted the lock.
|
||||
*/
|
||||
static void wait_sb_inodes(struct super_block *sb)
|
||||
{
|
||||
struct inode *inode, *old_inode = NULL;
|
||||
|
@ -2121,7 +2133,8 @@ static void wait_sb_inodes(struct super_block *sb)
|
|||
*/
|
||||
WARN_ON(!rwsem_is_locked(&sb->s_umount));
|
||||
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
mutex_lock(&sb->s_sync_lock);
|
||||
spin_lock(&sb->s_inode_list_lock);
|
||||
|
||||
/*
|
||||
* Data integrity sync. Must wait for all pages under writeback,
|
||||
|
@ -2141,14 +2154,14 @@ static void wait_sb_inodes(struct super_block *sb)
|
|||
}
|
||||
__iget(inode);
|
||||
spin_unlock(&inode->i_lock);
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
|
||||
/*
|
||||
* We hold a reference to 'inode' so it couldn't have been
|
||||
* removed from s_inodes list while we dropped the
|
||||
* inode_sb_list_lock. We cannot iput the inode now as we can
|
||||
* s_inode_list_lock. We cannot iput the inode now as we can
|
||||
* be holding the last reference and we cannot iput it under
|
||||
* inode_sb_list_lock. So we keep the reference and iput it
|
||||
* s_inode_list_lock. So we keep the reference and iput it
|
||||
* later.
|
||||
*/
|
||||
iput(old_inode);
|
||||
|
@ -2158,10 +2171,11 @@ static void wait_sb_inodes(struct super_block *sb)
|
|||
|
||||
cond_resched();
|
||||
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
spin_lock(&sb->s_inode_list_lock);
|
||||
}
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
iput(old_inode);
|
||||
mutex_unlock(&sb->s_sync_lock);
|
||||
}
|
||||
|
||||
static void __writeback_inodes_sb_nr(struct super_block *sb, unsigned long nr,
|
||||
|
|
50
fs/inode.c
50
fs/inode.c
|
@ -28,16 +28,16 @@
|
|||
* inode->i_state, inode->i_hash, __iget()
|
||||
* Inode LRU list locks protect:
|
||||
* inode->i_sb->s_inode_lru, inode->i_lru
|
||||
* inode_sb_list_lock protects:
|
||||
* sb->s_inodes, inode->i_sb_list
|
||||
* inode->i_sb->s_inode_list_lock protects:
|
||||
* inode->i_sb->s_inodes, inode->i_sb_list
|
||||
* bdi->wb.list_lock protects:
|
||||
* bdi->wb.b_{dirty,io,more_io,dirty_time}, inode->i_wb_list
|
||||
* bdi->wb.b_{dirty,io,more_io,dirty_time}, inode->i_io_list
|
||||
* inode_hash_lock protects:
|
||||
* inode_hashtable, inode->i_hash
|
||||
*
|
||||
* Lock ordering:
|
||||
*
|
||||
* inode_sb_list_lock
|
||||
* inode->i_sb->s_inode_list_lock
|
||||
* inode->i_lock
|
||||
* Inode LRU list locks
|
||||
*
|
||||
|
@ -45,7 +45,7 @@
|
|||
* inode->i_lock
|
||||
*
|
||||
* inode_hash_lock
|
||||
* inode_sb_list_lock
|
||||
* inode->i_sb->s_inode_list_lock
|
||||
* inode->i_lock
|
||||
*
|
||||
* iunique_lock
|
||||
|
@ -57,8 +57,6 @@ static unsigned int i_hash_shift __read_mostly;
|
|||
static struct hlist_head *inode_hashtable __read_mostly;
|
||||
static __cacheline_aligned_in_smp DEFINE_SPINLOCK(inode_hash_lock);
|
||||
|
||||
__cacheline_aligned_in_smp DEFINE_SPINLOCK(inode_sb_list_lock);
|
||||
|
||||
/*
|
||||
* Empty aops. Can be used for the cases where the user does not
|
||||
* define any of the address_space operations.
|
||||
|
@ -359,7 +357,7 @@ void inode_init_once(struct inode *inode)
|
|||
memset(inode, 0, sizeof(*inode));
|
||||
INIT_HLIST_NODE(&inode->i_hash);
|
||||
INIT_LIST_HEAD(&inode->i_devices);
|
||||
INIT_LIST_HEAD(&inode->i_wb_list);
|
||||
INIT_LIST_HEAD(&inode->i_io_list);
|
||||
INIT_LIST_HEAD(&inode->i_lru);
|
||||
address_space_init_once(&inode->i_data);
|
||||
i_size_ordered_init(inode);
|
||||
|
@ -426,18 +424,18 @@ static void inode_lru_list_del(struct inode *inode)
|
|||
*/
|
||||
void inode_sb_list_add(struct inode *inode)
|
||||
{
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
spin_lock(&inode->i_sb->s_inode_list_lock);
|
||||
list_add(&inode->i_sb_list, &inode->i_sb->s_inodes);
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&inode->i_sb->s_inode_list_lock);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(inode_sb_list_add);
|
||||
|
||||
static inline void inode_sb_list_del(struct inode *inode)
|
||||
{
|
||||
if (!list_empty(&inode->i_sb_list)) {
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
spin_lock(&inode->i_sb->s_inode_list_lock);
|
||||
list_del_init(&inode->i_sb_list);
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&inode->i_sb->s_inode_list_lock);
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -527,8 +525,8 @@ static void evict(struct inode *inode)
|
|||
BUG_ON(!(inode->i_state & I_FREEING));
|
||||
BUG_ON(!list_empty(&inode->i_lru));
|
||||
|
||||
if (!list_empty(&inode->i_wb_list))
|
||||
inode_wb_list_del(inode);
|
||||
if (!list_empty(&inode->i_io_list))
|
||||
inode_io_list_del(inode);
|
||||
|
||||
inode_sb_list_del(inode);
|
||||
|
||||
|
@ -577,6 +575,7 @@ static void dispose_list(struct list_head *head)
|
|||
list_del_init(&inode->i_lru);
|
||||
|
||||
evict(inode);
|
||||
cond_resched();
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -594,7 +593,8 @@ void evict_inodes(struct super_block *sb)
|
|||
struct inode *inode, *next;
|
||||
LIST_HEAD(dispose);
|
||||
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
again:
|
||||
spin_lock(&sb->s_inode_list_lock);
|
||||
list_for_each_entry_safe(inode, next, &sb->s_inodes, i_sb_list) {
|
||||
if (atomic_read(&inode->i_count))
|
||||
continue;
|
||||
|
@ -609,8 +609,20 @@ void evict_inodes(struct super_block *sb)
|
|||
inode_lru_list_del(inode);
|
||||
spin_unlock(&inode->i_lock);
|
||||
list_add(&inode->i_lru, &dispose);
|
||||
|
||||
/*
|
||||
* We can have a ton of inodes to evict at unmount time given
|
||||
* enough memory, check to see if we need to go to sleep for a
|
||||
* bit so we don't livelock.
|
||||
*/
|
||||
if (need_resched()) {
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
cond_resched();
|
||||
dispose_list(&dispose);
|
||||
goto again;
|
||||
}
|
||||
}
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
|
||||
dispose_list(&dispose);
|
||||
}
|
||||
|
@ -631,7 +643,7 @@ int invalidate_inodes(struct super_block *sb, bool kill_dirty)
|
|||
struct inode *inode, *next;
|
||||
LIST_HEAD(dispose);
|
||||
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
spin_lock(&sb->s_inode_list_lock);
|
||||
list_for_each_entry_safe(inode, next, &sb->s_inodes, i_sb_list) {
|
||||
spin_lock(&inode->i_lock);
|
||||
if (inode->i_state & (I_NEW | I_FREEING | I_WILL_FREE)) {
|
||||
|
@ -654,7 +666,7 @@ int invalidate_inodes(struct super_block *sb, bool kill_dirty)
|
|||
spin_unlock(&inode->i_lock);
|
||||
list_add(&inode->i_lru, &dispose);
|
||||
}
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
|
||||
dispose_list(&dispose);
|
||||
|
||||
|
@ -890,7 +902,7 @@ struct inode *new_inode(struct super_block *sb)
|
|||
{
|
||||
struct inode *inode;
|
||||
|
||||
spin_lock_prefetch(&inode_sb_list_lock);
|
||||
spin_lock_prefetch(&sb->s_inode_list_lock);
|
||||
|
||||
inode = new_inode_pseudo(sb);
|
||||
if (inode)
|
||||
|
|
|
@ -112,14 +112,13 @@ extern int vfs_open(const struct path *, struct file *, const struct cred *);
|
|||
/*
|
||||
* inode.c
|
||||
*/
|
||||
extern spinlock_t inode_sb_list_lock;
|
||||
extern long prune_icache_sb(struct super_block *sb, struct shrink_control *sc);
|
||||
extern void inode_add_lru(struct inode *inode);
|
||||
|
||||
/*
|
||||
* fs-writeback.c
|
||||
*/
|
||||
extern void inode_wb_list_del(struct inode *inode);
|
||||
extern void inode_io_list_del(struct inode *inode);
|
||||
|
||||
extern long get_nr_dirty_inodes(void);
|
||||
extern void evict_inodes(struct super_block *);
|
||||
|
|
|
@ -163,17 +163,17 @@ int fsnotify_add_inode_mark(struct fsnotify_mark *mark,
|
|||
|
||||
/**
|
||||
* fsnotify_unmount_inodes - an sb is unmounting. handle any watched inodes.
|
||||
* @list: list of inodes being unmounted (sb->s_inodes)
|
||||
* @sb: superblock being unmounted.
|
||||
*
|
||||
* Called during unmount with no locks held, so needs to be safe against
|
||||
* concurrent modifiers. We temporarily drop inode_sb_list_lock and CAN block.
|
||||
* concurrent modifiers. We temporarily drop sb->s_inode_list_lock and CAN block.
|
||||
*/
|
||||
void fsnotify_unmount_inodes(struct list_head *list)
|
||||
void fsnotify_unmount_inodes(struct super_block *sb)
|
||||
{
|
||||
struct inode *inode, *next_i, *need_iput = NULL;
|
||||
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
list_for_each_entry_safe(inode, next_i, list, i_sb_list) {
|
||||
spin_lock(&sb->s_inode_list_lock);
|
||||
list_for_each_entry_safe(inode, next_i, &sb->s_inodes, i_sb_list) {
|
||||
struct inode *need_iput_tmp;
|
||||
|
||||
/*
|
||||
|
@ -209,7 +209,7 @@ void fsnotify_unmount_inodes(struct list_head *list)
|
|||
spin_unlock(&inode->i_lock);
|
||||
|
||||
/* In case the dropping of a reference would nuke next_i. */
|
||||
while (&next_i->i_sb_list != list) {
|
||||
while (&next_i->i_sb_list != &sb->s_inodes) {
|
||||
spin_lock(&next_i->i_lock);
|
||||
if (!(next_i->i_state & (I_FREEING | I_WILL_FREE)) &&
|
||||
atomic_read(&next_i->i_count)) {
|
||||
|
@ -224,12 +224,12 @@ void fsnotify_unmount_inodes(struct list_head *list)
|
|||
}
|
||||
|
||||
/*
|
||||
* We can safely drop inode_sb_list_lock here because either
|
||||
* We can safely drop s_inode_list_lock here because either
|
||||
* we actually hold references on both inode and next_i or
|
||||
* end of list. Also no new inodes will be added since the
|
||||
* umount has begun.
|
||||
*/
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
|
||||
if (need_iput_tmp)
|
||||
iput(need_iput_tmp);
|
||||
|
@ -241,7 +241,7 @@ void fsnotify_unmount_inodes(struct list_head *list)
|
|||
|
||||
iput(inode);
|
||||
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
spin_lock(&sb->s_inode_list_lock);
|
||||
}
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
}
|
||||
|
|
|
@ -923,7 +923,7 @@ static void add_dquot_ref(struct super_block *sb, int type)
|
|||
int reserved = 0;
|
||||
#endif
|
||||
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
spin_lock(&sb->s_inode_list_lock);
|
||||
list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
|
||||
spin_lock(&inode->i_lock);
|
||||
if ((inode->i_state & (I_FREEING|I_WILL_FREE|I_NEW)) ||
|
||||
|
@ -934,7 +934,7 @@ static void add_dquot_ref(struct super_block *sb, int type)
|
|||
}
|
||||
__iget(inode);
|
||||
spin_unlock(&inode->i_lock);
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
|
||||
#ifdef CONFIG_QUOTA_DEBUG
|
||||
if (unlikely(inode_get_rsv_space(inode) > 0))
|
||||
|
@ -946,15 +946,15 @@ static void add_dquot_ref(struct super_block *sb, int type)
|
|||
/*
|
||||
* We hold a reference to 'inode' so it couldn't have been
|
||||
* removed from s_inodes list while we dropped the
|
||||
* inode_sb_list_lock We cannot iput the inode now as we can be
|
||||
* s_inode_list_lock. We cannot iput the inode now as we can be
|
||||
* holding the last reference and we cannot iput it under
|
||||
* inode_sb_list_lock. So we keep the reference and iput it
|
||||
* s_inode_list_lock. So we keep the reference and iput it
|
||||
* later.
|
||||
*/
|
||||
old_inode = inode;
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
spin_lock(&sb->s_inode_list_lock);
|
||||
}
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
iput(old_inode);
|
||||
|
||||
#ifdef CONFIG_QUOTA_DEBUG
|
||||
|
@ -1023,7 +1023,7 @@ static void remove_dquot_ref(struct super_block *sb, int type,
|
|||
struct inode *inode;
|
||||
int reserved = 0;
|
||||
|
||||
spin_lock(&inode_sb_list_lock);
|
||||
spin_lock(&sb->s_inode_list_lock);
|
||||
list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
|
||||
/*
|
||||
* We have to scan also I_NEW inodes because they can already
|
||||
|
@ -1039,7 +1039,7 @@ static void remove_dquot_ref(struct super_block *sb, int type,
|
|||
}
|
||||
spin_unlock(&dq_data_lock);
|
||||
}
|
||||
spin_unlock(&inode_sb_list_lock);
|
||||
spin_unlock(&sb->s_inode_list_lock);
|
||||
#ifdef CONFIG_QUOTA_DEBUG
|
||||
if (reserved) {
|
||||
printk(KERN_WARNING "VFS (%s): Writes happened after quota"
|
||||
|
|
|
@ -203,7 +203,9 @@ static struct super_block *alloc_super(struct file_system_type *type, int flags)
|
|||
s->s_flags = flags;
|
||||
INIT_HLIST_NODE(&s->s_instances);
|
||||
INIT_HLIST_BL_HEAD(&s->s_anon);
|
||||
mutex_init(&s->s_sync_lock);
|
||||
INIT_LIST_HEAD(&s->s_inodes);
|
||||
spin_lock_init(&s->s_inode_list_lock);
|
||||
|
||||
if (list_lru_init_memcg(&s->s_dentry_lru))
|
||||
goto fail;
|
||||
|
@ -412,7 +414,7 @@ void generic_shutdown_super(struct super_block *sb)
|
|||
sync_filesystem(sb);
|
||||
sb->s_flags &= ~MS_ACTIVE;
|
||||
|
||||
fsnotify_unmount_inodes(&sb->s_inodes);
|
||||
fsnotify_unmount_inodes(sb);
|
||||
|
||||
evict_inodes(sb);
|
||||
|
||||
|
|
|
@ -637,7 +637,7 @@ struct inode {
|
|||
unsigned long dirtied_time_when;
|
||||
|
||||
struct hlist_node i_hash;
|
||||
struct list_head i_wb_list; /* backing dev IO list */
|
||||
struct list_head i_io_list; /* backing dev IO list */
|
||||
#ifdef CONFIG_CGROUP_WRITEBACK
|
||||
struct bdi_writeback *i_wb; /* the associated cgroup wb */
|
||||
|
||||
|
@ -1303,7 +1303,6 @@ struct super_block {
|
|||
#endif
|
||||
const struct xattr_handler **s_xattr;
|
||||
|
||||
struct list_head s_inodes; /* all inodes */
|
||||
struct hlist_bl_head s_anon; /* anonymous dentries for (nfs) exporting */
|
||||
struct list_head s_mounts; /* list of mounts; _not_ for fs use */
|
||||
struct block_device *s_bdev;
|
||||
|
@ -1370,10 +1369,17 @@ struct super_block {
|
|||
struct list_lru s_inode_lru ____cacheline_aligned_in_smp;
|
||||
struct rcu_head rcu;
|
||||
struct work_struct destroy_work;
|
||||
|
||||
struct mutex s_sync_lock; /* sync serialisation lock */
|
||||
|
||||
/*
|
||||
* Indicates how deep in a filesystem stack this SB is
|
||||
*/
|
||||
int s_stack_depth;
|
||||
|
||||
/* s_inode_list_lock protects s_inodes */
|
||||
spinlock_t s_inode_list_lock ____cacheline_aligned_in_smp;
|
||||
struct list_head s_inodes; /* all inodes */
|
||||
};
|
||||
|
||||
extern struct timespec current_fs_time(struct super_block *sb);
|
||||
|
@ -2607,7 +2613,7 @@ static inline void insert_inode_hash(struct inode *inode)
|
|||
extern void __remove_inode_hash(struct inode *);
|
||||
static inline void remove_inode_hash(struct inode *inode)
|
||||
{
|
||||
if (!inode_unhashed(inode))
|
||||
if (!inode_unhashed(inode) && !hlist_fake(&inode->i_hash))
|
||||
__remove_inode_hash(inode);
|
||||
}
|
||||
|
||||
|
|
|
@ -357,7 +357,7 @@ extern void fsnotify_clear_marks_by_group_flags(struct fsnotify_group *group, un
|
|||
extern void fsnotify_clear_marks_by_group(struct fsnotify_group *group);
|
||||
extern void fsnotify_get_mark(struct fsnotify_mark *mark);
|
||||
extern void fsnotify_put_mark(struct fsnotify_mark *mark);
|
||||
extern void fsnotify_unmount_inodes(struct list_head *list);
|
||||
extern void fsnotify_unmount_inodes(struct super_block *sb);
|
||||
|
||||
/* put here because inotify does some weird stuff when destroying watches */
|
||||
extern void fsnotify_init_event(struct fsnotify_event *event,
|
||||
|
@ -393,7 +393,7 @@ static inline u32 fsnotify_get_cookie(void)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static inline void fsnotify_unmount_inodes(struct list_head *list)
|
||||
static inline void fsnotify_unmount_inodes(struct super_block *sb)
|
||||
{}
|
||||
|
||||
#endif /* CONFIG_FSNOTIFY */
|
||||
|
|
|
@ -672,6 +672,11 @@ static inline void hlist_add_fake(struct hlist_node *n)
|
|||
n->pprev = &n->next;
|
||||
}
|
||||
|
||||
static inline bool hlist_fake(struct hlist_node *h)
|
||||
{
|
||||
return h->pprev == &h->next;
|
||||
}
|
||||
|
||||
/*
|
||||
* Move a list from one list head to another. Fixup the pprev
|
||||
* reference of the first entry if it exists.
|
||||
|
|
|
@ -55,13 +55,13 @@ static int bdi_debug_stats_show(struct seq_file *m, void *v)
|
|||
|
||||
nr_dirty = nr_io = nr_more_io = nr_dirty_time = 0;
|
||||
spin_lock(&wb->list_lock);
|
||||
list_for_each_entry(inode, &wb->b_dirty, i_wb_list)
|
||||
list_for_each_entry(inode, &wb->b_dirty, i_io_list)
|
||||
nr_dirty++;
|
||||
list_for_each_entry(inode, &wb->b_io, i_wb_list)
|
||||
list_for_each_entry(inode, &wb->b_io, i_io_list)
|
||||
nr_io++;
|
||||
list_for_each_entry(inode, &wb->b_more_io, i_wb_list)
|
||||
list_for_each_entry(inode, &wb->b_more_io, i_io_list)
|
||||
nr_more_io++;
|
||||
list_for_each_entry(inode, &wb->b_dirty_time, i_wb_list)
|
||||
list_for_each_entry(inode, &wb->b_dirty_time, i_io_list)
|
||||
if (inode->i_state & I_DIRTY_TIME)
|
||||
nr_dirty_time++;
|
||||
spin_unlock(&wb->list_lock);
|
||||
|
|
Loading…
Reference in New Issue