openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: unisys: use schedule_timeout_interruptible() 

API consolidation with coccinelle found:
./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19:
        consolidation with schedule_timeout_*() recommended

This is a 1:1 conversion with respect to schedule_timeout() to the
schedule_timeout_interruptible() helper only - so only an API
consolidation to improve readability. The hard coded timeout of 10
jiffies is HZ dependent which it should not be, so it is converted
with msecs_to_jiffies.

Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
CONFIG_UNISYSSPAR=y, CONFIG_UNISYS_VISORBUS=m

Patch is against 4.1-rc5 (localversion-next is -next-20150529)

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Nicholas Mc Guire 2015-05-29 17:31:16 +02:00 committed by Greg Kroah-Hartman
parent 7726f81357
commit 084861124d
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/unisys/visorbus/periodic_work.c
View File

@ -192,8 +192,7 @@ bool visor_periodic_work_stop(struct periodic_work *pw)
} }
if (pw->is_scheduled) { if (pw->is_scheduled) {
write_unlock(&pw->lock); write_unlock(&pw->lock);
__set_current_state(TASK_INTERRUPTIBLE); schedule_timeout_interruptible(msecs_to_jiffies(10));
schedule_timeout(10);
write_lock(&pw->lock); write_lock(&pw->lock);
} else { } else {
pw->want_to_stop = false; pw->want_to_stop = false;