cifs: Add get_security_type_str function to return sec type.

This code is more organized and robust.

Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
Signed-off-by: Roberto Bergantinos Corpas <rbergant@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Kenneth D'souza 2020-06-09 10:12:10 +05:30 committed by Steve French
parent 5865985416
commit 0b0430c6a1
2 changed files with 19 additions and 3 deletions

View File

@ -221,8 +221,6 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v)
struct cifs_ses *ses; struct cifs_ses *ses;
struct cifs_tcon *tcon; struct cifs_tcon *tcon;
int i, j; int i, j;
const char *security_types[] = {"Unspecified", "LANMAN", "NTLM",
"NTLMv2", "RawNTLMSSP", "Kerberos"};
seq_puts(m, seq_puts(m,
"Display Internal CIFS Data Structures for Debugging\n" "Display Internal CIFS Data Structures for Debugging\n"
@ -379,7 +377,7 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v)
} }
seq_printf(m,"Security type: %s\n", seq_printf(m,"Security type: %s\n",
security_types[server->ops->select_sectype(server, ses->sectype)]); get_security_type_str(server->ops->select_sectype(server, ses->sectype)));
if (server->rdma) if (server->rdma)
seq_printf(m, "RDMA\n\t"); seq_printf(m, "RDMA\n\t");

View File

@ -2008,6 +2008,24 @@ extern struct smb_version_values smb302_values;
extern struct smb_version_operations smb311_operations; extern struct smb_version_operations smb311_operations;
extern struct smb_version_values smb311_values; extern struct smb_version_values smb311_values;
static inline char *get_security_type_str(enum securityEnum sectype)
{
switch (sectype) {
case RawNTLMSSP:
return "RawNTLMSSP";
case Kerberos:
return "Kerberos";
case NTLMv2:
return "NTLMv2";
case NTLM:
return "NTLM";
case LANMAN:
return "LANMAN";
default:
return "Unknown";
}
}
static inline bool is_smb1_server(struct TCP_Server_Info *server) static inline bool is_smb1_server(struct TCP_Server_Info *server)
{ {
return strcmp(server->vals->version_string, SMB1_VERSION_STRING) == 0; return strcmp(server->vals->version_string, SMB1_VERSION_STRING) == 0;