openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

zd1211rw: use struct_size() helper 

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes, in particular in the
context in which this code is being used.

So, replace code of the following form:

sizeof(struct usb_req_write_regs) + count * sizeof(struct reg_data)

with:

struct_size(req, reg_writes, count)

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Gustavo A. R. Silva 2019-04-03 13:59:05 -05:00 committed by Kalle Valo
parent ae187ba915
commit 0c7beb2db9
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/wireless/zydas/zd1211rw/zd_usb.c
View File

@ -1917,8 +1917,7 @@ int zd_usb_iowrite16v_async(struct zd_usb *usb, const struct zd_ioreq16 *ioreqs,
if (!urb) if (!urb)
return -ENOMEM; return -ENOMEM;
req_len = sizeof(struct usb_req_write_regs) + req_len = struct_size(req, reg_writes, count);
count * sizeof(struct reg_data);
req = kmalloc(req_len, GFP_KERNEL); req = kmalloc(req_len, GFP_KERNEL);
if (!req) { if (!req) {
r = -ENOMEM; r = -ENOMEM;