openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

hwrng: exynos - Fix runtime PM imbalance on error 

pm_runtime_resume_and_get() wraps around pm_runtime_get_sync() and
decrements the runtime PM usage counter in case the latter function
fails and keeps the counter balanced.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Łukasz Stelmach 2021-05-05 20:29:14 +02:00 committed by Herbert Xu
parent b51dcf05c1
commit 0cdbabf8bb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/char/hw_random/exynos-trng.c
View File

@ -132,7 +132,7 @@ static int exynos_trng_probe(struct platform_device *pdev)
return PTR_ERR(trng->mem); return PTR_ERR(trng->mem);
pm_runtime_enable(&pdev->dev); pm_runtime_enable(&pdev->dev);
ret = pm_runtime_get_sync(&pdev->dev); ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, "Could not get runtime PM.\n"); dev_err(&pdev->dev, "Could not get runtime PM.\n");
goto err_pm_get; goto err_pm_get;
@ -165,7 +165,7 @@ static int exynos_trng_probe(struct platform_device *pdev)
clk_disable_unprepare(trng->clk); clk_disable_unprepare(trng->clk);
err_clock: err_clock:
pm_runtime_put_sync(&pdev->dev); pm_runtime_put_noidle(&pdev->dev);
err_pm_get: err_pm_get:
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);