openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

selftests: media_tests: return Kselftest Skip code for skipped tests 

When media_tests test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as a
fail by the Kselftest framework. This leads to false negative result
even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Change it to use ksft_exit_skip() when the test is skipped.

Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
This commit is contained in:
Shuah Khan (Samsung OSG) 2018-05-04 12:06:46 -06:00
parent f9fedb2719
commit 113812868c
3 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/testing/selftests/media_tests/Makefile
View File

@ -1,5 +1,6 @@
# SPDX-License-Identifier: GPL-2.0
#
CFLAGS += -I../ -I../../../../usr/include/
TEST_GEN_PROGS := media_device_test media_device_open video_device_test
all: $(TEST_GEN_PROGS)
include ../lib.mk

8
tools/testing/selftests/media_tests/media_device_open.c
View File

@ -34,6 +34,8 @@
#include <sys/stat.h>
#include <linux/media.h>
#include "../kselftest.h"
int main(int argc, char **argv)
{
int opt;
@ -61,10 +63,8 @@ int main(int argc, char **argv)
}
}
if (getuid() != 0) {
printf("Please run the test as root - Exiting.\n");
exit(-1);
}
if (getuid() != 0)
ksft_exit_skip("Please run the test as root - Exiting.\n");
/* Open Media device and keep it open */
fd = open(media_device, O_RDWR);

8
tools/testing/selftests/media_tests/media_device_test.c
View File

@ -39,6 +39,8 @@
#include <time.h>
#include <linux/media.h>
#include "../kselftest.h"
int main(int argc, char **argv)
{
int opt;
@ -66,10 +68,8 @@ int main(int argc, char **argv)
}
}
if (getuid() != 0) {
printf("Please run the test as root - Exiting.\n");
exit(-1);
}
if (getuid() != 0)
ksft_exit_skip("Please run the test as root - Exiting.\n");
/* Generate random number of interations */
srand((unsigned int) time(NULL));