openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: ethernet: bgmac: Fix return value check in bgmac_probe() 

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Wei Yongjun 2016-07-12 00:17:28 +00:00 committed by David S. Miller
parent cf81b2ccad
commit 12c2e32f14
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/broadcom/bgmac-platform.c
View File

@ -141,7 +141,7 @@ static int bgmac_probe(struct platform_device *pdev)
} }
bgmac->plat.idm_base = devm_ioremap_resource(&pdev->dev, regs); bgmac->plat.idm_base = devm_ioremap_resource(&pdev->dev, regs);
if (!bgmac->plat.idm_base) { if (IS_ERR(bgmac->plat.idm_base)) {
dev_err(&pdev->dev, "Unable to map idm resource\n"); dev_err(&pdev->dev, "Unable to map idm resource\n");
return PTR_ERR(bgmac->plat.idm_base); return PTR_ERR(bgmac->plat.idm_base);
} }