openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

perf evlist: Remove evlist->overwrite 

evlist->overwrite is set to false in all users. It can be removed.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Link: http://lkml.kernel.org/r/20171203020044.81680-4-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Wang Nan 2017-12-03 02:00:39 +00:00 committed by Arnaldo Carvalho de Melo
parent 7a276ff6c3
commit 144b9a4fc5
3 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/perf/builtin-record.c
View File

@ -500,7 +500,7 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli
struct auxtrace_mmap *mm = &maps[i].auxtrace_mmap; struct auxtrace_mmap *mm = &maps[i].auxtrace_mmap;
if (maps[i].base) { if (maps[i].base) {
if (perf_mmap__push(&maps[i], evlist->overwrite, backward, rec, record__pushfn) != 0) { if (perf_mmap__push(&maps[i], false, backward, rec, record__pushfn) != 0) {
rc = -1; rc = -1;
goto out; goto out;
} }

5
tools/perf/util/evlist.c
View File

@ -711,7 +711,7 @@ union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist, int
* No need for read-write ring buffer: kernel stop outputting when * No need for read-write ring buffer: kernel stop outputting when
* it hit md->prev (perf_mmap__consume()). * it hit md->prev (perf_mmap__consume()).
*/ */
return perf_mmap__read_forward(md, evlist->overwrite); return perf_mmap__read_forward(md, false);
} }
union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx) union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx)
@ -738,7 +738,7 @@ void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx)
void perf_evlist__mmap_consume(struct perf_evlist *evlist, int idx) void perf_evlist__mmap_consume(struct perf_evlist *evlist, int idx)
{ {
perf_mmap__consume(&evlist->mmap[idx], evlist->overwrite); perf_mmap__consume(&evlist->mmap[idx], false);
} }
static void perf_evlist__munmap_nofree(struct perf_evlist *evlist) static void perf_evlist__munmap_nofree(struct perf_evlist *evlist)
@ -1070,7 +1070,6 @@ int perf_evlist__mmap_ex(struct perf_evlist *evlist, unsigned int pages,
if (evlist->pollfd.entries == NULL && perf_evlist__alloc_pollfd(evlist) < 0) if (evlist->pollfd.entries == NULL && perf_evlist__alloc_pollfd(evlist) < 0)
return -ENOMEM; return -ENOMEM;
evlist->overwrite = false;
evlist->mmap_len = perf_evlist__mmap_size(pages); evlist->mmap_len = perf_evlist__mmap_size(pages);
pr_debug("mmap size %zuB\n", evlist->mmap_len); pr_debug("mmap size %zuB\n", evlist->mmap_len);
mp.mask = evlist->mmap_len - page_size - 1; mp.mask = evlist->mmap_len - page_size - 1;

1
tools/perf/util/evlist.h
View File

@ -31,7 +31,6 @@ struct perf_evlist {
int nr_entries; int nr_entries;
int nr_groups; int nr_groups;
int nr_mmaps; int nr_mmaps;
bool overwrite;
bool enabled; bool enabled;
bool has_user_cpus; bool has_user_cpus;
size_t mmap_len; size_t mmap_len;