openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: i4l: pcbit: layer2: use setup_timer() and mod_timer(). 

Use setup_timer() instead of init_timer(), being the preferred/standard
way to set a timer up.

Also, quoting the mod_timer() function comment:
-> mod_timer() is a more efficient way to update the expire field of an
   active timer (if the timer is inactive it will be activated).

Use setup_timer and mod_timer to setup and arm a timer, to make the code
cleaner and easier to read.

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Muhammad Falak R Wani 2016-05-11 19:25:01 +05:30 committed by Greg Kroah-Hartman
parent 8df7a2221c
commit 1735d9e97c
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/i4l/pcbit/layer2.c
View File

@ -645,11 +645,9 @@ pcbit_l2_error(struct pcbit_dev *dev)
dev->l2_state = L2_DOWN;
init_timer(&dev->error_recover_timer);
dev->error_recover_timer.function = &pcbit_l2_err_recover;
dev->error_recover_timer.data = (ulong) dev;
dev->error_recover_timer.expires = jiffies + ERRTIME;
add_timer(&dev->error_recover_timer);
setup_timer(&dev->error_recover_timer, &pcbit_l2_err_recover,
(ulong)dev);
mod_timer(&dev->error_recover_timer, jiffies + ERRTIME);
}
}