openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

USB: EHCI: remove useless test 

This patch (as1605) removes a useless test from the EHCI debugfs
code.  There's no point checking whether p.qh is non-NULL; we already
know it is and in any case it gets dereferenced aerlier in the
function.

The useless test was identified by smatch.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Alan Stern 2012-09-19 17:00:55 -04:00 committed by Greg Kroah-Hartman
parent 0cb72e184a
commit 17dcfc9bd3
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/host/ehci-dbg.c
View File

@ -653,10 +653,8 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf)
seen [seen_count++].qh = p.qh; seen [seen_count++].qh = p.qh;
} else } else
temp = 0; temp = 0;
if (p.qh) {
tag = Q_NEXT_TYPE(ehci, hw->hw_next); tag = Q_NEXT_TYPE(ehci, hw->hw_next);
p = p.qh->qh_next; p = p.qh->qh_next;
}
break; break;
case Q_TYPE_FSTN: case Q_TYPE_FSTN:
temp = scnprintf (next, size, temp = scnprintf (next, size,