openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

coredump: elf_fdpic_core_dump: use core_state->dumper list 

Kill the nasty rcu_read_lock() + do_each_thread() loop, use the list
encoded in mm->core_state instead, s/GFP_ATOMIC/GFP_KERNEL/.

This patch allows futher cleanups in binfmt_elf_fdpic.c.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Roland McGrath <roland@redhat.com>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Oleg Nesterov 2008-07-25 01:47:45 -07:00 committed by Linus Torvalds
parent 83914441f9
commit 182c515fd2
1 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
fs/binfmt_elf_fdpic.c
View File

@ -1573,7 +1573,6 @@ static int elf_fdpic_core_dump(long signr, struct pt_regs *regs,
struct memelfnote *notes = NULL; struct memelfnote *notes = NULL;
struct elf_prstatus *prstatus = NULL; /* NT_PRSTATUS */ struct elf_prstatus *prstatus = NULL; /* NT_PRSTATUS */
struct elf_prpsinfo *psinfo = NULL; /* NT_PRPSINFO */ struct elf_prpsinfo *psinfo = NULL; /* NT_PRPSINFO */
struct task_struct *g, *p;
LIST_HEAD(thread_list); LIST_HEAD(thread_list);
struct list_head *t; struct list_head *t;
elf_fpregset_t *fpu = NULL; elf_fpregset_t *fpu = NULL;
@ -1622,23 +1621,19 @@ static int elf_fdpic_core_dump(long signr, struct pt_regs *regs,
#endif #endif
if (signr) { if (signr) {
struct core_thread *ct;
struct elf_thread_status *tmp; struct elf_thread_status *tmp;
rcu_read_lock();
do_each_thread(g,p)
if (current->mm == p->mm && current != p) {
if (p->flags & PF_KTHREAD)
continue;
tmp = kzalloc(sizeof(*tmp), GFP_ATOMIC); for (ct = current->mm->core_state->dumper.next;
if (!tmp) { ct; ct = ct->next) {
rcu_read_unlock(); tmp = kzalloc(sizeof(*tmp), GFP_KERNEL);
goto cleanup; if (!tmp)
} goto cleanup;
tmp->thread = p;
list_add(&tmp->list, &thread_list); tmp->thread = ct->task;
} list_add(&tmp->list, &thread_list);
while_each_thread(g,p); }
rcu_read_unlock();
list_for_each(t, &thread_list) { list_for_each(t, &thread_list) {
struct elf_thread_status *tmp; struct elf_thread_status *tmp;
int sz; int sz;