openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm/amdgpu: Fix error handling in amdgpu_ras_recovery_init 

Don't set a struct pointer to NULL before freeing its members. It's
hard to see what's happening due to a local pointer-to-pointer data
aliasing con->eh_data.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Tested-by: Philip Cox <Philip.Cox@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Felix Kuehling 2019-10-03 17:54:57 -04:00 committed by Alex Deucher
parent 317a8d9eb6
commit 1995b3a35f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
View File

@ -1542,10 +1542,10 @@ int amdgpu_ras_recovery_init(struct amdgpu_device *adev)
release: release:
amdgpu_ras_release_bad_pages(adev); amdgpu_ras_release_bad_pages(adev);
free: free:
con->eh_data = NULL;
kfree((*data)->bps); kfree((*data)->bps);
kfree((*data)->bps_bo); kfree((*data)->bps_bo);
kfree(*data); kfree(*data);
con->eh_data = NULL;
out: out:
DRM_WARN("Failed to initialize ras recovery!\n"); DRM_WARN("Failed to initialize ras recovery!\n");