openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

USB: gtco.c: fix a use-before-check 

NULL checks should be before the first dereference.

Spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Adrian Bunk 2007-03-19 10:26:32 +01:00 committed by Greg Kroah-Hartman
parent f81ee4d528
commit 1b55fa2d43
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/input/gtco.c
View File

@ -1047,13 +1047,10 @@ static void gtco_disconnect(struct usb_interface *interface)
/* Grab private device ptr */ /* Grab private device ptr */
struct gtco *device = usb_get_intfdata (interface); struct gtco *device = usb_get_intfdata (interface);
struct input_dev *inputdev;
inputdev = device->inputdevice;
/* Now reverse all the registration stuff */ /* Now reverse all the registration stuff */
if (device) { if (device) {
input_unregister_device(inputdev); input_unregister_device(device->inputdevice);
usb_kill_urb(device->urbinfo); usb_kill_urb(device->urbinfo);
usb_free_urb(device->urbinfo); usb_free_urb(device->urbinfo);
usb_buffer_free(device->usbdev, REPORT_MAX_SIZE, usb_buffer_free(device->usbdev, REPORT_MAX_SIZE,