openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

scsi: qla2xxx: Suppress endianness complaints in qla2x00_configure_local_loop() 

Instead of changing endianness in-place, write the data in CPU endian
format in another buffer and copy that buffer back. This patch does not
change any functionality but silences some sparse endianness warnings.

Link: https://lore.kernel.org/r/20200220043441.20504-3-bvanassche@acm.org
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Quinn Tran <qutran@marvell.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Bart Van Assche 2020-02-19 20:34:38 -08:00 committed by Martin K. Petersen
parent c81ef0ed44
commit 1ee5ac365c
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/qla2xxx/qla_def.h
View File

@ -414,7 +414,7 @@ struct els_logo_payload {
struct els_plogi_payload { struct els_plogi_payload {
uint8_t opcode; uint8_t opcode;
uint8_t rsvd[3]; uint8_t rsvd[3];
uint8_t data[112]; __be32 data[112 / 4];
}; };
struct ct_arg { struct ct_arg {

13
drivers/scsi/qla2xxx/qla_init.c
View File

@ -5076,7 +5076,7 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha)
if (N2N_TOPO(ha)) { if (N2N_TOPO(ha)) {
if (test_and_clear_bit(N2N_LOGIN_NEEDED, &vha->dpc_flags)) { if (test_and_clear_bit(N2N_LOGIN_NEEDED, &vha->dpc_flags)) {
/* borrowing */ /* borrowing */
u32 *bp, i, sz; u32 *bp, sz;
memset(ha->init_cb, 0, ha->init_cb_size); memset(ha->init_cb, 0, ha->init_cb_size);
sz = min_t(int, sizeof(struct els_plogi_payload), sz = min_t(int, sizeof(struct els_plogi_payload),
@ -5084,13 +5084,12 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha)
rval = qla24xx_get_port_login_templ(vha, rval = qla24xx_get_port_login_templ(vha,
ha->init_cb_dma, (void *)ha->init_cb, sz); ha->init_cb_dma, (void *)ha->init_cb, sz);
if (rval == QLA_SUCCESS) { if (rval == QLA_SUCCESS) {
bp = (uint32_t *)ha->init_cb; __be32 *q = &ha->plogi_els_payld.data[0];
for (i = 0; i < sz/4 ; i++, bp++)
*bp = cpu_to_be32(*bp);
memcpy(&ha->plogi_els_payld.data, bp = (uint32_t *)ha->init_cb;
(void *)ha->init_cb, cpu_to_be32_array(q, bp, sz / 4);
sizeof(ha->plogi_els_payld.data));
memcpy(bp, q, sizeof(ha->plogi_els_payld.data));
} else { } else {
ql_dbg(ql_dbg_init, vha, 0x00d1, ql_dbg(ql_dbg_init, vha, 0x00d1,
"PLOGI ELS param read fail.\n"); "PLOGI ELS param read fail.\n");