mirror of https://gitee.com/openkylin/linux.git
ARM: shmobile: R-Mobile: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child ( return child; | + of_node_put(child); ? return ...; ) ... } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
This commit is contained in:
parent
e5cf79d995
commit
1fd377b3fc
|
@ -342,8 +342,10 @@ static int __init rmobile_add_pm_domains(void __iomem *base,
|
|||
}
|
||||
|
||||
pd = kzalloc(sizeof(*pd), GFP_KERNEL);
|
||||
if (!pd)
|
||||
if (!pd) {
|
||||
of_node_put(np);
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
pd->genpd.name = np->name;
|
||||
pd->base = base;
|
||||
|
|
Loading…
Reference in New Issue