openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

gpio: brcmstb: Use list_for_each_entry at appropriate places 

Use list_for_each_entry to simplify the code a bit.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Axel Lin 2016-02-20 09:50:37 +08:00 committed by Linus Walleij
parent 2b99d32790
commit 21c4a0c852
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/gpio/gpio-brcmstb.c
View File

@ -233,17 +233,14 @@ static void brcmstb_gpio_irq_handler(struct irq_desc *desc)
struct gpio_chip *gc = irq_desc_get_handler_data(desc); struct gpio_chip *gc = irq_desc_get_handler_data(desc);
struct brcmstb_gpio_priv *priv = brcmstb_gpio_gc_to_priv(gc); struct brcmstb_gpio_priv *priv = brcmstb_gpio_gc_to_priv(gc);
struct irq_chip *chip = irq_desc_get_chip(desc); struct irq_chip *chip = irq_desc_get_chip(desc);
struct list_head *pos; struct brcmstb_gpio_bank *bank;
/* Interrupts weren't properly cleared during probe */ /* Interrupts weren't properly cleared during probe */
BUG_ON(!priv || !chip); BUG_ON(!priv || !chip);
chained_irq_enter(chip, desc); chained_irq_enter(chip, desc);
list_for_each(pos, &priv->bank_list) { list_for_each_entry(bank, &priv->bank_list, node)
struct brcmstb_gpio_bank *bank =
list_entry(pos, struct brcmstb_gpio_bank, node);
brcmstb_gpio_irq_bank_handler(bank); brcmstb_gpio_irq_bank_handler(bank);
}
chained_irq_exit(chip, desc); chained_irq_exit(chip, desc);
} }
@ -280,7 +277,6 @@ static int brcmstb_gpio_sanity_check_banks(struct device *dev,
static int brcmstb_gpio_remove(struct platform_device *pdev) static int brcmstb_gpio_remove(struct platform_device *pdev)
{ {
struct brcmstb_gpio_priv *priv = platform_get_drvdata(pdev); struct brcmstb_gpio_priv *priv = platform_get_drvdata(pdev);
struct list_head *pos;
struct brcmstb_gpio_bank *bank; struct brcmstb_gpio_bank *bank;
int ret = 0; int ret = 0;
@ -293,10 +289,9 @@ static int brcmstb_gpio_remove(struct platform_device *pdev)
* You can lose return values below, but we report all errors, and it's * You can lose return values below, but we report all errors, and it's
* more important to actually perform all of the steps. * more important to actually perform all of the steps.
*/ */
list_for_each(pos, &priv->bank_list) { list_for_each_entry(bank, &priv->bank_list, node)
bank = list_entry(pos, struct brcmstb_gpio_bank, node);
gpiochip_remove(&bank->gc); gpiochip_remove(&bank->gc);
}
if (priv->reboot_notifier.notifier_call) { if (priv->reboot_notifier.notifier_call) {
ret = unregister_reboot_notifier(&priv->reboot_notifier); ret = unregister_reboot_notifier(&priv->reboot_notifier);
if (ret) if (ret)