openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

leds-as3645a: Drop fwnode reference on ignored node 

If a node is ignored, do not get a reference to it. Fix the bug by moving
fwnode_handle_get() where a reference to an fwnode is saved for clarity.

Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
This commit is contained in:
Sakari Ailus 2019-12-04 09:56:42 +02:00 committed by Pavel Machek
parent 90a8e82d3c
commit 22cb0a76e0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/leds/leds-as3645a.c
View File

@ -493,16 +493,17 @@ static int as3645a_parse_node(struct as3645a *flash,
switch (id) { switch (id) {
case AS_LED_FLASH: case AS_LED_FLASH:
flash->flash_node = child; flash->flash_node = child;
fwnode_handle_get(child);
break; break;
case AS_LED_INDICATOR: case AS_LED_INDICATOR:
flash->indicator_node = child; flash->indicator_node = child;
fwnode_handle_get(child);
break; break;
default: default:
dev_warn(&flash->client->dev, dev_warn(&flash->client->dev,
"unknown LED %u encountered, ignoring\n", id); "unknown LED %u encountered, ignoring\n", id);
break; break;
} }
fwnode_handle_get(child);
} }
if (!flash->flash_node) { if (!flash->flash_node) {