openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

scsi: ufs: fix static checker errors in ufshcd_system_suspend 

This patch fixes newly introduced sparse warning in
ufshcd_system_suspend, introduced by UFS power management series.

Sparse warning:
drivers/scsi/ufs/ufshcd.c:5118 ufshcd_system_suspend()
error: we previously assumed 'hba' could be null (see line 5089)

To fix it, we return 0 in case HBA is not initialized or is
not powered.

Signed-off-by: Dolev Raviv <draviv@codeaurora.org>
Reviewed-by: Maya Erez <merez@codeaurora.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Dolev Raviv 2014-10-23 13:25:14 +03:00 committed by Christoph Hellwig
parent 5064636c75
commit 233b594bdf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/ufs/ufshcd.c
View File

@ -5104,7 +5104,7 @@ int ufshcd_system_suspend(struct ufs_hba *hba)
int ret = 0; int ret = 0;
if (!hba || !hba->is_powered) if (!hba || !hba->is_powered)
goto out; return 0;
if (pm_runtime_suspended(hba->dev)) { if (pm_runtime_suspended(hba->dev)) {
if (hba->rpm_lvl == hba->spm_lvl) if (hba->rpm_lvl == hba->spm_lvl)