openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: comedi: vmk80xx: remove private data 'attached' 

The 'attached' flag in the private data is set after the comedi_driver
(*auto_attach) function has completed successfully.

The only places it's checked are in rudimentary_check(), which does
some basic sanity checks before doing any of the subdevice operations,
and vmk80xx_auto_attach(), which is the comedi_driver (*auto_attach)
function.

The (*auto_attach) function can only be called as the result of a
successfull usb_driver (*probe). Part of the probe is to locate a
free slot in the static private data array. All free slots are
initialized to '0' so the 'attached' flag will always be cleared.

Remove the unneccessary 'attached' flag in the private data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-02-05 17:23:16 -07:00 committed by Greg Kroah-Hartman
parent b105ad8a78
commit 29d6dd3310
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/comedi/drivers/vmk80xx.c
View File

@ -210,7 +210,6 @@ struct vmk80xx_private {
unsigned char *usb_rx_buf; unsigned char *usb_rx_buf;
unsigned char *usb_tx_buf; unsigned char *usb_tx_buf;
unsigned long flags; unsigned long flags;
int attached;
}; };
static struct vmk80xx_private vmb[VMK80XX_MAX_BOARDS]; static struct vmk80xx_private vmb[VMK80XX_MAX_BOARDS];
@ -528,8 +527,6 @@ static int rudimentary_check(struct vmk80xx_private *devpriv, int dir)
{ {
if (!devpriv) if (!devpriv)
return -EFAULT; return -EFAULT;
if (!devpriv->attached)
return -ENODEV;
if (dir & DIR_IN) { if (dir & DIR_IN) {
if (test_bit(TRANS_IN_BUSY, &devpriv->flags)) if (test_bit(TRANS_IN_BUSY, &devpriv->flags))
return -EBUSY; return -EBUSY;
@ -1280,8 +1277,6 @@ static int vmk80xx_attach_common(struct comedi_device *dev,
s->insn_write = vmk80xx_pwm_winsn; s->insn_write = vmk80xx_pwm_winsn;
} }
devpriv->attached = 1;
up(&devpriv->limit_sem); up(&devpriv->limit_sem);
return 0; return 0;
@ -1300,8 +1295,6 @@ static int vmk80xx_auto_attach(struct comedi_device *dev,
break; break;
if (i == VMK80XX_MAX_BOARDS) if (i == VMK80XX_MAX_BOARDS)
ret = -ENODEV; ret = -ENODEV;
else if (vmb[i].attached)
ret = -EBUSY;
else else
ret = vmk80xx_attach_common(dev, &vmb[i]); ret = vmk80xx_attach_common(dev, &vmb[i]);
mutex_unlock(&glb_mutex); mutex_unlock(&glb_mutex);