openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: comedi: dt282x: dt282x_ai_insn_read() always fails 

In dt282x_ai_insn_read() we call this macro like:
wait_for(!mux_busy(), comedi_error(dev, "timeout\n"); return -ETIME;);
Because the if statement doesn't have curly braces it means we always
return -ETIME and the function never succeeds.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Cc: stable <stable@vger.kernel.org> # 2.6.36+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2013-08-20 11:57:35 +03:00 committed by Greg Kroah-Hartman
parent ded82ef91e
commit 2c4283ca7c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/comedi/drivers/dt282x.c
View File

@ -267,8 +267,9 @@ struct dt282x_private {
} \ } \
udelay(5); \ udelay(5); \
} \ } \
if (_i) \ if (_i) { \
b \ b \
} \
} while (0) } while (0)
static int prep_ai_dma(struct comedi_device *dev, int chan, int size); static int prep_ai_dma(struct comedi_device *dev, int chan, int size);