openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: lustre: fix inverted test on strcmp 

This code tests various fields to see if they are different, except
for one where there test is if they are the same.
This is clearly wrong for a function that is tesding for equality.

So change "!strcmp()" which I always find hard to read, to
"strcmp() != 0" which obviously means that the strings are not equal.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
NeilBrown 2018-02-13 08:09:25 +11:00 committed by Greg Kroah-Hartman
parent 1b168a467f
commit 2cd466fecc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/lustre/lustre/include/lustre_lmv.h
View File

@ -63,7 +63,7 @@ lsm_md_eq(const struct lmv_stripe_md *lsm1, const struct lmv_stripe_md *lsm2)
lsm1->lsm_md_master_mdt_index != lsm2->lsm_md_master_mdt_index || lsm1->lsm_md_master_mdt_index != lsm2->lsm_md_master_mdt_index ||
lsm1->lsm_md_hash_type != lsm2->lsm_md_hash_type || lsm1->lsm_md_hash_type != lsm2->lsm_md_hash_type ||
lsm1->lsm_md_layout_version != lsm2->lsm_md_layout_version || lsm1->lsm_md_layout_version != lsm2->lsm_md_layout_version ||
!strcmp(lsm1->lsm_md_pool_name, lsm2->lsm_md_pool_name)) strcmp(lsm1->lsm_md_pool_name, lsm2->lsm_md_pool_name) != 0)
return false; return false;
for (idx = 0; idx < lsm1->lsm_md_stripe_count; idx++) { for (idx = 0; idx < lsm1->lsm_md_stripe_count; idx++) {