openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

pwm: iqs620a: Simplify using devm_pwmchip_add() 

This allows to drop the platform_driver's remove function. This is the
only user of driver data so this can go away, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
This commit is contained in:
Uwe Kleine-König 2021-07-07 18:28:06 +02:00 committed by Thierry Reding
parent d8c11a6505
commit 2e27afd055
1 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/pwm/pwm-iqs620a.c
View File

@ -189,7 +189,6 @@ static int iqs620_pwm_probe(struct platform_device *pdev)
if (!iqs620_pwm) if (!iqs620_pwm)
return -ENOMEM; return -ENOMEM;
platform_set_drvdata(pdev, iqs620_pwm);
iqs620_pwm->iqs62x = iqs62x; iqs620_pwm->iqs62x = iqs62x;
ret = regmap_read(iqs62x->regmap, IQS620_PWR_SETTINGS, &val); ret = regmap_read(iqs62x->regmap, IQS620_PWR_SETTINGS, &val);
@ -224,31 +223,18 @@ static int iqs620_pwm_probe(struct platform_device *pdev)
if (ret) if (ret)
return ret; return ret;
ret = pwmchip_add(&iqs620_pwm->chip); ret = devm_pwmchip_add(&pdev->dev, &iqs620_pwm->chip);
if (ret) if (ret)
dev_err(&pdev->dev, "Failed to add device: %d\n", ret); dev_err(&pdev->dev, "Failed to add device: %d\n", ret);
return ret; return ret;
} }
static int iqs620_pwm_remove(struct platform_device *pdev)
{
struct iqs620_pwm_private *iqs620_pwm = platform_get_drvdata(pdev);
int ret;
ret = pwmchip_remove(&iqs620_pwm->chip);
if (ret)
dev_err(&pdev->dev, "Failed to remove device: %d\n", ret);
return ret;
}
static struct platform_driver iqs620_pwm_platform_driver = { static struct platform_driver iqs620_pwm_platform_driver = {
.driver = { .driver = {
.name = "iqs620a-pwm", .name = "iqs620a-pwm",
}, },
.probe = iqs620_pwm_probe, .probe = iqs620_pwm_probe,
.remove = iqs620_pwm_remove,
}; };
module_platform_driver(iqs620_pwm_platform_driver); module_platform_driver(iqs620_pwm_platform_driver);