openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

brcmsmac: Add missing annotation for brcms_rfkill_set_hw_state() 

Sparse reports a warning at brcms_rfkill_set_hw_state()

warning: context imbalance in brcms_rfkill_set_hw_state()
	- unexpected unlock
The root cause is the missing annotation at brcms_rfkill_set_hw_state()
Add the missing __must_hold(&wl->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200411001933.10072-5-jbi.octave@gmail.com
This commit is contained in:
Jules Irenge 2020-04-11 01:19:28 +01:00 committed by Kalle Valo
parent 1c0e3c73e9
commit 2fe5efb8a4
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
View File

@ -1717,6 +1717,7 @@ int brcms_check_firmwares(struct brcms_info *wl)
* precondition: perimeter lock has been acquired * precondition: perimeter lock has been acquired
*/ */
bool brcms_rfkill_set_hw_state(struct brcms_info *wl) bool brcms_rfkill_set_hw_state(struct brcms_info *wl)
__must_hold(&wl->lock)
{ {
bool blocked = brcms_c_check_radio_disabled(wl->wlc); bool blocked = brcms_c_check_radio_disabled(wl->wlc);