openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

USB: yurex: Don't retry on unexpected errors 

According to Greg KH, it has been generally agreed that when a USB
driver encounters an unknown error (or one it can't handle directly),
it should just give up instead of going into a potentially infinite
retry loop.

The three codes -EPROTO, -EILSEQ, and -ETIME fall into this category.
They can be caused by bus errors such as packet loss or corruption,
attempting to communicate with a disconnected device, or by malicious
firmware.  Nowadays the extent of packet loss or corruption is
negligible, so it should be safe for a driver to give up whenever one
of these errors occurs.

Although the yurex driver handles -EILSEQ errors in this way, it
doesn't do the same for -EPROTO (as discovered by the syzbot fuzzer)
or other unrecognized errors.  This patch adjusts the driver so that
it doesn't log an error message for -EPROTO or -ETIME, and it doesn't
retry after any errors.

Reported-and-tested-by: syzbot+b24d736f18a1541ad550@syzkaller.appspotmail.com
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: Tomoki Sekiyama <tomoki.sekiyama@gmail.com>
CC: <stable@vger.kernel.org>

Link: https://lore.kernel.org/r/Pine.LNX.4.44L0.1909171245410.1590-100000@iolanthe.rowland.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Alan Stern 2019-09-17 12:47:23 -04:00 committed by Greg Kroah-Hartman
parent b2fa7baee7
commit 32a0721c66
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/usb/misc/yurex.c
View File

@ -132,6 +132,7 @@ static void yurex_interrupt(struct urb *urb)
switch (status) { switch (status) {
case 0: /*success*/ case 0: /*success*/
break; break;
/* The device is terminated or messed up, give up */
case -EOVERFLOW: case -EOVERFLOW:
dev_err(&dev->interface->dev, dev_err(&dev->interface->dev,
"%s - overflow with length %d, actual length is %d\n", "%s - overflow with length %d, actual length is %d\n",
@ -140,12 +141,13 @@ static void yurex_interrupt(struct urb *urb)
case -ENOENT: case -ENOENT:
case -ESHUTDOWN: case -ESHUTDOWN:
case -EILSEQ: case -EILSEQ:
/* The device is terminated, clean up */ case -EPROTO:
case -ETIME:
return; return;
default: default:
dev_err(&dev->interface->dev, dev_err(&dev->interface->dev,
"%s - unknown status received: %d\n", __func__, status); "%s - unknown status received: %d\n", __func__, status);
goto exit; return;
} }
/* handle received message */ /* handle received message */
@ -177,7 +179,6 @@ static void yurex_interrupt(struct urb *urb)
break; break;
} }
exit:
retval = usb_submit_urb(dev->urb, GFP_ATOMIC); retval = usb_submit_urb(dev->urb, GFP_ATOMIC);
if (retval) { if (retval) {
dev_err(&dev->interface->dev, "%s - usb_submit_urb failed: %d\n", dev_err(&dev->interface->dev, "%s - usb_submit_urb failed: %d\n",