openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

USB: usb_wwan: clean up delayed-urb submission 

Clean up and rename delay-urb submission function using a more
descriptive name.

Also add comment on locking assumptions.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2014-05-26 19:23:27 +02:00 committed by Greg Kroah-Hartman
parent 37357ca5a4
commit 3362c91c78
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/usb/serial/usb_wwan.c
View File

@ -602,7 +602,8 @@ int usb_wwan_suspend(struct usb_serial *serial, pm_message_t message)
} }
EXPORT_SYMBOL(usb_wwan_suspend); EXPORT_SYMBOL(usb_wwan_suspend);
static int play_delayed(struct usb_serial_port *port) /* Caller must hold susp_lock. */
static int usb_wwan_submit_delayed_urbs(struct usb_serial_port *port)
{ {
struct usb_serial *serial = port->serial; struct usb_serial *serial = port->serial;
struct usb_wwan_intf_private *data = usb_get_serial_data(serial); struct usb_wwan_intf_private *data = usb_get_serial_data(serial);
@ -613,11 +614,14 @@ static int play_delayed(struct usb_serial_port *port)
portdata = usb_get_serial_port_data(port); portdata = usb_get_serial_port_data(port);
while ((urb = usb_get_from_anchor(&portdata->delayed))) { for (;;) {
urb = usb_get_from_anchor(&portdata->delayed);
if (!urb)
break;
err = usb_submit_urb(urb, GFP_ATOMIC); err = usb_submit_urb(urb, GFP_ATOMIC);
if (err) { if (err) {
dev_err(&port->dev, dev_err(&port->dev, "%s: submit urb failed: %d\n",
"%s: submit write urb failed: %d\n",
__func__, err); __func__, err);
err_count++; err_count++;
unbusy_queued_urb(urb, portdata); unbusy_queued_urb(urb, portdata);
@ -664,7 +668,7 @@ int usb_wwan_resume(struct usb_serial *serial)
} }
} }
err = play_delayed(port); err = usb_wwan_submit_delayed_urbs(port);
if (err) if (err)
err_count++; err_count++;