openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: ethernet: don't set phylib state CHANGELINK in drivers 

After phy_start() phylib takes care of all needed actions, including
aneg settings and checking link state. There's no need to set state
PHY_CHANGELINK in drivers.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Heiner Kallweit 2018-12-19 00:43:58 +01:00 committed by David S. Miller
parent 624b66f8c9
commit 33f18c96af
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/amd/au1000_eth.c
View File

@ -940,11 +940,8 @@ static int au1000_open(struct net_device *dev)
return retval;
}
if (dev->phydev) {
/* cause the PHY state machine to schedule a link state check */
dev->phydev->state = PHY_CHANGELINK;
if (dev->phydev)
phy_start(dev->phydev);
}
netif_start_queue(dev);

1
drivers/net/ethernet/ti/cpmac.c
View File

@ -991,7 +991,6 @@ static int cpmac_open(struct net_device *dev)
cpmac_hw_start(dev);
napi_enable(&priv->napi);
dev->phydev->state = PHY_CHANGELINK;
phy_start(dev->phydev);
return 0;