openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

be2net: bug fix in be_change_mtu 

Current code allows the new mtu to cross the supported value.
This patch fixes the boundary checks.

From: Suresh R <sureshr@serverengines.com>
Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ajit Khaparde 2010-02-09 01:32:43 +00:00 committed by David S. Miller
parent 3f0d4560ae
commit 34a89b8c75
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/benet/be_main.c
View File

@ -473,10 +473,12 @@ static int be_change_mtu(struct net_device *netdev, int new_mtu)
{ {
struct be_adapter *adapter = netdev_priv(netdev); struct be_adapter *adapter = netdev_priv(netdev);
if (new_mtu < BE_MIN_MTU || if (new_mtu < BE_MIN_MTU ||
new_mtu > BE_MAX_JUMBO_FRAME_SIZE) { new_mtu > (BE_MAX_JUMBO_FRAME_SIZE -
(ETH_HLEN + ETH_FCS_LEN))) {
dev_info(&adapter->pdev->dev, dev_info(&adapter->pdev->dev,
"MTU must be between %d and %d bytes\n", "MTU must be between %d and %d bytes\n",
BE_MIN_MTU, BE_MAX_JUMBO_FRAME_SIZE); BE_MIN_MTU,
(BE_MAX_JUMBO_FRAME_SIZE - (ETH_HLEN + ETH_FCS_LEN)));
return -EINVAL; return -EINVAL;
} }
dev_info(&adapter->pdev->dev, "MTU changed from %d to %d bytes\n", dev_info(&adapter->pdev->dev, "MTU changed from %d to %d bytes\n",