openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: gasket: sysfs: hold reference to device while in use 

Hold a reference to the struct device while a gasket sysfs mapping
exists for the device and a pointer to the struct is kept in the mapping
data structures.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Todd Poynor 2018-07-29 12:36:35 -07:00 committed by Greg Kroah-Hartman
parent 8dd8a48b9a
commit 34cf3ea8da
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/staging/gasket/gasket_sysfs.c
View File

@ -126,6 +126,7 @@ static void put_mapping(struct gasket_sysfs_mapping *mapping)
kfree(mapping->attributes); kfree(mapping->attributes);
mapping->attributes = NULL; mapping->attributes = NULL;
mapping->attribute_count = 0; mapping->attribute_count = 0;
put_device(mapping->device);
mapping->device = NULL; mapping->device = NULL;
mapping->gasket_dev = NULL; mapping->gasket_dev = NULL;
} }
@ -208,22 +209,20 @@ int gasket_sysfs_create_mapping(
device->kobj.name); device->kobj.name);
mapping = &dev_mappings[map_idx]; mapping = &dev_mappings[map_idx];
kref_init(&mapping->refcount);
mapping->device = device;
mapping->gasket_dev = gasket_dev;
mapping->attributes = kcalloc(GASKET_SYSFS_MAX_NODES, mapping->attributes = kcalloc(GASKET_SYSFS_MAX_NODES,
sizeof(*mapping->attributes), sizeof(*mapping->attributes),
GFP_KERNEL); GFP_KERNEL);
mapping->attribute_count = 0;
if (!mapping->attributes) { if (!mapping->attributes) {
dev_dbg(device, "Unable to allocate sysfs attribute array\n"); dev_dbg(device, "Unable to allocate sysfs attribute array\n");
mapping->device = NULL;
mapping->gasket_dev = NULL;
mutex_unlock(&mapping->mutex); mutex_unlock(&mapping->mutex);
mutex_unlock(&function_mutex); mutex_unlock(&function_mutex);
return -ENOMEM; return -ENOMEM;
} }
kref_init(&mapping->refcount);
mapping->device = get_device(device);
mapping->gasket_dev = gasket_dev;
mapping->attribute_count = 0;
mutex_unlock(&mapping->mutex); mutex_unlock(&mapping->mutex);
mutex_unlock(&function_mutex); mutex_unlock(&function_mutex);