openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

media: atomisp-mt9m114: remove dead data 

It seems that, originally, the logic would allow selecting between
fine and coarse integration. However, only coarse seems to be
implemented.

Get rid of this warning:

  drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c: In function 'mt9m114_s_exposure':
  drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c:1003:6: warning: variable 'exposure_local' set but not used [-Wunused-but-set-variable]
    u16 exposure_local[3];
        ^~~~~~~~~~~~~~

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Mauro Carvalho Chehab 2018-04-16 12:37:11 -04:00 committed by Mauro Carvalho Chehab
parent 0015b19070
commit 357486eca8
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
View File

@ -995,12 +995,10 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
struct mt9m114_device *dev = to_mt9m114_sensor(sd); struct mt9m114_device *dev = to_mt9m114_sensor(sd);
int ret = 0; int ret = 0;
unsigned int coarse_integration = 0; unsigned int coarse_integration = 0;
unsigned int fine_integration = 0;
unsigned int FLines = 0; unsigned int FLines = 0;
unsigned int FrameLengthLines = 0; /* ExposureTime.FrameLengthLines; */ unsigned int FrameLengthLines = 0; /* ExposureTime.FrameLengthLines; */
unsigned int AnalogGain, DigitalGain; unsigned int AnalogGain, DigitalGain;
u32 AnalogGainToWrite = 0; u32 AnalogGainToWrite = 0;
u16 exposure_local[3];
dev_dbg(&client->dev, "%s(0x%X 0x%X 0x%X)\n", __func__, dev_dbg(&client->dev, "%s(0x%X 0x%X 0x%X)\n", __func__,
exposure->integration_time[0], exposure->gain[0], exposure->integration_time[0], exposure->gain[0],
@ -1032,10 +1030,7 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
return -EINVAL; return -EINVAL;
} }
/* set coarse/fine integration */ /* set coarse integration */
exposure_local[0] = REG_EXPO_COARSE;
exposure_local[1] = (u16)coarse_integration;
exposure_local[2] = (u16)fine_integration;
/* 3A provide real exposure time. /* 3A provide real exposure time.
should not translate to any value here. */ should not translate to any value here. */
ret = mt9m114_write_reg(client, MISENSOR_16BIT, ret = mt9m114_write_reg(client, MISENSOR_16BIT,