openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

video/hmdi: Clear the whole incoming buffer, not just the infoframe size 

If the user if this API is providing a bigger buffer than the infoframe
size, it could be for a could reason. For instance it could be because
it gives the buffer that will be written to the hardware, up to the
maximum of an infoframe size.

Instead of just zeroing up to the infoframe size, let's zero the whole
incoming buffer as those extra bytes are also used to compute the
ECC and need to be 0.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Acked-by: Dave Airlie <airlied@gmail.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Damien Lespiau 2013-08-06 20:32:16 +01:00 committed by Daniel Vetter
parent 61177b0e12
commit 3b390f6267
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/video/hdmi.c
View File

@ -84,7 +84,7 @@ ssize_t hdmi_avi_infoframe_pack(struct hdmi_avi_infoframe *frame, void *buffer,
if (size < length) if (size < length)
return -ENOSPC; return -ENOSPC;
memset(buffer, 0, length); memset(buffer, 0, size);
ptr[0] = frame->type; ptr[0] = frame->type;
ptr[1] = frame->version; ptr[1] = frame->version;
@ -186,7 +186,7 @@ ssize_t hdmi_spd_infoframe_pack(struct hdmi_spd_infoframe *frame, void *buffer,
if (size < length) if (size < length)
return -ENOSPC; return -ENOSPC;
memset(buffer, 0, length); memset(buffer, 0, size);
ptr[0] = frame->type; ptr[0] = frame->type;
ptr[1] = frame->version; ptr[1] = frame->version;
@ -251,7 +251,7 @@ ssize_t hdmi_audio_infoframe_pack(struct hdmi_audio_infoframe *frame,
if (size < length) if (size < length)
return -ENOSPC; return -ENOSPC;
memset(buffer, 0, length); memset(buffer, 0, size);
if (frame->channels >= 2) if (frame->channels >= 2)
channels = frame->channels - 1; channels = frame->channels - 1;
@ -308,7 +308,7 @@ ssize_t hdmi_vendor_infoframe_pack(struct hdmi_vendor_infoframe *frame,
if (size < length) if (size < length)
return -ENOSPC; return -ENOSPC;
memset(buffer, 0, length); memset(buffer, 0, size);
ptr[0] = frame->type; ptr[0] = frame->type;
ptr[1] = frame->version; ptr[1] = frame->version;