openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm/panfrost: Fix a BO leak in panfrost_ioctl_mmap_bo() 

We should release the reference we grabbed when an error occurs.

Fixes: 187d292920 ("drm/panfrost: Add support for GPU heap allocations")
Cc: <stable@vger.kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20191129135908.2439529-4-boris.brezillon@collabora.com
This commit is contained in:
Boris Brezillon 2019-11-29 14:59:03 +01:00 committed by Rob Herring
parent 70cc77952e
commit 3bb69dbcb9
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/gpu/drm/panfrost/panfrost_drv.c
View File

@ -303,14 +303,17 @@ static int panfrost_ioctl_mmap_bo(struct drm_device *dev, void *data,
} }
/* Don't allow mmapping of heap objects as pages are not pinned. */ /* Don't allow mmapping of heap objects as pages are not pinned. */
if (to_panfrost_bo(gem_obj)->is_heap) if (to_panfrost_bo(gem_obj)->is_heap) {
return -EINVAL; ret = -EINVAL;
goto out;
}
ret = drm_gem_create_mmap_offset(gem_obj); ret = drm_gem_create_mmap_offset(gem_obj);
if (ret == 0) if (ret == 0)
args->offset = drm_vma_node_offset_addr(&gem_obj->vma_node); args->offset = drm_vma_node_offset_addr(&gem_obj->vma_node);
drm_gem_object_put_unlocked(gem_obj);
out:
drm_gem_object_put_unlocked(gem_obj);
return ret; return ret;
} }