openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

mlx4: Setting new port types after all interfaces unregistered 

In port type change flow, need to set the new port types only after
all interfaces have finished the unregister process.
Otherwise, during unregister, one of the interfaces might issue a SET_PORT
command with wrong port types, it can cause bad FW behavior.

Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Yevgeny Petrilin 2012-02-21 03:41:07 +00:00 committed by David S. Miller
parent 730c41d5ba
commit 3d8f93083b
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/mellanox/mlx4/main.c
View File

@ -531,15 +531,14 @@ int mlx4_change_port_types(struct mlx4_dev *dev,
for (port = 0; port < dev->caps.num_ports; port++) { for (port = 0; port < dev->caps.num_ports; port++) {
/* Change the port type only if the new type is different /* Change the port type only if the new type is different
* from the current, and not set to Auto */ * from the current, and not set to Auto */
if (port_types[port] != dev->caps.port_type[port + 1]) { if (port_types[port] != dev->caps.port_type[port + 1])
change = 1; change = 1;
dev->caps.port_type[port + 1] = port_types[port];
}
} }
if (change) { if (change) {
mlx4_unregister_device(dev); mlx4_unregister_device(dev);
for (port = 1; port <= dev->caps.num_ports; port++) { for (port = 1; port <= dev->caps.num_ports; port++) {
mlx4_CLOSE_PORT(dev, port); mlx4_CLOSE_PORT(dev, port);
dev->caps.port_type[port + 1] = port_types[port];
err = mlx4_SET_PORT(dev, port); err = mlx4_SET_PORT(dev, port);
if (err) { if (err) {
mlx4_err(dev, "Failed to set port %d, " mlx4_err(dev, "Failed to set port %d, "