openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: ks7010: utilize local variable 

Function contains a local pointer variable defined to a memory location
within a structure. This memory location is later used by
dereferencing the struct instead of using the local pointer. The code
is cleaner if all references of the same memory location use the
local variable.

Utilize existing local pointer variable instead of dereferencing
struct.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tobin C. Harding 2017-04-10 13:15:51 +10:00 committed by Greg Kroah-Hartman
parent b121d84882
commit 3da1b2371e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/ks7010/ks_wlan_net.c
View File

@ -1788,9 +1788,9 @@ static int ks_wlan_set_encode_ext(struct net_device *dev,
key = &priv->wpa.key[index]; key = &priv->wpa.key[index];
if (dwrq->flags & IW_ENCODE_DISABLED) if (dwrq->flags & IW_ENCODE_DISABLED)
priv->wpa.key[index].key_len = 0; key->key_len = 0;
priv->wpa.key[index].ext_flags = enc->ext_flags; key->ext_flags = enc->ext_flags;
if (enc->ext_flags & IW_ENCODE_EXT_SET_TX_KEY) { if (enc->ext_flags & IW_ENCODE_EXT_SET_TX_KEY) {
priv->wpa.txkey = index; priv->wpa.txkey = index;
commit |= SME_WEP_INDEX; commit |= SME_WEP_INDEX;
@ -1806,7 +1806,7 @@ static int ks_wlan_set_encode_ext(struct net_device *dev,
priv->reg.privacy_invoked = 0x00; priv->reg.privacy_invoked = 0x00;
commit |= SME_WEP_FLAG; commit |= SME_WEP_FLAG;
} }
priv->wpa.key[index].key_len = 0; key->key_len = 0;
break; break;
case IW_ENCODE_ALG_WEP: case IW_ENCODE_ALG_WEP:
@ -1842,7 +1842,7 @@ static int ks_wlan_set_encode_ext(struct net_device *dev,
default: default:
return -EINVAL; return -EINVAL;
} }
priv->wpa.key[index].alg = enc->alg; key->alg = enc->alg;
if (commit) { if (commit) {
if (commit & SME_WEP_INDEX) if (commit & SME_WEP_INDEX)