openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: lustre: lnet: peer: Use list_for_each_entry_safe 

Doubly linked lists which are  iterated  using list_empty
and list_entry macros have been replaced with list_for_each_entry_safe
macro.
This makes the iteration simpler and more readable.

This patch replaces the while loop containing list_empty and list_entry
with list_for_each_entry_safe.

This was done with Coccinelle.

@@
expression E1;
identifier I1, I2;
type T;
iterator name list_for_each_entry_safe;
@@

T *I1;
+ T *tmp;
...
- while (list_empty(&E1) == 0)
+ list_for_each_entry_safe (I1, tmp, &E1, I2)
{
...when != T *I1;
- I1 = list_entry(E1.next, T, I2);
...
}

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Bhaktipriya Shridhar 2016-03-12 01:33:46 +05:30 committed by Greg Kroah-Hartman
parent cb734cf73e
commit 3e47a1cfba
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/lustre/lnet/lnet/peer.c
View File

@ -177,6 +177,7 @@ lnet_peer_tables_cleanup(lnet_ni_t *ni)
struct lnet_peer_table *ptable; struct lnet_peer_table *ptable;
struct list_head deathrow; struct list_head deathrow;
lnet_peer_t *lp; lnet_peer_t *lp;
lnet_peer_t *temp;
int i; int i;
INIT_LIST_HEAD(&deathrow); INIT_LIST_HEAD(&deathrow);
@ -210,8 +211,7 @@ lnet_peer_tables_cleanup(lnet_ni_t *ni)
lnet_net_unlock(i); lnet_net_unlock(i);
} }
while (!list_empty(&deathrow)) { list_for_each_entry_safe(lp, temp, &deathrow, lp_hashlist) {
lp = list_entry(deathrow.next, lnet_peer_t, lp_hashlist);
list_del(&lp->lp_hashlist); list_del(&lp->lp_hashlist);
LIBCFS_FREE(lp, sizeof(*lp)); LIBCFS_FREE(lp, sizeof(*lp));
} }