openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

iscsi-target: Fix processing of OOO commands 

Fix two issues in OOO commands processing done at iscsit_attach_ooo_cmdsn.

Handle command serial numbers wrap around by using iscsi_sna_lt and not regular comparisson.

The routine iterates until it finds an entry whose serial number is greater than the serial number of
the new one, thus the new entry should be inserted before that entry and not after.

Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Shlomo Pongratz 2013-05-05 17:36:26 +03:00 committed by Nicholas Bellinger
parent 80690fdb95
commit 3eccfdb01d
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/target/iscsi/iscsi_target_erl1.c
View File

@ -823,7 +823,7 @@ static int iscsit_attach_ooo_cmdsn(
/* /*
* CmdSN is greater than the tail of the list. * CmdSN is greater than the tail of the list.
*/ */
if (ooo_tail->cmdsn < ooo_cmdsn->cmdsn) if (iscsi_sna_lt(ooo_tail->cmdsn, ooo_cmdsn->cmdsn))
list_add_tail(&ooo_cmdsn->ooo_list, list_add_tail(&ooo_cmdsn->ooo_list,
&sess->sess_ooo_cmdsn_list); &sess->sess_ooo_cmdsn_list);
else { else {
@ -833,11 +833,12 @@ static int iscsit_attach_ooo_cmdsn(
*/ */
list_for_each_entry(ooo_tmp, &sess->sess_ooo_cmdsn_list, list_for_each_entry(ooo_tmp, &sess->sess_ooo_cmdsn_list,
ooo_list) { ooo_list) {
if (ooo_tmp->cmdsn < ooo_cmdsn->cmdsn) if (iscsi_sna_lt(ooo_tmp->cmdsn, ooo_cmdsn->cmdsn))
continue; continue;
/* Insert before this entry */
list_add(&ooo_cmdsn->ooo_list, list_add(&ooo_cmdsn->ooo_list,
&ooo_tmp->ooo_list); ooo_tmp->ooo_list.prev);
break; break;
} }
} }