openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: spider_net: Use struct_size() helper 

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct spider_net_card {
	...
        struct spider_net_descr darray[0];
};

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

So, replace the following form:

sizeof(struct spider_net_card) + (tx_descriptors + rx_descriptors) * sizeof(struct spider_net_descr)

with:

struct_size(card, darray, tx_descriptors + rx_descriptors)

Notice that, in this case, variable alloc_size is not necessary, hence it
is removed.

Building: allmodconfig powerpc.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Gustavo A. R. Silva 2019-08-28 15:21:08 -05:00 committed by David S. Miller
parent b4e11253b1
commit 3f1071ec39
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/toshiba/spider_net.c
View File

@ -2311,11 +2311,9 @@ spider_net_alloc_card(void)
{ {
struct net_device *netdev; struct net_device *netdev;
struct spider_net_card *card; struct spider_net_card *card;
size_t alloc_size;
alloc_size = sizeof(struct spider_net_card) + netdev = alloc_etherdev(struct_size(card, darray,
(tx_descriptors + rx_descriptors) * sizeof(struct spider_net_descr); tx_descriptors + rx_descriptors));
netdev = alloc_etherdev(alloc_size);
if (!netdev) if (!netdev)
return NULL; return NULL;