[SCSI] libfc: adds missing exch release for accepted RRQ

Adds missing exch release when RRQ is accepted by calling
fc_seq_ls_acc. Adds common exch release for fc_exch_els_rrq
by use of out label.

Reported-by: Alex Lyakas <alexl@mellanox.co.il>
Signed-off-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
This commit is contained in:
Vasu Dev 2009-10-21 16:27:33 -07:00 committed by James Bottomley
parent 89f19a59de
commit 3f127ad97a
1 changed files with 5 additions and 4 deletions

View File

@ -1718,7 +1718,7 @@ static void fc_exch_rrq(struct fc_exch *ep)
*/ */
static void fc_exch_els_rrq(struct fc_seq *sp, struct fc_frame *fp) static void fc_exch_els_rrq(struct fc_seq *sp, struct fc_frame *fp)
{ {
struct fc_exch *ep; /* request or subject exchange */ struct fc_exch *ep = NULL; /* request or subject exchange */
struct fc_els_rrq *rp; struct fc_els_rrq *rp;
u32 sid; u32 sid;
u16 xid; u16 xid;
@ -1768,15 +1768,16 @@ static void fc_exch_els_rrq(struct fc_seq *sp, struct fc_frame *fp)
* Send LS_ACC. * Send LS_ACC.
*/ */
fc_seq_ls_acc(sp); fc_seq_ls_acc(sp);
fc_frame_free(fp); goto out;
return;
unlock_reject: unlock_reject:
spin_unlock_bh(&ep->ex_lock); spin_unlock_bh(&ep->ex_lock);
fc_exch_release(ep); /* drop hold from fc_exch_find */
reject: reject:
fc_seq_ls_rjt(sp, ELS_RJT_LOGIC, explan); fc_seq_ls_rjt(sp, ELS_RJT_LOGIC, explan);
out:
fc_frame_free(fp); fc_frame_free(fp);
if (ep)
fc_exch_release(ep); /* drop hold from fc_exch_find */
} }
struct fc_exch_mgr_anchor *fc_exch_mgr_add(struct fc_lport *lport, struct fc_exch_mgr_anchor *fc_exch_mgr_add(struct fc_lport *lport,