openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

RTC/watchdog: M41T80: fix a potential use of unitialized data 

Watchdog handlers within the driver make use of "save_client" -- make sure it
has been initalized before the handlers are registered.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexander Bigga <ab@mycable.de>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Maciej W. Rozycki 2008-05-12 14:02:35 -07:00 committed by Linus Torvalds
parent 6c82c41509
commit 417607d05f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/rtc/rtc-m41t80.c
View File

@ -803,6 +803,7 @@ static int m41t80_probe(struct i2c_client *client,
#ifdef CONFIG_RTC_DRV_M41T80_WDT #ifdef CONFIG_RTC_DRV_M41T80_WDT
if (clientdata->features & M41T80_FEATURE_HT) { if (clientdata->features & M41T80_FEATURE_HT) {
save_client = client;
rc = misc_register(&wdt_dev); rc = misc_register(&wdt_dev);
if (rc) if (rc)
goto exit; goto exit;
@ -811,7 +812,6 @@ static int m41t80_probe(struct i2c_client *client,
misc_deregister(&wdt_dev); misc_deregister(&wdt_dev);
goto exit; goto exit;
} }
save_client = client;
} }
#endif #endif
return 0; return 0;